diff options
author | Rahul Chaudhry <rahulchaudhry@chromium.org> | 2016-01-29 16:46:24 -0800 |
---|---|---|
committer | chrome-bot <chrome-bot@chromium.org> | 2016-02-01 23:06:53 +0000 |
commit | c55a14c3dd2fe62775bc35a09bd3467389d9bdd8 (patch) | |
tree | fa3d7007e843b89e80f196da81d279d39643922d | |
parent | 4f07bbf3bc13b73d42c94608a9707d6c6f890015 (diff) | |
download | toolchain-utils-c55a14c3dd2fe62775bc35a09bd3467389d9bdd8.tar.gz |
toolchain-utils: fix attribute-defined-outside-init lint errors.
BUG=chromium:570458
TEST='crosperf/run_tests.sh' passes.
Change-Id: If8c79fa74f30c40a67a9f0dee855a38d3e3a9c46
Reviewed-on: https://chrome-internal-review.googlesource.com/246491
Commit-Ready: Rahul Chaudhry <rahulchaudhry@google.com>
Tested-by: Rahul Chaudhry <rahulchaudhry@google.com>
Reviewed-by: Caroline Tice <cmtice@google.com>
-rwxr-xr-x | crosperf/experiment_runner_unittest.py | 3 | ||||
-rwxr-xr-x | crosperf/machine_manager_unittest.py | 6 | ||||
-rw-r--r-- | utils/no_pseudo_terminal_test.py | 1 | ||||
-rwxr-xr-x | utils/perf_diff.py | 1 | ||||
-rw-r--r-- | utils/tabulator.py | 2 |
5 files changed, 12 insertions, 1 deletions
diff --git a/crosperf/experiment_runner_unittest.py b/crosperf/experiment_runner_unittest.py index c4ee2cf4..cd4556ae 100755 --- a/crosperf/experiment_runner_unittest.py +++ b/crosperf/experiment_runner_unittest.py @@ -95,7 +95,8 @@ class FakeLogger(object): class ExperimentRunnerTest(unittest.TestCase): """Test for experiment runner class.""" - run_counter = 0 + run_count = 0 + is_complete_count = 0 mock_logger = FakeLogger() mock_cmd_exec = mock.Mock(spec=command_executer.CommandExecuter) diff --git a/crosperf/machine_manager_unittest.py b/crosperf/machine_manager_unittest.py index 3100a94a..a56c062b 100755 --- a/crosperf/machine_manager_unittest.py +++ b/crosperf/machine_manager_unittest.py @@ -61,6 +61,12 @@ LABEL_MIX = label.MockLabel('mix', 'chromeos_image', CHROMEOS_ROOT, 'mix', class MachineManagerTest(unittest.TestCase): """Test for machine manager class.""" + msgs = [] + image_log = [] + log_fatal_msgs = [] + fake_logger_count = 0 + fake_logger_msgs = [] + mock_cmd_exec = mock.Mock(spec=command_executer.CommandExecuter) mock_logger = mock.Mock(spec=logger.Logger) diff --git a/utils/no_pseudo_terminal_test.py b/utils/no_pseudo_terminal_test.py index 0290e40e..94dba389 100644 --- a/utils/no_pseudo_terminal_test.py +++ b/utils/no_pseudo_terminal_test.py @@ -13,6 +13,7 @@ from utils import command_executer class NoPsuedoTerminalTest(unittest.TestCase): """Test to ensure we're not touching /dev/ptmx when running commands.""" + _strace_process = None STRACE_TIMEOUT = 10 def _AttachStraceToSelf(self, output_file): diff --git a/utils/perf_diff.py b/utils/perf_diff.py index ee5a4b80..c861f6ba 100755 --- a/utils/perf_diff.py +++ b/utils/perf_diff.py @@ -104,6 +104,7 @@ class Section(object): """Section formatting.""" def __init__(self, contents): + self.name = '' self.raw_contents = contents self._ParseSection() diff --git a/utils/tabulator.py b/utils/tabulator.py index 2c317a72..0054595c 100644 --- a/utils/tabulator.py +++ b/utils/tabulator.py @@ -970,6 +970,8 @@ class TablePrinter(object): """Constructor that stores the cell table and output type.""" self._table = table self._output_type = output_type + self._row_styles = [] + self._column_styles = [] # Compute whole-table properties like max-size, etc. def _ComputeStyle(self): |