diff options
| author | Bob Haarman <inglorion@google.com> | 2020-05-01 14:15:28 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-05-02 06:30:38 +0000 |
| commit | 42e215fef37c81fc1904cb0e338bb98089ff5e72 (patch) | |
| tree | bd3a44b15847240faf111c57a349acbb0f2f39a7 /buildbot_test_toolchains.py | |
| parent | fbefdc4647a046010844aa2ea2551f15c80ef3aa (diff) | |
| download | toolchain-utils-42e215fef37c81fc1904cb0e338bb98089ff5e72.tar.gz | |
toolchain-utils: s/_/-/g on board names in buildbot_test_toolchains.py
Some boards are spelled inconsistently, having underscores in some
places and dashes in others. This was causing nightly test reporting
to fail for one board. This change makes use query with consistent
naming by always using dashes in the board name and.
BUG=chromium:1077313
TEST=Ran script with --test=True, see new URI, gsutil ls URI gives results.
Change-Id: I7fabed1c85009e3b84e3c320aff0c7186db3d001
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2174834
Reviewed-by: Tiancong Wang <tcwang@google.com>
Commit-Queue: Bob Haarman <inglorion@chromium.org>
Tested-by: Bob Haarman <inglorion@chromium.org>
Diffstat (limited to 'buildbot_test_toolchains.py')
| -rwxr-xr-x | buildbot_test_toolchains.py | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/buildbot_test_toolchains.py b/buildbot_test_toolchains.py index 1e8b33ac..026a4ae5 100755 --- a/buildbot_test_toolchains.py +++ b/buildbot_test_toolchains.py @@ -266,8 +266,12 @@ class ToolchainComparator(object): """ if self._recipe: print('Using recipe buckets to get latest image.') + # crbug.com/1077313: Some boards are not consistently + # spelled, having underscores in some places and dashes in others. + # The image directories consistenly use dashes, so convert underscores + # to dashes to work around this. trybot_image = buildbot_utils.GetLatestRecipeImage( - self._chromeos_root, '%s-llvm-next-nightly' % self._board) + self._chromeos_root, '%s-llvm-next-nightly' % self._board.replace('_', '-')) else: # Launch tryjob and wait to get image location. buildbucket_id, trybot_image = buildbot_utils.GetTrybotImage( |