aboutsummaryrefslogtreecommitdiff
path: root/llvm_tools/manifest_utils.py
diff options
context:
space:
mode:
Diffstat (limited to 'llvm_tools/manifest_utils.py')
-rw-r--r--llvm_tools/manifest_utils.py9
1 files changed, 3 insertions, 6 deletions
diff --git a/llvm_tools/manifest_utils.py b/llvm_tools/manifest_utils.py
index 67eae4f3..3d6337bf 100644
--- a/llvm_tools/manifest_utils.py
+++ b/llvm_tools/manifest_utils.py
@@ -11,6 +11,7 @@ on toolchain projects (llvm-project, etc.) which are public.
from pathlib import Path
import shutil
import subprocess
+from typing import List, Union
from xml.etree import ElementTree
import atomic_write_file
@@ -22,14 +23,10 @@ LLVM_PROJECT_PATH = "src/third_party/llvm-project"
class FormattingError(Exception):
"""Error occurred when formatting the manifest."""
- pass
-
class UpdateManifestError(Exception):
"""Error occurred when updating the manifest."""
- pass
-
def make_xmlparser():
"""Return a new xmlparser with custom TreeBuilder."""
@@ -64,7 +61,7 @@ def update_chromeos_manifest(revision: str, src_tree: Path) -> Path:
xmltree = ElementTree.parse(manifest_path, parser)
update_chromeos_manifest_tree(revision, xmltree.getroot())
with atomic_write_file.atomic_write(manifest_path, mode="wb") as f:
- xmltree.write(f, encoding="UTF-8")
+ xmltree.write(f, encoding="utf-8")
format_manifest(manifest_path)
return manifest_path
@@ -99,5 +96,5 @@ def format_manifest(repo_manifest: Path):
raise FormattingError(
"unable to format manifest, 'cros'" " executable not in PATH"
)
- cmd = ["cros", "format", repo_manifest]
+ cmd: List[Union[str, Path]] = ["cros", "format", repo_manifest]
subprocess.run(cmd, check=True)