aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChih-hung Hsieh <chh@google.com>2016-08-19 18:05:08 +0000
committerandroid-build-merger <android-build-merger@google.com>2016-08-19 18:05:08 +0000
commit232946f5a985c6a615d64f6bb4adee2c14adf46b (patch)
tree97d2746c8b0255f1661a69ef517a23e35f2fbe7d
parent3c32c3009e85551694adcf5165043426885d7197 (diff)
parent474a9af0b46e2bbc03ccddd2549d6fe479e62a96 (diff)
downloadvalgrind-232946f5a985c6a615d64f6bb4adee2c14adf46b.tar.gz
Merge "Revert "Fix clang compiled memset recursive call problem.""
am: 474a9af0b4 Change-Id: Ieaab9a6c19f8759d4186ba1b35ea5fa51d9bfc60
-rw-r--r--Android.build_host.mk6
-rw-r--r--Android.build_one.mk8
2 files changed, 7 insertions, 7 deletions
diff --git a/Android.build_host.mk b/Android.build_host.mk
index ee07d2de3..77d11ba4d 100644
--- a/Android.build_host.mk
+++ b/Android.build_host.mk
@@ -23,8 +23,10 @@ else
vg_local_arch := amd64
endif
-# Do not call (builtin) memset from VG(memset).
-LOCAL_CLANG_CFLAGS += -fno-builtin-memset
+# TODO: This workaround is to avoid calling memset from VG(memset)
+# wrapper because of invalid clang optimization; This seems to be
+# limited to amd64/x86 codegen(?);
+LOCAL_CLANG := false
LOCAL_MODULE := $(vg_local_module)-$(vg_local_arch)-linux
diff --git a/Android.build_one.mk b/Android.build_one.mk
index 16ea662bb..cb5de0748 100644
--- a/Android.build_one.mk
+++ b/Android.build_one.mk
@@ -23,15 +23,13 @@ LOCAL_MULTILIB := first
vg_local_arch := $(vg_arch)
endif
-# For arm and arm64 targets, clang compiled module has other
-# undefined errors, see bug 28454823.
+# TODO: This workaround is to avoid calling memset from VG(memset)
+# wrapper because of invalid clang optimization; This seems to be
+# limited to amd64/x86 codegen(?);
ifeq ($(filter $TARGET_ARCH,x86 x86_64),)
LOCAL_CLANG := false
endif
-# Do not call (builtin) memset from VG(memset).
-LOCAL_CLANG_CFLAGS += -fno-builtin-memset
-
LOCAL_MODULE := $(vg_local_module)-$(vg_local_arch)-linux
LOCAL_MODULE_TARGET_ARCH := $(vg_local_arch)