diff options
| author | Harald Alvestrand <hta@webrtc.org> | 2021-06-22 07:47:34 +0000 |
|---|---|---|
| committer | WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2021-06-22 09:40:47 +0000 |
| commit | 0fe60bd41a9afff43a17a4e38194c7cbbc972421 (patch) | |
| tree | c79aa2f7aec49ce10f0ffc37ded672adc6c73a5d | |
| parent | c413c5581b24f36f7438bd017b8bf0aa602b74ca (diff) | |
| download | webrtc-0fe60bd41a9afff43a17a4e38194c7cbbc972421.tar.gz | |
Add RecursiveCriticalSection to the don't-use list of primitives
Bug: None
Change-Id: If16da4582e1b4ae498982429d8a8eaeb81402099
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/223341
Reviewed-by: Niels Moller <nisse@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#34354}
| -rw-r--r-- | g3doc/implementation_basics.md | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/g3doc/implementation_basics.md b/g3doc/implementation_basics.md index 114b7a7c92..933941a0d1 100644 --- a/g3doc/implementation_basics.md +++ b/g3doc/implementation_basics.md @@ -80,6 +80,8 @@ in the (slow) process of being removed from the codebase. * AsyncInvoker. +* RecursiveCriticalSection. Try to use [webrtc::Mutex][6] instead, and don't recurse. + [1]: https://source.chromium.org/chromium/chromium/src/+/main:third_party/webrtc/api/units/timestamp.h;drc=b95d90b78a3491ef8e8aa0640dd521515ec881ca;l=29 @@ -87,3 +89,4 @@ in the (slow) process of being removed from the codebase. [3]: https://source.chromium.org/chromium/chromium/src/+/main:third_party/webrtc/api/task_queue/task_queue_base.h;drc=1107751b6f11c35259a1c5c8a0f716e227b7e3b4;l=25 [4]: https://source.chromium.org/chromium/chromium/src/+/main:third_party/webrtc/rtc_base/callback_list.h;drc=54b91412de3f579a2d5ccdead6e04cc2cc5ca3a1;l=162 [5]: https://source.chromium.org/chromium/chromium/src/+/main:third_party/webrtc/rtc_base/task_utils/pending_task_safety_flag.h;drc=86ee89f73e4f4799b3ebcc0b5c65837c9601fe6d;l=117 +[6]: https://source.chromium.org/chromium/chromium/src/+/main:third_party/webrtc/rtc_base/synchronization/mutex.h;drc=0d3c09a8fe5f12dfbc9f1bcd5790fda8830624ec;l=40 |