diff options
| author | Steve Anton <steveanton@webrtc.org> | 2020-01-24 16:13:23 -0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-01-31 19:19:22 +0000 |
| commit | 9d56b0113fff7d833006d54c38701b321852ba5c (patch) | |
| tree | 65a6d7484228e5b4c7df2400e59e4948693a7cd0 | |
| parent | 82271217f114d88c226c600c460283ec4c2961de (diff) | |
| download | webrtc-9d56b0113fff7d833006d54c38701b321852ba5c.tar.gz | |
Re-enable a couple PortAllocator tests under ASAN
Ran each test 10,000 times locally and could not detect any
flakiness.
Bug: webrtc:4743
Change-Id: Iecdf70d878ec8573b9ea5238bc25613c0f3cd171
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167422
Reviewed-by: Qingsi Wang <qingsi@webrtc.org>
Commit-Queue: Steve Anton <steveanton@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#30440}
| -rw-r--r-- | p2p/client/basic_port_allocator_unittest.cc | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/p2p/client/basic_port_allocator_unittest.cc b/p2p/client/basic_port_allocator_unittest.cc index 00551ef190..5393321f79 100644 --- a/p2p/client/basic_port_allocator_unittest.cc +++ b/p2p/client/basic_port_allocator_unittest.cc @@ -1373,10 +1373,6 @@ TEST_F(BasicPortAllocatorTest, TestDisableUdpTurn) { EXPECT_TRUE(HasCandidate(candidates_, "local", "tcp", kClientAddr)); } -// Disable for asan, see -// https://code.google.com/p/webrtc/issues/detail?id=4743 for details. -#if !defined(ADDRESS_SANITIZER) - // Test that we can get OnCandidatesAllocationDone callback when all the ports // are disabled. TEST_F(BasicPortAllocatorTest, TestDisableAllPorts) { @@ -1402,8 +1398,6 @@ TEST_F(BasicPortAllocatorTest, TestGetAllPortsNoUdpSockets) { EXPECT_TRUE(HasCandidate(candidates_, "local", "tcp", kClientAddr)); } -#endif // if !defined(ADDRESS_SANITIZER) - // Test that we don't crash or malfunction if we can't create UDP sockets or // listen on TCP sockets. We still give out a local TCP address, since // apparently this is needed for the remote side to accept our connection. |