diff options
author | Mirko Bonadei <mbonadei@webrtc.org> | 2022-10-12 14:22:09 +0000 |
---|---|---|
committer | WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2022-10-12 14:23:40 +0000 |
commit | c0794c23ffc9714196831d91da91f4208f22757e (patch) | |
tree | c9b12fa9eb6d59b882cd89fb08d45baedc6d2c2f /stats/rtc_stats_report_unittest.cc | |
parent | 2068d0daa78100056dd1e3c1eae7317389079859 (diff) | |
download | webrtc-c0794c23ffc9714196831d91da91f4208f22757e.tar.gz |
Revert "stats: migrate to Timestamp"
This reverts commit 2235776597e2f47ec353ac911428eb9a54d64a10.
Reason for revert: Breaks compile.
RTCStatsReport::Create(timestamp) needs default value.
Original change's description:
> stats: migrate to Timestamp
>
> BUG=webrtc:13756
>
> Change-Id: I04ba57f9c2ca5a974a406814023911b4eb2d6d38
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/273942
> Commit-Queue: Philipp Hancke <phancke@microsoft.com>
> Reviewed-by: Henrik Boström <hbos@webrtc.org>
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#38365}
Bug: webrtc:13756
Change-Id: I7eba2bb510af73be50397bd92f730bc6de1ce676
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/279044
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org>
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38369}
Diffstat (limited to 'stats/rtc_stats_report_unittest.cc')
-rw-r--r-- | stats/rtc_stats_report_unittest.cc | 19 |
1 files changed, 5 insertions, 14 deletions
diff --git a/stats/rtc_stats_report_unittest.cc b/stats/rtc_stats_report_unittest.cc index 8af6dbe620..2081364f66 100644 --- a/stats/rtc_stats_report_unittest.cc +++ b/stats/rtc_stats_report_unittest.cc @@ -53,10 +53,8 @@ class RTCTestStats3 : public RTCStats { WEBRTC_RTCSTATS_IMPL(RTCTestStats3, RTCStats, "test-stats-3", &string) TEST(RTCStatsReport, AddAndGetStats) { - rtc::scoped_refptr<RTCStatsReport> report = - RTCStatsReport::Create(Timestamp::Micros(1337)); + rtc::scoped_refptr<RTCStatsReport> report = RTCStatsReport::Create(1337); EXPECT_EQ(report->timestamp_us(), 1337u); - EXPECT_EQ(report->timestamp().us_or(-1), 1337u); EXPECT_EQ(report->size(), static_cast<size_t>(0)); report->AddStats(std::unique_ptr<RTCStats>(new RTCTestStats1("a0", 1))); report->AddStats(std::unique_ptr<RTCStats>(new RTCTestStats1("a1", 2))); @@ -89,10 +87,8 @@ TEST(RTCStatsReport, AddAndGetStats) { } TEST(RTCStatsReport, StatsOrder) { - rtc::scoped_refptr<RTCStatsReport> report = - RTCStatsReport::Create(Timestamp::Micros(1337)); + rtc::scoped_refptr<RTCStatsReport> report = RTCStatsReport::Create(1337); EXPECT_EQ(report->timestamp_us(), 1337u); - EXPECT_EQ(report->timestamp().us_or(-1), 1337u); report->AddStats(std::unique_ptr<RTCStats>(new RTCTestStats1("C", 2))); report->AddStats(std::unique_ptr<RTCStats>(new RTCTestStats1("D", 3))); report->AddStats(std::unique_ptr<RTCStats>(new RTCTestStats2("B", 1))); @@ -109,8 +105,7 @@ TEST(RTCStatsReport, StatsOrder) { } TEST(RTCStatsReport, Take) { - rtc::scoped_refptr<RTCStatsReport> report = - RTCStatsReport::Create(Timestamp::Zero()); + rtc::scoped_refptr<RTCStatsReport> report = RTCStatsReport::Create(0); report->AddStats(std::unique_ptr<RTCStats>(new RTCTestStats1("A", 1))); report->AddStats(std::unique_ptr<RTCStats>(new RTCTestStats1("B", 2))); EXPECT_TRUE(report->Get("A")); @@ -123,17 +118,13 @@ TEST(RTCStatsReport, Take) { } TEST(RTCStatsReport, TakeMembersFrom) { - rtc::scoped_refptr<RTCStatsReport> a = - RTCStatsReport::Create(Timestamp::Micros(1337)); + rtc::scoped_refptr<RTCStatsReport> a = RTCStatsReport::Create(1337); EXPECT_EQ(a->timestamp_us(), 1337u); - EXPECT_EQ(a->timestamp().us_or(-1), 1337u); a->AddStats(std::unique_ptr<RTCStats>(new RTCTestStats1("B", 1))); a->AddStats(std::unique_ptr<RTCStats>(new RTCTestStats1("C", 2))); a->AddStats(std::unique_ptr<RTCStats>(new RTCTestStats1("E", 4))); - rtc::scoped_refptr<RTCStatsReport> b = - RTCStatsReport::Create(Timestamp::Micros(1338)); + rtc::scoped_refptr<RTCStatsReport> b = RTCStatsReport::Create(1338); EXPECT_EQ(b->timestamp_us(), 1338u); - EXPECT_EQ(b->timestamp().us_or(-1), 1338u); b->AddStats(std::unique_ptr<RTCStats>(new RTCTestStats1("A", 0))); b->AddStats(std::unique_ptr<RTCStats>(new RTCTestStats1("D", 3))); b->AddStats(std::unique_ptr<RTCStats>(new RTCTestStats1("F", 5))); |