diff options
Diffstat (limited to 'webrtc/common_video/libyuv')
-rw-r--r-- | webrtc/common_video/libyuv/include/scaler.h | 2 | ||||
-rw-r--r-- | webrtc/common_video/libyuv/include/webrtc_libyuv.h | 3 | ||||
-rw-r--r-- | webrtc/common_video/libyuv/libyuv_unittest.cc | 34 | ||||
-rw-r--r-- | webrtc/common_video/libyuv/scaler_unittest.cc | 26 | ||||
-rw-r--r-- | webrtc/common_video/libyuv/webrtc_libyuv.cc | 12 |
5 files changed, 46 insertions, 31 deletions
diff --git a/webrtc/common_video/libyuv/include/scaler.h b/webrtc/common_video/libyuv/include/scaler.h index c04d01f33b..2b92f8148b 100644 --- a/webrtc/common_video/libyuv/include/scaler.h +++ b/webrtc/common_video/libyuv/include/scaler.h @@ -15,7 +15,7 @@ #ifndef WEBRTC_COMMON_VIDEO_LIBYUV_INCLUDE_SCALER_H_ #define WEBRTC_COMMON_VIDEO_LIBYUV_INCLUDE_SCALER_H_ -#include "webrtc/common_video/interface/i420_buffer_pool.h" +#include "webrtc/common_video/include/i420_buffer_pool.h" #include "webrtc/common_video/libyuv/include/webrtc_libyuv.h" #include "webrtc/typedefs.h" #include "webrtc/video_frame.h" diff --git a/webrtc/common_video/libyuv/include/webrtc_libyuv.h b/webrtc/common_video/libyuv/include/webrtc_libyuv.h index baf8c171ad..d66736fb24 100644 --- a/webrtc/common_video/libyuv/include/webrtc_libyuv.h +++ b/webrtc/common_video/libyuv/include/webrtc_libyuv.h @@ -152,6 +152,7 @@ int ConvertNV12ToRGB565(const uint8_t* src_frame, double I420PSNR(const VideoFrame* ref_frame, const VideoFrame* test_frame); // Compute SSIM for an I420 frame (all planes). double I420SSIM(const VideoFrame* ref_frame, const VideoFrame* test_frame); -} + +} // namespace webrtc #endif // WEBRTC_COMMON_VIDEO_LIBYUV_INCLUDE_WEBRTC_LIBYUV_H_ diff --git a/webrtc/common_video/libyuv/libyuv_unittest.cc b/webrtc/common_video/libyuv/libyuv_unittest.cc index b674b51b67..e7cf0759f6 100644 --- a/webrtc/common_video/libyuv/libyuv_unittest.cc +++ b/webrtc/common_video/libyuv/libyuv_unittest.cc @@ -97,7 +97,7 @@ TestLibYuv::TestLibYuv() width_(352), height_(288), size_y_(width_ * height_), - size_uv_(((width_ + 1 ) / 2) * ((height_ + 1) / 2)), + size_uv_(((width_ + 1) / 2) * ((height_ + 1) / 2)), frame_length_(CalcBufferSize(kI420, 352, 288)) { orig_buffer_.reset(new uint8_t[frame_length_]); } @@ -142,9 +142,9 @@ TEST_F(TestLibYuv, ConvertTest) { double psnr = 0.0; VideoFrame res_i420_frame; - EXPECT_EQ(0,res_i420_frame.CreateEmptyFrame(width_, height_, width_, - (width_ + 1) / 2, - (width_ + 1) / 2)); + EXPECT_EQ(0, res_i420_frame.CreateEmptyFrame(width_, height_, width_, + (width_ + 1) / 2, + (width_ + 1) / 2)); printf("\nConvert #%d I420 <-> I420 \n", j); rtc::scoped_ptr<uint8_t[]> out_i420_buffer(new uint8_t[frame_length_]); EXPECT_EQ(0, ConvertFromI420(orig_frame_, kI420, 0, @@ -281,8 +281,8 @@ TEST_F(TestLibYuv, ConvertAlignedFrame) { int stride_y = 0; int stride_uv = 0; Calc16ByteAlignedStride(width_, &stride_y, &stride_uv); - EXPECT_EQ(0,res_i420_frame.CreateEmptyFrame(width_, height_, - stride_y, stride_uv, stride_uv)); + EXPECT_EQ(0, res_i420_frame.CreateEmptyFrame(width_, height_, + stride_y, stride_uv, stride_uv)); rtc::scoped_ptr<uint8_t[]> out_i420_buffer(new uint8_t[frame_length_]); EXPECT_EQ(0, ConvertFromI420(orig_frame_, kI420, 0, out_i420_buffer.get())); @@ -303,27 +303,27 @@ TEST_F(TestLibYuv, RotateTest) { VideoFrame rotated_res_i420_frame; int rotated_width = height_; int rotated_height = width_; - int stride_y ; + int stride_y; int stride_uv; Calc16ByteAlignedStride(rotated_width, &stride_y, &stride_uv); - EXPECT_EQ(0,rotated_res_i420_frame.CreateEmptyFrame(rotated_width, - rotated_height, - stride_y, - stride_uv, - stride_uv)); + EXPECT_EQ(0, rotated_res_i420_frame.CreateEmptyFrame(rotated_width, + rotated_height, + stride_y, + stride_uv, + stride_uv)); EXPECT_EQ(0, ConvertToI420(kI420, orig_buffer_.get(), 0, 0, width_, height_, 0, kVideoRotation_90, &rotated_res_i420_frame)); EXPECT_EQ(0, ConvertToI420(kI420, orig_buffer_.get(), 0, 0, width_, height_, 0, kVideoRotation_270, &rotated_res_i420_frame)); - EXPECT_EQ(0,rotated_res_i420_frame.CreateEmptyFrame(width_, height_, - width_, (width_ + 1) / 2, - (width_ + 1) / 2)); + EXPECT_EQ(0, rotated_res_i420_frame.CreateEmptyFrame(width_, height_, + width_, (width_ + 1) / 2, + (width_ + 1) / 2)); EXPECT_EQ(0, ConvertToI420(kI420, orig_buffer_.get(), 0, 0, width_, height_, 0, kVideoRotation_180, &rotated_res_i420_frame)); } TEST_F(TestLibYuv, alignment) { - int value = 0x3FF; // 1023 + int value = 0x3FF; // 1023 EXPECT_EQ(0x400, AlignInt(value, 128)); // Low 7 bits are zero. EXPECT_EQ(0x400, AlignInt(value, 64)); // Low 6 bits are zero. EXPECT_EQ(0x400, AlignInt(value, 32)); // Low 5 bits are zero. @@ -346,4 +346,4 @@ TEST_F(TestLibYuv, StrideAlignment) { EXPECT_EQ(64, stride_uv); } -} // namespace +} // namespace webrtc diff --git a/webrtc/common_video/libyuv/scaler_unittest.cc b/webrtc/common_video/libyuv/scaler_unittest.cc index 568311bc2e..6d026383a2 100644 --- a/webrtc/common_video/libyuv/scaler_unittest.cc +++ b/webrtc/common_video/libyuv/scaler_unittest.cc @@ -15,7 +15,6 @@ #include "webrtc/common_video/libyuv/include/scaler.h" #include "webrtc/system_wrappers/include/tick_util.h" #include "webrtc/test/testsupport/fileutils.h" -#include "webrtc/test/testsupport/gtest_disable.h" namespace webrtc { @@ -114,8 +113,13 @@ TEST_F(TestScaler, ScaleSendingBufferTooSmall) { EXPECT_EQ(half_height_, test_frame2.height()); } -//TODO (mikhal): Converge the test into one function that accepts the method. -TEST_F(TestScaler, DISABLED_ON_ANDROID(PointScaleTest)) { +// TODO(mikhal): Converge the test into one function that accepts the method. +#if defined(WEBRTC_ANDROID) +#define MAYBE_PointScaleTest DISABLED_PointScaleTest +#else +#define MAYBE_PointScaleTest PointScaleTest +#endif +TEST_F(TestScaler, MAYBE_PointScaleTest) { double avg_psnr; FILE* source_file2; ScaleMethod method = kScalePoint; @@ -182,7 +186,12 @@ TEST_F(TestScaler, DISABLED_ON_ANDROID(PointScaleTest)) { ASSERT_EQ(0, fclose(source_file2)); } -TEST_F(TestScaler, DISABLED_ON_ANDROID(BiLinearScaleTest)) { +#if defined(WEBRTC_ANDROID) +#define MAYBE_BilinearScaleTest DISABLED_BiLinearScaleTest +#else +#define MAYBE_BilinearScaleTest BiLinearScaleTest +#endif +TEST_F(TestScaler, MAYBE_BiLinearScaleTest) { double avg_psnr; FILE* source_file2; ScaleMethod method = kScaleBilinear; @@ -234,7 +243,12 @@ TEST_F(TestScaler, DISABLED_ON_ANDROID(BiLinearScaleTest)) { 400, 300); } -TEST_F(TestScaler, DISABLED_ON_ANDROID(BoxScaleTest)) { +#if defined(WEBRTC_ANDROID) +#define MAYBE_BoxScaleTest DISABLED_BoxScaleTest +#else +#define MAYBE_BoxScaleTest BoxScaleTest +#endif +TEST_F(TestScaler, MAYBE_BoxScaleTest) { double avg_psnr; FILE* source_file2; ScaleMethod method = kScaleBox; @@ -322,7 +336,7 @@ double TestScaler::ComputeAvgSequencePSNR(FILE* input_file, return avg_psnr; } -// TODO (mikhal): Move part to a separate scale test. +// TODO(mikhal): Move part to a separate scale test. void TestScaler::ScaleSequence(ScaleMethod method, FILE* source_file, std::string out_name, int src_width, int src_height, diff --git a/webrtc/common_video/libyuv/webrtc_libyuv.cc b/webrtc/common_video/libyuv/webrtc_libyuv.cc index bf95624769..48f5c2036b 100644 --- a/webrtc/common_video/libyuv/webrtc_libyuv.cc +++ b/webrtc/common_video/libyuv/webrtc_libyuv.cc @@ -58,7 +58,7 @@ VideoType RawVideoTypeToCommonVideoVideoType(RawVideoType type) { int AlignInt(int value, int alignment) { assert(!((alignment - 1) & alignment)); - return ((value + alignment - 1) & ~ (alignment - 1)); + return ((value + alignment - 1) & ~(alignment - 1)); } void Calc16ByteAlignedStride(int width, int* stride_y, int* stride_uv) { @@ -119,8 +119,8 @@ int PrintVideoFrame(const VideoFrame& frame, FILE* file) { } plane_buffer += frame.stride(plane_type); } - } - return 0; + } + return 0; } int ExtractBuffer(const VideoFrame& input_frame, size_t size, uint8_t* buffer) { @@ -176,7 +176,7 @@ int ConvertRGB24ToARGB(const uint8_t* src_frame, uint8_t* dst_frame, } libyuv::RotationMode ConvertRotationMode(VideoRotation rotation) { - switch(rotation) { + switch (rotation) { case kVideoRotation_0: return libyuv::kRotate0; case kVideoRotation_90: @@ -191,7 +191,7 @@ libyuv::RotationMode ConvertRotationMode(VideoRotation rotation) { } int ConvertVideoType(VideoType video_type) { - switch(video_type) { + switch (video_type) { case kUnknown: return libyuv::FOURCC_ANY; case kI420: @@ -243,7 +243,7 @@ int ConvertToI420(VideoType src_video_type, // Stride values should correspond to the destination values. if (rotation == kVideoRotation_90 || rotation == kVideoRotation_270) { dst_width = dst_frame->height(); - dst_height =dst_frame->width(); + dst_height = dst_frame->width(); } return libyuv::ConvertToI420(src_frame, sample_size, dst_frame->buffer(kYPlane), |