diff options
| author | David Bertoni <dbertoni@chromium.org> | 2024-04-03 04:02:06 +0000 |
|---|---|---|
| committer | Copybara-Service <copybara-worker@google.com> | 2024-04-02 21:06:47 -0700 |
| commit | fbd0a40e6287c6b929a2fd82c2976fab3e3082c8 (patch) | |
| tree | 4fdfe5ae218d0e8bf1ab0c7152d87403854ce2af | |
| parent | 30bf3a72e77abb71568fa1e6258a0a731fef9ba3 (diff) | |
| download | zlib-fbd0a40e6287c6b929a2fd82c2976fab3e3082c8.tar.gz | |
[Code Health] Remove some uses of base::SupportsWeakPtr.
Bug: 40485134
Change-Id: I9ecd4b143546a0b963ae30237596d8f5ad9e240d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5367392
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Reviewed-by: Adenilson Cavalcanti <cavalcantii@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Eric Orth <ericorth@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1281649}
NOKEYCHECK=True
GitOrigin-RevId: ffc122c1b0d9592cf386ba130de73987b82f7dee
| -rw-r--r-- | google/zip_reader_unittest.cc | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/google/zip_reader_unittest.cc b/google/zip_reader_unittest.cc index e6f89d7..9eb7d7d 100644 --- a/google/zip_reader_unittest.cc +++ b/google/zip_reader_unittest.cc @@ -72,7 +72,7 @@ class FileWrapper { // A mock that provides methods that can be used as callbacks in asynchronous // unzip functions. Tracks the number of calls and number of bytes reported. // Assumes that progress callbacks will be executed in-order. -class MockUnzipListener : public base::SupportsWeakPtr<MockUnzipListener> { +class MockUnzipListener final { public: MockUnzipListener() : success_calls_(0), @@ -98,12 +98,18 @@ class MockUnzipListener : public base::SupportsWeakPtr<MockUnzipListener> { int progress_calls() { return progress_calls_; } int current_progress() { return current_progress_; } + base::WeakPtr<MockUnzipListener> AsWeakPtr() { + return weak_ptr_factory_.GetWeakPtr(); + } + private: int success_calls_; int failure_calls_; int progress_calls_; int64_t current_progress_; + + base::WeakPtrFactory<MockUnzipListener> weak_ptr_factory_{this}; }; class MockWriterDelegate : public zip::WriterDelegate { |