diff options
| author | Samuel Huang <huangs@chromium.org> | 2018-11-08 21:53:27 +0000 |
|---|---|---|
| committer | Copybara-Service <copybara-worker@google.com> | 2021-07-25 20:41:11 -0700 |
| commit | fb345573ac09d9e282569d01fceadda5bb570bc4 (patch) | |
| tree | 61f801918b5b63808db11af5a9cb3d2702129bd9 /disassembler_elf.h | |
| parent | d60fe380fbf410ad935b1a7c0005e76823095b6e (diff) | |
| download | zucchini-fb345573ac09d9e282569d01fceadda5bb570bc4.tar.gz | |
[Zucchini] Cleanup before adding ARM support.
Update includes and comments, and remove some unused code.
In particular, remove TODO comments for figuring out whether ARM
abs32 references can be 4 bytes long: Turns out ARM absolute
references are 8 bytes long. It's rel32 refereneces that can be
4 bytes long.
Change-Id: I02dc905885f6cb5ff929efe0fb1f9a6593ee05a8
Reviewed-on: https://chromium-review.googlesource.com/c/1327559
Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606612}
NOKEYCHECK=True
GitOrigin-RevId: 9076fc4939ced233b85e5f8942ba947b6143aba3
Diffstat (limited to 'disassembler_elf.h')
| -rw-r--r-- | disassembler_elf.h | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/disassembler_elf.h b/disassembler_elf.h index d8012db..866c3b6 100644 --- a/disassembler_elf.h +++ b/disassembler_elf.h @@ -67,8 +67,6 @@ struct Elf64IntelTraits : public Elf64Traits { template <class Traits> class DisassemblerElf : public Disassembler { public: - using HeaderVector = std::vector<const typename Traits::Elf_Shdr*>; - // Applies quick checks to determine whether |image| *may* point to the start // of an executable. Returns true iff the check passes. static bool QuickDetect(ConstBufferView image); @@ -110,9 +108,8 @@ class DisassemblerElf : public Disassembler { // Processes rel32 data after they are extracted from executable sections. virtual void PostProcessRel32() = 0; - // The parsing routines below return true on success, and false on failure. - // Parses ELF header and section headers, and performs basic validation. + // Returns whether parsing was successful. bool ParseHeader(); // Extracts and stores section headers that we need. |