aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndroid Build Coastguard Worker <android-build-coastguard-worker@google.com>2023-07-07 05:08:57 +0000
committerAndroid Build Coastguard Worker <android-build-coastguard-worker@google.com>2023-07-07 05:08:57 +0000
commitcb584635fa3d09dcb8761f96eb88e17ae1b97897 (patch)
treea85f0aebda6323f25951bba64272fccba9821150
parent115be6b21cbce1a9963674c7b9e935bad264d6df (diff)
parent8e9a212552c9096cfeccaacd65dea1d1bca88107 (diff)
downloadslang-android14-mainline-os-statsd-release.tar.gz
Change-Id: Ibb41ec1af85732545509b92e829953c5aa0bd342
-rw-r--r--OWNERS5
-rw-r--r--slang_rs_export_type.cpp6
2 files changed, 7 insertions, 4 deletions
diff --git a/OWNERS b/OWNERS
index 5e4e8cd..1f31354 100644
--- a/OWNERS
+++ b/OWNERS
@@ -1,5 +1,2 @@
-butlermichael@google.com
-dgross@google.com
-jeanluc@google.com
-miaowang@google.com
+include platform/frameworks/rs:/RS_OWNERS # Bug component: 43047
srhines@google.com
diff --git a/slang_rs_export_type.cpp b/slang_rs_export_type.cpp
index afeb6c5..ffe8ffc 100644
--- a/slang_rs_export_type.cpp
+++ b/slang_rs_export_type.cpp
@@ -333,6 +333,8 @@ static const clang::Type *TypeExportableHelper(
//
// TODO(zonr/srhines): allow bit fields of size 8, 16, 32
if (FD->isBitField()) {
+ // Context can be null from NormalizeType?
+ slangAssert(Context);
Context->ReportError(
FD->getLocation(),
"bit fields are not able to be exported: '%0.%1'")
@@ -415,6 +417,8 @@ static const clang::Type *TypeExportableHelper(
case clang::Type::Enum: {
// FIXME: We currently convert enums to integers, rather than reflecting
// a more complete (and nicer type-safe Java version).
+ // Context can be null from NormalizeType?
+ slangAssert(Context);
return Context->getASTContext().IntTy.getTypePtr();
}
default: {
@@ -797,6 +801,8 @@ llvm::StringRef RSExportType::GetTypeName(const clang::Type* T) {
const clang::PointerType *P = static_cast<const clang::PointerType*>(CTI);
const clang::Type *PT = GetPointeeType(P);
llvm::StringRef PointeeName;
+ // Passing nullptr as Context to NormalizeType can cause TypeExportableHelper
+ // to dereference a null Context?
if (NormalizeType(PT, PointeeName, nullptr, nullptr,
NotLegacyKernelArgument)) {
char *Name = new char[ 1 /* * */ + PointeeName.size() + 1 ];