diff options
| author | Emilian Peev <epeev@google.com> | 2023-05-19 11:38:10 -0700 |
|---|---|---|
| committer | Emilian Peev <epeev@google.com> | 2023-05-19 12:21:39 -0700 |
| commit | 3ebfd207b719b8bb697b0ad782e09637a686cb30 (patch) | |
| tree | f9aed7f809025f08a531d29efadb7c2b8dc45c80 /camera2 | |
| parent | 08ac80a2e75af30261813505ac2ab4e0e92aedaa (diff) | |
| download | ex-3ebfd207b719b8bb697b0ad782e09637a686cb30.tar.gz | |
CameraExtensions: Align 'onNextImageAvailable' doc with implementation
The current 'onNextImageAvailable' implementation expects extensions to
decrement the incoming image reference reference count when they are no longer
needed.
Bug: 283038375
Test: Camera CTS
Change-Id: I4fe48cd1f1f05cf60a870b3603b491819b646a88
Diffstat (limited to 'camera2')
3 files changed, 3 insertions, 6 deletions
diff --git a/camera2/extensions/advancedSample/src/java/androidx/camera/extensions/impl/advanced/ImageProcessorImpl.java b/camera2/extensions/advancedSample/src/java/androidx/camera/extensions/impl/advanced/ImageProcessorImpl.java index ce17c4f7..037e9479 100644 --- a/camera2/extensions/advancedSample/src/java/androidx/camera/extensions/impl/advanced/ImageProcessorImpl.java +++ b/camera2/extensions/advancedSample/src/java/androidx/camera/extensions/impl/advanced/ImageProcessorImpl.java @@ -26,8 +26,7 @@ import android.annotation.SuppressLint; @SuppressLint("UnknownNullness") public interface ImageProcessorImpl { /** - * The reference count will be decremented when this method returns. If an extension wants - * to hold onto the image it should increment the reference count in this method and + * The reference count will not be decremented when this method returns. Extensions must * decrement it when the image is no longer needed. * * <p>If OEM is not closing(decrement) the image fast enough, the imageReference passed diff --git a/camera2/extensions/service_based_sample/oem_library/src/java/androidx/camera/extensions/impl/advanced/ImageProcessorImpl.java b/camera2/extensions/service_based_sample/oem_library/src/java/androidx/camera/extensions/impl/advanced/ImageProcessorImpl.java index ce17c4f7..037e9479 100644 --- a/camera2/extensions/service_based_sample/oem_library/src/java/androidx/camera/extensions/impl/advanced/ImageProcessorImpl.java +++ b/camera2/extensions/service_based_sample/oem_library/src/java/androidx/camera/extensions/impl/advanced/ImageProcessorImpl.java @@ -26,8 +26,7 @@ import android.annotation.SuppressLint; @SuppressLint("UnknownNullness") public interface ImageProcessorImpl { /** - * The reference count will be decremented when this method returns. If an extension wants - * to hold onto the image it should increment the reference count in this method and + * The reference count will not be decremented when this method returns. Extensions must * decrement it when the image is no longer needed. * * <p>If OEM is not closing(decrement) the image fast enough, the imageReference passed diff --git a/camera2/extensions/stub/src/main/java/androidx/camera/extensions/impl/advanced/ImageProcessorImpl.java b/camera2/extensions/stub/src/main/java/androidx/camera/extensions/impl/advanced/ImageProcessorImpl.java index ce17c4f7..037e9479 100644 --- a/camera2/extensions/stub/src/main/java/androidx/camera/extensions/impl/advanced/ImageProcessorImpl.java +++ b/camera2/extensions/stub/src/main/java/androidx/camera/extensions/impl/advanced/ImageProcessorImpl.java @@ -26,8 +26,7 @@ import android.annotation.SuppressLint; @SuppressLint("UnknownNullness") public interface ImageProcessorImpl { /** - * The reference count will be decremented when this method returns. If an extension wants - * to hold onto the image it should increment the reference count in this method and + * The reference count will not be decremented when this method returns. Extensions must * decrement it when the image is no longer needed. * * <p>If OEM is not closing(decrement) the image fast enough, the imageReference passed |