aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorManikanta Tadikonda <mtadikonda@google.com>2023-08-14 18:22:26 +0000
committerManikanta Tadikonda <mtadikonda@google.com>2023-08-14 23:20:22 +0000
commit6b8fb66e8910285fb55067c7e1cc6f38b7fcc59d (patch)
tree9847ffa05a35d61383c1c99d6ad56d54bd2e3883
parentca8e83ebd5116474e683e6554cf5b29200e40fe0 (diff)
downloadservice_entitlement-6b8fb66e8910285fb55067c7e1cc6f38b7fcc59d.tar.gz
Add CanIgnoreReturnValue in OdsaResponse builder and suppress AndroidJdkLibsChecker warnings.
Test: atest Ts43OperationTest Change-Id: I01c95c01114720860a75c57de876e71649bd258e
-rw-r--r--java/com/android/libraries/entitlement/Ts43Operation.java2
-rw-r--r--java/com/android/libraries/entitlement/odsa/OdsaResponse.java5
2 files changed, 7 insertions, 0 deletions
diff --git a/java/com/android/libraries/entitlement/Ts43Operation.java b/java/com/android/libraries/entitlement/Ts43Operation.java
index 4221514..e603e86 100644
--- a/java/com/android/libraries/entitlement/Ts43Operation.java
+++ b/java/com/android/libraries/entitlement/Ts43Operation.java
@@ -767,6 +767,7 @@ public class Ts43Operation {
* {@link ServiceEntitlementException#getHttpStatus()}
*/
@NonNull
+ @SuppressWarnings("AndroidJdkLibsChecker") // java.time.Instant
public AcquireTemporaryTokenResponse acquireTemporaryToken(
@NonNull AcquireTemporaryTokenRequest acquireTemporaryTokenRequest)
throws ServiceEntitlementException {
@@ -933,6 +934,7 @@ public class Ts43Operation {
* @return The download info.
*/
@Nullable
+ @SuppressWarnings("AndroidJdkLibsChecker") // java.util.Base64
private DownloadInfo parseDownloadInfo(
@NonNull ImmutableList<String> characteristics, @NonNull Ts43XmlDoc ts43XmlDoc) {
String activationCode =
diff --git a/java/com/android/libraries/entitlement/odsa/OdsaResponse.java b/java/com/android/libraries/entitlement/odsa/OdsaResponse.java
index 18142c6..f81a64b 100644
--- a/java/com/android/libraries/entitlement/odsa/OdsaResponse.java
+++ b/java/com/android/libraries/entitlement/odsa/OdsaResponse.java
@@ -21,6 +21,8 @@ import androidx.annotation.Nullable;
import com.android.libraries.entitlement.EsimOdsaOperation.OdsaOperationResult;
+import com.google.errorprone.annotations.CanIgnoreReturnValue;
+
import java.net.URL;
/** ODSA general response described in GSMA Service Entitlement Configuration section 6.5.1. */
@@ -52,6 +54,7 @@ public abstract class OdsaResponse {
* @return The builder.
*/
@NonNull
+ @CanIgnoreReturnValue
public abstract Builder setOperationResult(@OdsaOperationResult int operationResult);
/**
@@ -62,6 +65,7 @@ public abstract class OdsaResponse {
* @return The builder.
*/
@NonNull
+ @CanIgnoreReturnValue
public abstract Builder setGeneralErrorUrl(@NonNull URL url);
/**
@@ -74,6 +78,7 @@ public abstract class OdsaResponse {
* @return The builder.
*/
@NonNull
+ @CanIgnoreReturnValue
public abstract Builder setGeneralErrorUserData(@NonNull String userData);
}
}