summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGreg Kaiser <gkaiser@google.com>2020-08-05 09:57:50 -0700
committerSlava Shklyaev <slavash@google.com>2020-11-02 10:06:54 +0000
commit895e1665d46eb542b4f57d922a114fa2aa0b7bb1 (patch)
treeeeb72540d7d18f10d6974f177c70c9a952c7f64e
parent02ccdd4436f849470458ed42114b2c19daabe55c (diff)
downloadml-895e1665d46eb542b4f57d922a114fa2aa0b7bb1.tar.gz
Avoid potential use of uninitialized memory
We assure our pointers that are referenced in the destructor have valid values. Test: TreeHugger Change-Id: I03af3815884c89a50ca3298835aa9ea62be40d02 Merged-In: I03af3815884c89a50ca3298835aa9ea62be40d02 (cherry picked from commit 62799d699b3191b59165556c5754277ec02b8744)
-rw-r--r--nn/driver/sample/SampleDriverFloatXNNPACK.cpp4
1 files changed, 3 insertions, 1 deletions
diff --git a/nn/driver/sample/SampleDriverFloatXNNPACK.cpp b/nn/driver/sample/SampleDriverFloatXNNPACK.cpp
index a09e9140d..3a8c0a2df 100644
--- a/nn/driver/sample/SampleDriverFloatXNNPACK.cpp
+++ b/nn/driver/sample/SampleDriverFloatXNNPACK.cpp
@@ -1552,7 +1552,9 @@ class SamplePreparedModelXNNPACK : public SamplePreparedModel {
public:
SamplePreparedModelXNNPACK(const Model& model, const SampleDriver* driver,
ExecutionPreference preference, uid_t userId, Priority priority)
- : SamplePreparedModel(model, driver, preference, userId, priority) {}
+ : SamplePreparedModel(model, driver, preference, userId, priority),
+ mSubgraph(nullptr),
+ mThreadpool(nullptr) {}
~SamplePreparedModelXNNPACK() {
delete mSubgraph;
pthreadpool_destroy(mThreadpool);