summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPedro Loureiro <pedroql@google.com>2021-02-25 15:31:55 +0000
committerPedro Loureiro <pedroql@google.com>2021-04-12 10:22:44 +0000
commit35433f960997dadd4723e0299669447f4a6b6e61 (patch)
treeea6bee30e256542ad06c28324a3263ea1f7f39e7
parent929cf82a328bae849589f276e111266393d02813 (diff)
downloadsetupwizard-35433f960997dadd4723e0299669447f4a6b6e61.tar.gz
Add lint baseline to address NewApi errors
We are enabling a new lint check where the min sdk != compile sdk. It has produced a lot of errors and adding the baseline file(s) allows us to continue work without introducing more problems. Bug: 150847901 Test: m lint-check Change-Id: I508595cc357d19a90164f9573e4ee1f1f2e3f6d8
-rw-r--r--library/Android.bp6
-rw-r--r--library/lint-baseline-gingerbread-lib.xml37
-rw-r--r--library/lint-baseline-lib.xml15
3 files changed, 58 insertions, 0 deletions
diff --git a/library/Android.bp b/library/Android.bp
index f3dc9b2..eaccc8e 100644
--- a/library/Android.bp
+++ b/library/Android.bp
@@ -22,6 +22,9 @@ license {
android_library {
name: "setup-wizard-lib",
+ lint: {
+ baseline_filename: "lint-baseline-lib.xml",
+ },
libs: ["androidx.annotation_annotation"],
manifest: "main/AndroidManifest.xml",
resource_dirs: [
@@ -43,6 +46,9 @@ android_library {
android_library {
name: "setup-wizard-lib-gingerbread-compat",
+ lint: {
+ baseline_filename: "lint-baseline-gingerbread-lib.xml",
+ },
manifest: "main/AndroidManifest.xml",
resource_dirs: [
"main/res",
diff --git a/library/lint-baseline-gingerbread-lib.xml b/library/lint-baseline-gingerbread-lib.xml
new file mode 100644
index 0000000..3f25063
--- /dev/null
+++ b/library/lint-baseline-gingerbread-lib.xml
@@ -0,0 +1,37 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<issues format="5" by="lint 4.1.0" client="cli" variant="all" version="4.1.0">
+
+ <issue
+ id="NewApi"
+ message="`&lt;vector>` requires API level 21 (current min is 14) or building with Android Gradle plugin 1.4 or higher"
+ errorLine1="&lt;vector xmlns:android=&quot;http://schemas.android.com/apk/res/android&quot;"
+ errorLine2=" ~~~~~~">
+ <location
+ file="frameworks/opt/setupwizard/library/gingerbread/res/drawable/suw_ic_expand_less.xml"
+ line="18"
+ column="2"/>
+ </issue>
+
+ <issue
+ id="NewApi"
+ message="`&lt;vector>` requires API level 21 (current min is 14) or building with Android Gradle plugin 1.4 or higher"
+ errorLine1="&lt;vector xmlns:android=&quot;http://schemas.android.com/apk/res/android&quot;"
+ errorLine2=" ~~~~~~">
+ <location
+ file="frameworks/opt/setupwizard/library/gingerbread/res/drawable/suw_ic_expand_more.xml"
+ line="18"
+ column="2"/>
+ </issue>
+
+ <issue
+ id="NewApi"
+ message="Attribute `paddingStart` referenced here can result in a crash on some specific devices older than API 17 (current min is 14)"
+ errorLine1=" android:paddingStart=&quot;?attr/listPreferredItemPaddingLeft&quot;>"
+ errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
+ <location
+ file="frameworks/opt/setupwizard/library/gingerbread/res/layout/suw_items_expandable_switch.xml"
+ line="38"
+ column="9"/>
+ </issue>
+
+</issues>
diff --git a/library/lint-baseline-lib.xml b/library/lint-baseline-lib.xml
new file mode 100644
index 0000000..13e3085
--- /dev/null
+++ b/library/lint-baseline-lib.xml
@@ -0,0 +1,15 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<issues format="5" by="lint 4.1.0" client="cli" variant="all" version="4.1.0">
+
+ <issue
+ id="NewApi"
+ message="Call requires API level 25 (current min is 23): `android.view.View#setRevealOnFocusHint`"
+ errorLine1=" setRevealOnFocusHint(false);"
+ errorLine2=" ~~~~~~~~~~~~~~~~~~~~">
+ <location
+ file="frameworks/opt/setupwizard/library/platform/src/com/android/setupwizardlib/view/RichTextView.java"
+ line="129"
+ column="5"/>
+ </issue>
+
+</issues>