diff options
Diffstat (limited to 'tests/telephonytests/src/com/android/internal/telephony/TelephonyPermissionsTest.java')
| -rw-r--r-- | tests/telephonytests/src/com/android/internal/telephony/TelephonyPermissionsTest.java | 129 |
1 files changed, 47 insertions, 82 deletions
diff --git a/tests/telephonytests/src/com/android/internal/telephony/TelephonyPermissionsTest.java b/tests/telephonytests/src/com/android/internal/telephony/TelephonyPermissionsTest.java index dbaa29a76d..b545c2b7d1 100644 --- a/tests/telephonytests/src/com/android/internal/telephony/TelephonyPermissionsTest.java +++ b/tests/telephonytests/src/com/android/internal/telephony/TelephonyPermissionsTest.java @@ -36,7 +36,7 @@ import android.os.Build; import android.os.Bundle; import android.os.IBinder; import android.os.ServiceManager; -import android.permission.PermissionManager; +import android.permission.LegacyPermissionManager; import android.provider.DeviceConfig; import android.provider.Settings; import android.telephony.SubscriptionManager; @@ -46,7 +46,7 @@ import android.test.mock.MockContentResolver; import android.test.suitebuilder.annotation.SmallTest; import com.android.internal.util.test.FakeSettingsProvider; -import com.android.server.pm.permission.PermissionManagerService; +import com.android.server.pm.permission.LegacyPermissionManagerService; import org.junit.Before; import org.junit.Test; @@ -88,7 +88,7 @@ public class TelephonyPermissionsTest { @Mock private TelephonyManager mTelephonyManagerMockForSub2; @Mock - private PermissionManagerService mMockPermissionManagerService; + private LegacyPermissionManagerService mMockLegacyPermissionManagerService; private MockContentResolver mMockContentResolver; private FakeSettingsConfigProvider mFakeSettingsConfigProvider; @@ -107,10 +107,10 @@ public class TelephonyPermissionsTest { when(mMockSubscriptionManager.getCompleteActiveSubscriptionIdList()).thenReturn( new int[]{SUB_ID}); - PermissionManager permissionManager = new PermissionManager(mMockContext, null, - mMockPermissionManagerService); - when(mMockContext.getSystemService(Context.PERMISSION_SERVICE)).thenReturn( - permissionManager); + LegacyPermissionManager legacyPermissionManager = new LegacyPermissionManager( + mMockLegacyPermissionManagerService); + when(mMockContext.getSystemService(Context.LEGACY_PERMISSION_SERVICE)).thenReturn( + legacyPermissionManager); // By default, assume we have no permissions or app-ops bits. doThrow(new SecurityException()).when(mMockContext) @@ -233,79 +233,42 @@ public class TelephonyPermissionsTest { } @Test - public void testCheckReadPhoneNumber_defaultSmsApp() throws Exception { - setupMocksForDeviceIdentifiersErrorPath(); - when(mMockAppOps.noteOp(eq(AppOpsManager.OPSTR_WRITE_SMS), eq(UID), eq(PACKAGE), - eq(FEATURE), nullable(String.class))).thenReturn(AppOpsManager.MODE_ALLOWED); - assertTrue(TelephonyPermissions.checkReadPhoneNumber( - mMockContext, SUB_ID, PID, UID, PACKAGE, FEATURE, MSG)); - } - - @Test - public void testCheckReadPhoneNumber_hasPrivilegedPhoneStatePermission() throws Exception { - setupMocksForDeviceIdentifiersErrorPath(); - doNothing().when(mMockContext).enforcePermission( - android.Manifest.permission.READ_PRIVILEGED_PHONE_STATE, PID, UID, MSG); - assertTrue(TelephonyPermissions.checkReadPhoneNumber( - mMockContext, SUB_ID, PID, UID, PACKAGE, FEATURE, MSG)); - } - - @Test - public void testCheckReadPhoneNumber_hasReadSms() throws Exception { - setupMocksForDeviceIdentifiersErrorPath(); - doNothing().when(mMockContext).enforcePermission( - android.Manifest.permission.READ_SMS, PID, UID, MSG); - when(mMockAppOps.noteOp(eq(AppOpsManager.OPSTR_READ_SMS), eq(UID), eq(PACKAGE), eq(FEATURE), - nullable(String.class))).thenReturn(AppOpsManager.MODE_ALLOWED); - assertTrue(TelephonyPermissions.checkReadPhoneNumber( - mMockContext, SUB_ID, PID, UID, PACKAGE, FEATURE, MSG)); + public void testCheckReadPhoneNumber_targetPreRWithReadPhoneStateNoAppop() throws Exception { + // If ap app is targeting SDK version < R then the phone number should be accessible with + // both the READ_PHONE_STATE permission and appop granted; if only the permission is granted + // but the appop is denied then the LegacyPermissionManager should return MODE_IGNORED + // to indicate the check should fail silently (return empty / null data). + when(mMockLegacyPermissionManagerService.checkPhoneNumberAccess(PACKAGE, MSG, FEATURE, + PID, UID)).thenReturn(AppOpsManager.MODE_IGNORED); + assertFalse( + TelephonyPermissions.checkReadPhoneNumber(mMockContext, SUB_ID, PID, UID, PACKAGE, + FEATURE, MSG)); } @Test - public void testCheckReadPhoneNumber_hasReadPhoneNumbers() throws Exception { - setupMocksForDeviceIdentifiersErrorPath(); - doNothing().when(mMockContext).enforcePermission( - android.Manifest.permission.READ_PHONE_NUMBERS, PID, UID, MSG); - when(mMockAppOps.noteOp(eq(AppOpsManager.OPSTR_READ_PHONE_NUMBERS), eq(UID), eq(PACKAGE), - eq(FEATURE), nullable(String.class))).thenReturn(AppOpsManager.MODE_ALLOWED); - assertTrue(TelephonyPermissions.checkReadPhoneNumber( - mMockContext, SUB_ID, PID, UID, PACKAGE, FEATURE, MSG)); + public void testCheckReadPhoneNumber_hasPermissionManagerPhoneNumberAccess() { + // To limit binder transactions the targetSdkVersion, permission, and appop checks are all + // performed by the LegacyPermissionManager; this test verifies when this API returns + // the calling package meets the requirements for phone number access the telephony + // check also returns true. + when(mMockLegacyPermissionManagerService.checkPhoneNumberAccess(PACKAGE, MSG, FEATURE, + PID, UID)).thenReturn(PackageManager.PERMISSION_GRANTED); + assertTrue( + TelephonyPermissions.checkReadPhoneNumber(mMockContext, SUB_ID, PID, UID, PACKAGE, + FEATURE, MSG)); } @Test - public void testCheckReadPhoneNumber_hasReadSmsNoAppop() throws Exception { - // If an app has been granted the READ_SMS permission, but the OPSTR_READ_SMS appop has been - // revoked then instead of immediately returning false the phone number access check should - // check if the caller has the READ_PHONE_NUMBERS permission and appop. - setupMocksForDeviceIdentifiersErrorPath(); - doNothing().when(mMockContext).enforcePermission( - android.Manifest.permission.READ_SMS, PID, UID, MSG); - doNothing().when(mMockContext).enforcePermission( - android.Manifest.permission.READ_PHONE_NUMBERS, PID, UID, MSG); - when(mMockAppOps.noteOp(eq(AppOpsManager.OPSTR_READ_PHONE_NUMBERS), eq(UID), eq(PACKAGE), - eq(FEATURE), nullable(String.class))).thenReturn(AppOpsManager.MODE_ALLOWED); - assertTrue(TelephonyPermissions.checkReadPhoneNumber( - mMockContext, SUB_ID, PID, UID, PACKAGE, FEATURE, MSG)); + public void testCheckReadPhoneNumber_hasCarrierPrivileges() throws Exception { + when(mTelephonyManagerMock.createForSubscriptionId(eq(SUB_ID))).thenReturn( + mTelephonyManagerMockForSub1); + when(mTelephonyManagerMockForSub1.getCarrierPrivilegeStatus(anyInt())).thenReturn( + TelephonyManager.CARRIER_PRIVILEGE_STATUS_HAS_ACCESS); + assertTrue( + TelephonyPermissions.checkReadPhoneNumber(mMockContext, SUB_ID, PID, UID, PACKAGE, + FEATURE, MSG)); } - @Test - public void testCheckReadPhoneNumber_hasReadSmsAndReadPhoneNumbersNoAppops() throws Exception { - // If an app has both the READ_SMS and READ_PHONE_NUMBERS permissions granted but does not - // have the corresponding appops instead of returning false for not having the appop granted - // a SecurityException should be thrown. - setupMocksForDeviceIdentifiersErrorPath(); - doNothing().when(mMockContext).enforcePermission( - android.Manifest.permission.READ_SMS, PID, UID, MSG); - doNothing().when(mMockContext).enforcePermission( - android.Manifest.permission.READ_PHONE_NUMBERS, PID, UID, MSG); - try { - TelephonyPermissions.checkReadPhoneNumber( - mMockContext, SUB_ID, PID, UID, PACKAGE, FEATURE, MSG); - fail("Should have thrown SecurityException"); - } catch (SecurityException e) { - // expected - } - } @Test public void testCheckReadDeviceIdentifiers_noPermissions() throws Exception { @@ -325,8 +288,8 @@ public class TelephonyPermissionsTest { // performed by a SystemAPI in PermissionManager; this test verifies when this API returns // the calling package meets the requirements for device identifier access the telephony // check also returns true. - when(mMockPermissionManagerService.checkDeviceIdentifierAccess(PACKAGE, MSG, FEATURE, PID, - UID)).thenReturn(PackageManager.PERMISSION_GRANTED); + when(mMockLegacyPermissionManagerService.checkDeviceIdentifierAccess(PACKAGE, MSG, FEATURE, + PID, UID)).thenReturn(PackageManager.PERMISSION_GRANTED); assertTrue( TelephonyPermissions.checkCallingOrSelfReadDeviceIdentifiers(mMockContext, SUB_ID, PACKAGE, FEATURE, MSG)); @@ -473,7 +436,7 @@ public class TelephonyPermissionsTest { */ @Test public void - testEnforeceCallingOrSelfReadPrecisePhoneStatePermissionOrCarrierPrivilege_noPermissions() + testEnforceCallingOrSelfReadPrecisePhoneStatePermissionOrCarrierPrivilege_noPermissions() throws Exception { // revoke permission READ_PRIVILEGED_PHONE_STATE when(mMockContext.checkCallingOrSelfPermission( @@ -485,7 +448,7 @@ public class TelephonyPermissionsTest { PackageManager.PERMISSION_DENIED); try { TelephonyPermissions - .enforeceCallingOrSelfReadPrecisePhoneStatePermissionOrCarrierPrivilege( + .enforceCallingOrSelfReadPrecisePhoneStatePermissionOrCarrierPrivilege( mMockContext, SUB_ID, MSG); fail("Should have thrown SecurityException"); } catch (SecurityException se) { @@ -499,7 +462,7 @@ public class TelephonyPermissionsTest { */ @Test public void - testEnforeceCallingOrSelfReadPrecisePhoneStatePermissionOrCarrierPrivilege_withPermissions() + testEnforceCallingOrSelfReadPrecisePhoneStatePermissionOrCarrierPrivilege_withPermissions() throws Exception { // grant READ_PRIVILEGED_PHONE_STATE permission when(mMockContext.checkCallingOrSelfPermission( @@ -507,7 +470,7 @@ public class TelephonyPermissionsTest { PackageManager.PERMISSION_GRANTED); try { TelephonyPermissions - .enforeceCallingOrSelfReadPrecisePhoneStatePermissionOrCarrierPrivilege( + .enforceCallingOrSelfReadPrecisePhoneStatePermissionOrCarrierPrivilege( mMockContext, SUB_ID, MSG); } catch (SecurityException se) { fail(); @@ -524,7 +487,7 @@ public class TelephonyPermissionsTest { PackageManager.PERMISSION_GRANTED); try { TelephonyPermissions - .enforeceCallingOrSelfReadPrecisePhoneStatePermissionOrCarrierPrivilege( + .enforceCallingOrSelfReadPrecisePhoneStatePermissionOrCarrierPrivilege( mMockContext, SUB_ID, MSG); } catch (SecurityException se) { fail(); @@ -536,7 +499,7 @@ public class TelephonyPermissionsTest { */ @Test public void - testEnforeceCallingOrSelfReadPrecisePhoneStatePermissionOrCarrierPrivilege_withPrivileges() + testEnforceCallingOrSelfReadPrecisePhoneStatePermissionOrCarrierPrivilege_withPrivileges() throws Exception { // revoke permission READ_PRIVILEGED_PHONE_STATE when(mMockContext.checkCallingOrSelfPermission( @@ -554,7 +517,7 @@ public class TelephonyPermissionsTest { TelephonyManager.CARRIER_PRIVILEGE_STATUS_HAS_ACCESS); try { TelephonyPermissions - .enforeceCallingOrSelfReadPrecisePhoneStatePermissionOrCarrierPrivilege( + .enforceCallingOrSelfReadPrecisePhoneStatePermissionOrCarrierPrivilege( mMockContext, SUB_ID, MSG); } catch (SecurityException se) { fail("Should NOT throw SecurityException"); @@ -616,7 +579,9 @@ public class TelephonyPermissionsTest { android.Manifest.permission.READ_DEVICE_CONFIG)).thenReturn( PackageManager.PERMISSION_GRANTED); - when(mMockPermissionManagerService.checkDeviceIdentifierAccess(any(), any(), any(), + when(mMockLegacyPermissionManagerService.checkDeviceIdentifierAccess(any(), any(), any(), + anyInt(), anyInt())).thenReturn(PackageManager.PERMISSION_DENIED); + when(mMockLegacyPermissionManagerService.checkPhoneNumberAccess(any(), any(), any(), anyInt(), anyInt())).thenReturn(PackageManager.PERMISSION_DENIED); // TelephonyPermissions queries DeviceConfig to determine if the identifier access |