diff options
| author | Gregory Bean <gbean@codeaurora.org> | 2011-06-07 08:06:45 -0700 |
|---|---|---|
| committer | Stepan Moskovchenko <stepanm@codeaurora.org> | 2014-10-10 15:45:36 -0700 |
| commit | 3bec40774966be210fa7ea47be69f190df804421 (patch) | |
| tree | f0e2bbef5c3d83994545bc527df0850205fcf9a2 /scripts | |
| parent | 6ae4f4ae3216e4425d5dd543c444673e6824445f (diff) | |
| download | qcom-msm-v3.10-3bec40774966be210fa7ea47be69f190df804421.tar.gz | |
checkpatch: close filp_open loophole.
filp_open allows people to get around the ban on sys_open.
Close the loophole.
Change-Id: I6e2be62e848cbc064e07008d0886c0d003c8be4b
Signed-off-by: Gregory Bean <gbean@codeaurora.org>
(cherry picked from commit bb181a18a813a70176f71a0c64aa572fcfbef0f0)
Signed-off-by: Stepan Moskovchenko <stepanm@codeaurora.org>
Diffstat (limited to 'scripts')
| -rwxr-xr-x | scripts/checkpatch.pl | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index b282af47c61..5a14797d392 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -3954,6 +3954,13 @@ sub process { $herecurr); } +# filp_open is a backdoor for sys_open + if ($line =~ /\b(filp_open)\b/) { + ERROR("FILE_OPS", + "$1 is inappropriate in kernel code.\n" . + $herecurr); + } + # read[bwl] & write[bwl] use too many barriers, use the _relaxed variants if ($line =~ /\b((?:read|write)[bwl])\b/) { ERROR("NON_RELAXED_IO", |