summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJörg Wagner <jorwag@google.com>2023-11-01 18:10:01 +0000
committerJörg Wagner <jorwag@google.com>2023-11-01 18:10:01 +0000
commit177effbccc1d77d6c9c222355e1e79edea4ae375 (patch)
tree4a1d2efbbe5a9904ca65262293289475c0ad5a46
parent1881b9602555812f3a1a8170fc8b276fdcfdb5c1 (diff)
downloadgchips-177effbccc1d77d6c9c222355e1e79edea4ae375.tar.gz
Correct the error check on the lockBuffer path
The backend can return -EINVAL or a (positive) gralloc error code. Account for it. Bug: 308432951 Test: New PTS EGLAHBLockTest Change-Id: I992af22eae67926c796d2eff072db108f7406be2
-rw-r--r--gralloc4/src/hidl_common/Mapper.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/gralloc4/src/hidl_common/Mapper.cpp b/gralloc4/src/hidl_common/Mapper.cpp
index 38d5377..e308cfe 100644
--- a/gralloc4/src/hidl_common/Mapper.cpp
+++ b/gralloc4/src/hidl_common/Mapper.cpp
@@ -215,7 +215,7 @@ static Error lockBuffer(buffer_handle_t bufferHandle,
void* data = nullptr;
if (mali_gralloc_lock(bufferHandle, cpuUsage, accessRegion.left, accessRegion.top, accessRegion.width,
- accessRegion.height, &data) < 0)
+ accessRegion.height, &data) != 0)
{
return Error::BAD_VALUE;
}