diff options
author | anil.hiranniah <anil.hiranniah@nxp.com> | 2020-03-20 19:52:36 +0530 |
---|---|---|
committer | George Chang <georgekgchang@google.com> | 2020-03-24 11:21:00 +0000 |
commit | 1c9df71d7bfa4bd839227d83dfeb7a706c611ed0 (patch) | |
tree | d8db3bd5ad0dc3f3d62136befbd474821ffb18c7 | |
parent | cb7dde1668673bae9cf8674713542f5f1c8215c7 (diff) | |
download | secure_element-aml_tz2_305400300.tar.gz |
Fix warnings from static analysis toolsandroid-mainline-12.0.0_r112android-mainline-11.0.0_r44android-mainline-11.0.0_r43android-mainline-11.0.0_r42android-mainline-11.0.0_r41android-mainline-11.0.0_r40android-mainline-11.0.0_r39android-mainline-11.0.0_r38android-mainline-11.0.0_r37android-mainline-11.0.0_r36android-mainline-11.0.0_r35android-mainline-11.0.0_r34android-mainline-11.0.0_r32android-mainline-11.0.0_r31android-mainline-11.0.0_r30android-mainline-11.0.0_r28android-mainline-11.0.0_r27android-mainline-11.0.0_r26android-mainline-11.0.0_r25android-mainline-11.0.0_r24android-mainline-11.0.0_r23android-mainline-11.0.0_r22android-mainline-11.0.0_r21android-mainline-11.0.0_r20android-mainline-11.0.0_r18android-mainline-11.0.0_r17android-mainline-11.0.0_r16android-mainline-11.0.0_r15android-mainline-11.0.0_r14android-mainline-11.0.0_r13android-mainline-11.0.0_r12aml_tz2_305400500aml_tz2_305400300aml_tz2_305400100aml_tz2_304500300aml_tz2_303900110aml_tz2_303900102aml_tz2_303800002aml_tz2_303800001aml_tz2_303200001android12-mainline-tzdata2-releaseandroid11-mainline-tethering-releaseandroid11-mainline-permission-releaseandroid11-mainline-os-statsd-releaseandroid11-mainline-networkstack-releaseandroid11-mainline-media-swcodec-releaseandroid11-mainline-media-releaseandroid11-mainline-extservices-releaseandroid11-mainline-documentsui-releaseandroid11-mainline-conscrypt-releaseandroid11-mainline-cellbroadcast-releaseandroid11-mainline-captiveportallogin-releaseandroid11-devaml_tz2_305400100
1. FORWARD/REVERSE NULL
a. phNxpEsePal_spi.c :phNxpEse_spiIoctl()
Added null check for p_data
Bug: 142626701
Test: VTS
Merged-In: I8932afa39eb93aaf7cbbe2320e1071bf5b450735
Change-Id: I8932afa39eb93aaf7cbbe2320e1071bf5b450735
-rwxr-xr-x | libese-spi/p73/pal/spi/phNxpEsePal_spi.cpp | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/libese-spi/p73/pal/spi/phNxpEsePal_spi.cpp b/libese-spi/p73/pal/spi/phNxpEsePal_spi.cpp index 21057b6..cb2d4c5 100755 --- a/libese-spi/p73/pal/spi/phNxpEsePal_spi.cpp +++ b/libese-spi/p73/pal/spi/phNxpEsePal_spi.cpp @@ -89,6 +89,11 @@ void phPalEse_spi_close(void* pDevHandle) { return; } ESESTATUS phNxpEse_spiIoctl(uint64_t ioctlType, void* p_data) { + if (!p_data) { + ALOGD_IF(ese_debug_enabled, "%s:p_data is null ioctltyp: %ld", __FUNCTION__, + (long)ioctlType); + return ESESTATUS_FAILED; + } ese_nxp_IoctlInOutData_t* inpOutData = (ese_nxp_IoctlInOutData_t*)p_data; rf_status = inpOutData->inp.data.nxpCmd.p_cmd[0]; if (rf_status == 1) { @@ -99,11 +104,6 @@ ESESTATUS phNxpEse_spiIoctl(uint64_t ioctlType, void* p_data) { ese_debug_enabled, "******************RF IS OFF*************************************"); } - if (p_data != NULL) { - ALOGD_IF(ese_debug_enabled, - "halimpl phNxpEse_spiIoctl p_data is not null ioctltyp: %ld", - (long)ioctlType); - } return ESESTATUS_SUCCESS; } |