summaryrefslogtreecommitdiff
path: root/libcamera2
diff options
context:
space:
mode:
authorEino-Ville Talvala <etalvala@google.com>2013-05-16 17:33:06 -0700
committerEino-Ville Talvala <etalvala@google.com>2013-05-16 17:33:06 -0700
commit39ed516364d4f0b2648113cb3f94533e86c2da95 (patch)
tree3da1c15d55e85cf94d75b5a9e345ecd1b499ad53 /libcamera2
parent25bee067b500484f8b0a1976da0ff672a7eb7e9e (diff)
downloadexynos5-39ed516364d4f0b2648113cb3f94533e86c2da95.tar.gz
Camera: Fix green JPEGs
Need crop regions to be 4 entries on the input and the output; otherwise the sanity checks when doing reprocessing will reject the HAL's own output. Bug: 8947463 Change-Id: I0be0ac816cb65c802c3a5ae56af732edf9145edc
Diffstat (limited to 'libcamera2')
-rw-r--r--libcamera2/MetadataConverter.cpp10
1 files changed, 8 insertions, 2 deletions
diff --git a/libcamera2/MetadataConverter.cpp b/libcamera2/MetadataConverter.cpp
index 4ae1e73..386c62a 100644
--- a/libcamera2/MetadataConverter.cpp
+++ b/libcamera2/MetadataConverter.cpp
@@ -621,9 +621,15 @@ status_t MetadataConverter::ToDynamicMetadata(struct camera2_shot_ext * metadata
&metadata->dm.aa.isoValue, 1))
return NO_MEMORY;
-
+ // Need a four-entry crop region
+ uint32_t cropRegion[4] = {
+ metadata->ctl.scaler.cropRegion[0],
+ metadata->ctl.scaler.cropRegion[1],
+ metadata->ctl.scaler.cropRegion[2],
+ 0
+ };
if (0 != add_camera_metadata_entry(dst, ANDROID_SCALER_CROP_REGION,
- &metadata->ctl.scaler.cropRegion, 3))
+ cropRegion, 4))
return NO_MEMORY;
byteData = metadata->dm.aa.aeState - 1;