diff options
| author | Pete Bentley <prb@google.com> | 2020-12-04 09:26:35 +0000 |
|---|---|---|
| committer | Pete Bentley <prb@google.com> | 2020-12-04 09:41:02 +0000 |
| commit | 650e71cc3acbc3f5af2ae312bc5ed71bb2d7c20b (patch) | |
| tree | 45b17cc920472942bcd43ad88a466032027305e5 | |
| parent | 812a76de8dbe4eefaa86cfd05ac5bd3cd79b4e80 (diff) | |
| download | libcore-650e71cc3acbc3f5af2ae312bc5ed71bb2d7c20b.tar.gz | |
Reject non-ASCII hostnames and SANs.
Updates test expectations to match OkHostnameVerifier behaviour changes
in the same topic.
Bug: 171980069
Test: atest CtsLibcoreTestCases CtsLibcoreOkHttpTestCases
Change-Id: I7ccd2c6d4255d29112e9a6d58640316c364bf67a
| -rw-r--r-- | harmony-tests/src/test/java/org/apache/harmony/tests/javax/net/ssl/HostnameVerifierTest.java | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/harmony-tests/src/test/java/org/apache/harmony/tests/javax/net/ssl/HostnameVerifierTest.java b/harmony-tests/src/test/java/org/apache/harmony/tests/javax/net/ssl/HostnameVerifierTest.java index e6978385e09..96384adba24 100644 --- a/harmony-tests/src/test/java/org/apache/harmony/tests/javax/net/ssl/HostnameVerifierTest.java +++ b/harmony-tests/src/test/java/org/apache/harmony/tests/javax/net/ssl/HostnameVerifierTest.java @@ -78,7 +78,7 @@ public class HostnameVerifierTest extends TestCase implements assertFalse(verifier.verify("a.foo.com", session)); assertTrue(verifier.verify("bar.com", session)); assertFalse(verifier.verify("a.bar.com", session)); - // The certificate has this name in the altnames section, but Conscrypt drops + // The certificate has this name in the altnames section, but OkHostnameVerifier drops // any altnames that are improperly encoded according to RFC 5280, which requires // non-ASCII characters to be encoded in ASCII via Punycode. assertFalse(verifier.verify("\u82b1\u5b50.co.jp", session)); @@ -129,11 +129,11 @@ public class HostnameVerifierTest extends TestCase implements assertFalse(verifier.verify("a.b.foo.com", session)); assertFalse(verifier.verify("bar.com", session)); assertTrue(verifier.verify("www.bar.com", session)); - assertTrue(verifier.verify("\u82b1\u5b50.bar.com", session)); assertFalse(verifier.verify("a.b.bar.com", session)); - // The certificate has this name in the altnames section, but Conscrypt drops + // The certificate has this name in the altnames section, but OkHostnameVerifier drops // any altnames that are improperly encoded according to RFC 5280, which requires // non-ASCII characters to be encoded in ASCII via Punycode. + assertFalse(verifier.verify("\u82b1\u5b50.bar.com", session)); assertFalse(verifier.verify("\u82b1\u5b50.co.jp", session)); assertFalse(verifier.verify("a.\u82b1\u5b50.co.jp", session)); } |