diff options
author | Pete Bentley <prb@google.com> | 2024-04-10 11:49:15 +0100 |
---|---|---|
committer | Pete Bentley <prb@google.com> | 2024-04-10 11:49:15 +0100 |
commit | 97076873c2fb5e8cb99e8786a63bb43b4090fd6c (patch) | |
tree | f50d5f3b081c155a36a9d4b74af2d60891f94dcd | |
parent | 7635e2ae5ca102b0db3b9d853d97660eff698a9e (diff) | |
download | libcore-97076873c2fb5e8cb99e8786a63bb43b4090fd6c.tar.gz |
Switch from DNS name to IP literal for IsReachableViaLoopbackTest.
Test was flaking due to DNS lookups so remove that dependency.
Google Public DNS should be long-lived enough for this purpose and
responds to ping requests so is suitable for testing
InetAddress.isReachable().
Bug: 33364197
Test: atest CtsLibcoreOjTestCases:test.java.net.InetAddress.IsReachableViaLoopbackTest
Change-Id: I121bfa16c4c52920cb0e45d46d8a57a48871555d
-rw-r--r-- | ojluni/src/test/java/net/InetAddress/IsReachableViaLoopbackTest.java | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/ojluni/src/test/java/net/InetAddress/IsReachableViaLoopbackTest.java b/ojluni/src/test/java/net/InetAddress/IsReachableViaLoopbackTest.java index 7bcf9b63e91..8607b8bc4b5 100644 --- a/ojluni/src/test/java/net/InetAddress/IsReachableViaLoopbackTest.java +++ b/ojluni/src/test/java/net/InetAddress/IsReachableViaLoopbackTest.java @@ -40,9 +40,10 @@ public class IsReachableViaLoopbackTest { public void testReachableViaLoopback() { try { InetAddress addr = InetAddress.getByName("localhost"); - // Android-changed: use alternative DNS address (b/255943063#comment49). + // Android-changed: use alternative DNS address (b/255943063#comment49) + // and switch to literal address to avoid DNS lookup flakes. // InetAddress remoteAddr = InetAddress.getByName("bugs.openjdk.java.net"); - InetAddress remoteAddr = InetAddress.getByName("www.google.com"); + InetAddress remoteAddr = InetAddress.getByAddress(new byte[]{8, 8, 8, 8}); if (!addr.isReachable(10000)) fail("Localhost should always be reachable"); NetworkInterface inf = NetworkInterface.getByInetAddress(addr); |