diff options
author | Android Build Coastguard Worker <android-build-coastguard-worker@google.com> | 2024-03-26 14:51:57 +0000 |
---|---|---|
committer | Android Build Coastguard Worker <android-build-coastguard-worker@google.com> | 2024-03-26 14:51:57 +0000 |
commit | 20672691a4769e66ce92d2c090f98c53abe66b40 (patch) | |
tree | 58c2084c458e35354694305d4a9b758f712db55b | |
parent | f1ef1f24d6b39092ce2af7b778ff00cdc892f0a8 (diff) | |
parent | fc86026c8ce9c80540e37212b1f1aa0e4f2229ec (diff) | |
download | Settings-android14-d2-s3-release.tar.gz |
Merge cherrypicks of ['googleplex-android-review.googlesource.com/26315861'] into sparse-11569200-L54900030002748301.android-14.0.0_r44android-14.0.0_r43android-14.0.0_r42android-14.0.0_r41android14-d2-s4-releaseandroid14-d2-s3-releaseandroid14-d2-s2-releaseandroid14-d2-release
SPARSE_CHANGE: If97018c2741caef622f0596bbfeaa42ef1788b78
Change-Id: I2432d1b1d88f1e67ffb1a98c1e619699bc5234c9
4 files changed, 23 insertions, 25 deletions
diff --git a/src/com/android/settings/search/SearchFeatureProvider.java b/src/com/android/settings/search/SearchFeatureProvider.java index cd096ec6e16..c2257b47c9e 100644 --- a/src/com/android/settings/search/SearchFeatureProvider.java +++ b/src/com/android/settings/search/SearchFeatureProvider.java @@ -56,7 +56,7 @@ public interface SearchFeatureProvider { * @throws IllegalArgumentException when caller is null * @throws SecurityException when caller is not allowed to launch search result page */ - void verifyLaunchSearchResultPageCaller(Context context, @NonNull ComponentName caller) + void verifyLaunchSearchResultPageCaller(@NonNull Context context, @NonNull String callerPackage) throws SecurityException, IllegalArgumentException; /** diff --git a/src/com/android/settings/search/SearchFeatureProviderImpl.java b/src/com/android/settings/search/SearchFeatureProviderImpl.java index 6f909709058..3a62ddfb67e 100644 --- a/src/com/android/settings/search/SearchFeatureProviderImpl.java +++ b/src/com/android/settings/search/SearchFeatureProviderImpl.java @@ -17,13 +17,14 @@ package com.android.settings.search; -import android.content.ComponentName; import android.content.Context; import android.content.Intent; import android.net.Uri; import android.provider.Settings; import android.text.TextUtils; +import androidx.annotation.NonNull; + import com.android.settingslib.search.SearchIndexableResources; import com.android.settingslib.search.SearchIndexableResourcesMobile; @@ -32,21 +33,18 @@ import com.android.settingslib.search.SearchIndexableResourcesMobile; */ public class SearchFeatureProviderImpl implements SearchFeatureProvider { - private static final String TAG = "SearchFeatureProvider"; - private SearchIndexableResources mSearchIndexableResources; @Override - public void verifyLaunchSearchResultPageCaller(Context context, ComponentName caller) { - if (caller == null) { + public void verifyLaunchSearchResultPageCaller(@NonNull Context context, + @NonNull String callerPackage) { + if (TextUtils.isEmpty(callerPackage)) { throw new IllegalArgumentException("ExternalSettingsTrampoline intents " + "must be called with startActivityForResult"); } - final String packageName = caller.getPackageName(); - final boolean isSettingsPackage = TextUtils.equals(packageName, context.getPackageName()) - || TextUtils.equals(getSettingsIntelligencePkgName(context), packageName); - final boolean isAllowlistedPackage = - isSignatureAllowlisted(context, caller.getPackageName()); + final boolean isSettingsPackage = TextUtils.equals(callerPackage, context.getPackageName()) + || TextUtils.equals(getSettingsIntelligencePkgName(context), callerPackage); + final boolean isAllowlistedPackage = isSignatureAllowlisted(context, callerPackage); if (isSettingsPackage || isAllowlistedPackage) { return; } diff --git a/src/com/android/settings/search/SearchResultTrampoline.java b/src/com/android/settings/search/SearchResultTrampoline.java index 6ba0338bfc9..504e2985742 100644 --- a/src/com/android/settings/search/SearchResultTrampoline.java +++ b/src/com/android/settings/search/SearchResultTrampoline.java @@ -20,7 +20,6 @@ import static com.android.settings.SettingsActivity.EXTRA_SHOW_FRAGMENT_ARGUMENT import static com.android.settings.SettingsActivity.EXTRA_SHOW_FRAGMENT_TAB; import android.app.Activity; -import android.content.ComponentName; import android.content.Intent; import android.net.Uri; import android.os.Bundle; @@ -52,11 +51,11 @@ public class SearchResultTrampoline extends Activity { protected void onCreate(Bundle savedInstanceState) { super.onCreate(savedInstanceState); - final ComponentName callingActivity = getCallingActivity(); + final String callerPackage = getLaunchedFromPackage(); // First make sure caller has privilege to launch a search result page. FeatureFactory.getFactory(this) .getSearchFeatureProvider() - .verifyLaunchSearchResultPageCaller(this, callingActivity); + .verifyLaunchSearchResultPageCaller(this, callerPackage); // Didn't crash, proceed and launch the result as a subsetting. Intent intent = getIntent(); final String highlightMenuKey = intent.getStringExtra( @@ -105,7 +104,7 @@ public class SearchResultTrampoline extends Activity { if (!ActivityEmbeddingUtils.isEmbeddingActivityEnabled(this) || ActivityEmbeddingUtils.isAlreadyEmbedded(this)) { startActivity(intent); - } else if (isSettingsIntelligence(callingActivity)) { + } else if (isSettingsIntelligence(callerPackage)) { if (FeatureFlagUtils.isEnabled(this, FeatureFlags.SETTINGS_SEARCH_ALWAYS_EXPAND)) { startActivity(SettingsActivity.getTrampolineIntent(intent, highlightMenuKey) .setClass(this, DeepLinkHomepageActivityInternal.class) @@ -138,9 +137,9 @@ public class SearchResultTrampoline extends Activity { finish(); } - private boolean isSettingsIntelligence(ComponentName callingActivity) { - return callingActivity != null && TextUtils.equals( - callingActivity.getPackageName(), + private boolean isSettingsIntelligence(String callerPackage) { + return TextUtils.equals( + callerPackage, FeatureFactory.getFactory(this).getSearchFeatureProvider() .getSettingsIntelligencePkgName(this)); } diff --git a/tests/robotests/src/com/android/settings/search/SearchFeatureProviderImplTest.java b/tests/robotests/src/com/android/settings/search/SearchFeatureProviderImplTest.java index 0aa49eb6d68..7a1b2606a92 100644 --- a/tests/robotests/src/com/android/settings/search/SearchFeatureProviderImplTest.java +++ b/tests/robotests/src/com/android/settings/search/SearchFeatureProviderImplTest.java @@ -20,7 +20,6 @@ package com.android.settings.search; import static com.google.common.truth.Truth.assertThat; import android.app.settings.SettingsEnums; -import android.content.ComponentName; import android.content.Intent; import android.content.pm.ActivityInfo; import android.content.pm.ResolveInfo; @@ -136,20 +135,22 @@ public class SearchFeatureProviderImplTest { @Test(expected = SecurityException.class) public void verifyLaunchSearchResultPageCaller_badCaller_shouldCrash() { - final ComponentName cn = new ComponentName("pkg", "class"); - mProvider.verifyLaunchSearchResultPageCaller(mActivity, cn); + final String packageName = "pkg"; + + mProvider.verifyLaunchSearchResultPageCaller(mActivity, packageName); } @Test public void verifyLaunchSearchResultPageCaller_settingsCaller_shouldNotCrash() { - final ComponentName cn = new ComponentName(mActivity.getPackageName(), "class"); - mProvider.verifyLaunchSearchResultPageCaller(mActivity, cn); + final String packageName = mActivity.getPackageName(); + + mProvider.verifyLaunchSearchResultPageCaller(mActivity, packageName); } @Test public void verifyLaunchSearchResultPageCaller_settingsIntelligenceCaller_shouldNotCrash() { final String packageName = mProvider.getSettingsIntelligencePkgName(mActivity); - final ComponentName cn = new ComponentName(packageName, "class"); - mProvider.verifyLaunchSearchResultPageCaller(mActivity, cn); + + mProvider.verifyLaunchSearchResultPageCaller(mActivity, packageName); } } |