diff options
author | Neil Fuller <nfuller@google.com> | 2017-07-25 12:01:03 +0100 |
---|---|---|
committer | Neil Fuller <nfuller@google.com> | 2017-07-25 12:05:40 +0100 |
commit | ded915b9ea8908b1d72426c17003428b82c82d8d (patch) | |
tree | 21c91974cfd2569d6698f065d851555b0ad878d0 | |
parent | 12c0bfbdbc6019d52f55d7f2428ec7b4207a0b1b (diff) | |
download | TimeZoneUpdater-ded915b9ea8908b1d72426c17003428b82c82d8d.tar.gz |
Remove TODO associated with threading
Remove TODO associated with threading.
Nothing during testing suggests that there is
anything more needed.
Bug: 31008728
Test: make
Change-Id: I874f6d3763d28f58138251ce08aed946895883a7
-rw-r--r-- | src/main/com/android/timezone/updater/RulesCheckReceiver.java | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/main/com/android/timezone/updater/RulesCheckReceiver.java b/src/main/com/android/timezone/updater/RulesCheckReceiver.java index b2c30c6..bcb56e2 100644 --- a/src/main/com/android/timezone/updater/RulesCheckReceiver.java +++ b/src/main/com/android/timezone/updater/RulesCheckReceiver.java @@ -69,10 +69,7 @@ import libcore.io.Streams; * server for installation via the * {@link RulesManager#requestInstall(ParcelFileDescriptor, byte[], Callback)}. */ -// TODO(nfuller): Prevent multiple broadcasts being handled at once? // TODO(nfuller): Improve logging -// TODO(nfuller): Make the rules check async? -// TODO(nfuller): Need async generally for SystemService calls from BroadcastReceiver? public class RulesCheckReceiver extends BroadcastReceiver { final static String TAG = "RulesCheckReceiver"; @@ -80,6 +77,9 @@ public class RulesCheckReceiver extends BroadcastReceiver { @Override public void onReceive(Context context, Intent intent) { + // No need to make this synchronized, onReceive() is called on the main thread, there's no + // important object state that could be corrupted and the check token allows for ordering + // issues. if (!RulesUpdaterContract.ACTION_TRIGGER_RULES_UPDATE_CHECK.equals(intent.getAction())) { // Unknown. Do nothing. Log.w(TAG, "Unrecognized intent action received: " + intent |