diff options
author | Android Build Coastguard Worker <android-build-coastguard-worker@google.com> | 2022-02-10 00:42:19 +0000 |
---|---|---|
committer | Android Build Coastguard Worker <android-build-coastguard-worker@google.com> | 2022-02-10 00:42:19 +0000 |
commit | 9607c4a185840493217dfb7c3a49bf922e2db34e (patch) | |
tree | f3918f24b49efd8ee627e0abe4e1d78878491896 | |
parent | ed120bb3c1da5a20cc9e3a8869e8507437ec9b4c (diff) | |
parent | 477b15ca439af71e796dd3ecbff20be10949dec7 (diff) | |
download | Connectivity-android12L-d2-s5-release.tar.gz |
Merge cherrypicks of [16822123] into sc-d2-release.android-12.1.0_r26android-12.1.0_r25android-12.1.0_r24android-12.1.0_r23android-12.1.0_r18android-12.1.0_r17android-12.1.0_r16android-12.1.0_r15android-12.1.0_r14android-12.1.0_r13android-12.1.0_r12android12L-d2-s8-releaseandroid12L-d2-s7-releaseandroid12L-d2-s6-releaseandroid12L-d2-s5-releaseandroid12L-d2-s4-releaseandroid12L-d2-s3-releaseandroid12L-d2-s2-releaseandroid12L-d2-s1-releaseandroid12L-d2-release
Change-Id: I712514013de6408fc74f4f116067d07b0c35be83
27 files changed, 46 insertions, 108 deletions
diff --git a/tests/common/java/android/net/CaptivePortalDataTest.kt b/tests/common/java/android/net/CaptivePortalDataTest.kt index 18a93319b2..f9273802f7 100644 --- a/tests/common/java/android/net/CaptivePortalDataTest.kt +++ b/tests/common/java/android/net/CaptivePortalDataTest.kt @@ -19,7 +19,6 @@ package android.net import android.os.Build import androidx.test.filters.SmallTest import com.android.modules.utils.build.SdkLevel -import com.android.testutils.assertParcelSane import com.android.testutils.assertParcelingIsLossless import com.android.testutils.DevSdkIgnoreRule import com.android.testutils.DevSdkIgnoreRule.IgnoreUpTo @@ -71,9 +70,8 @@ class CaptivePortalDataTest { @Test fun testParcelUnparcel() { - val fieldCount = if (SdkLevel.isAtLeastS()) 10 else 7 - assertParcelSane(data, fieldCount) - assertParcelSane(dataFromPasspoint, fieldCount) + assertParcelingIsLossless(data) + assertParcelingIsLossless(dataFromPasspoint) assertParcelingIsLossless(makeBuilder().setUserPortalUrl(null).build()) assertParcelingIsLossless(makeBuilder().setVenueInfoUrl(null).build()) diff --git a/tests/common/java/android/net/ConnectivityDiagnosticsManagerTest.java b/tests/common/java/android/net/ConnectivityDiagnosticsManagerTest.java index 294ed107e0..03a9a80099 100644 --- a/tests/common/java/android/net/ConnectivityDiagnosticsManagerTest.java +++ b/tests/common/java/android/net/ConnectivityDiagnosticsManagerTest.java @@ -21,7 +21,7 @@ import static android.net.ConnectivityDiagnosticsManager.ConnectivityDiagnostics import static android.net.ConnectivityDiagnosticsManager.ConnectivityReport; import static android.net.ConnectivityDiagnosticsManager.DataStallReport; -import static com.android.testutils.ParcelUtils.assertParcelSane; +import static com.android.testutils.ParcelUtils.assertParcelingIsLossless; import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertFalse; @@ -202,7 +202,7 @@ public class ConnectivityDiagnosticsManagerTest { @Test public void testConnectivityReportParcelUnparcel() { - assertParcelSane(createSampleConnectivityReport(), 5); + assertParcelingIsLossless(createSampleConnectivityReport()); } private DataStallReport createSampleDataStallReport() { @@ -303,7 +303,7 @@ public class ConnectivityDiagnosticsManagerTest { @Test public void testDataStallReportParcelUnparcel() { - assertParcelSane(createSampleDataStallReport(), 6); + assertParcelingIsLossless(createSampleDataStallReport()); } @Test diff --git a/tests/common/java/android/net/DhcpInfoTest.java b/tests/common/java/android/net/DhcpInfoTest.java index ab4726bab5..b42e18356d 100644 --- a/tests/common/java/android/net/DhcpInfoTest.java +++ b/tests/common/java/android/net/DhcpInfoTest.java @@ -17,7 +17,6 @@ package android.net; import static com.android.net.module.util.Inet4AddressUtils.inet4AddressToIntHTL; -import static com.android.testutils.MiscAsserts.assertFieldCountEquals; import static com.android.testutils.ParcelUtils.parcelingRoundTrip; import static org.junit.Assert.assertEquals; @@ -101,7 +100,6 @@ public class DhcpInfoTest { // Cannot use assertParcelSane() here because this requires .equals() to work as // defined, but DhcpInfo has a different legacy behavior that we cannot change. final DhcpInfo dhcpInfo = createDhcpInfoObject(); - assertFieldCountEquals(7, DhcpInfo.class); final DhcpInfo dhcpInfoRoundTrip = parcelingRoundTrip(dhcpInfo); assertTrue(dhcpInfoEquals(null, null)); diff --git a/tests/common/java/android/net/IpPrefixTest.java b/tests/common/java/android/net/IpPrefixTest.java index 50ecb42835..241d61fa56 100644 --- a/tests/common/java/android/net/IpPrefixTest.java +++ b/tests/common/java/android/net/IpPrefixTest.java @@ -17,7 +17,6 @@ package android.net; import static com.android.testutils.MiscAsserts.assertEqualBothWays; -import static com.android.testutils.MiscAsserts.assertFieldCountEquals; import static com.android.testutils.MiscAsserts.assertNotEqualEitherWay; import static com.android.testutils.ParcelUtils.assertParcelingIsLossless; @@ -368,7 +367,5 @@ public class IpPrefixTest { p = new IpPrefix("192.0.2.0/25"); assertParcelingIsLossless(p); assertTrue(p.isIPv4()); - - assertFieldCountEquals(2, IpPrefix.class); } } diff --git a/tests/common/java/android/net/LinkAddressTest.java b/tests/common/java/android/net/LinkAddressTest.java index 2cf3cf9c11..053a90305c 100644 --- a/tests/common/java/android/net/LinkAddressTest.java +++ b/tests/common/java/android/net/LinkAddressTest.java @@ -28,7 +28,6 @@ import static android.system.OsConstants.RT_SCOPE_SITE; import static android.system.OsConstants.RT_SCOPE_UNIVERSE; import static com.android.testutils.MiscAsserts.assertEqualBothWays; -import static com.android.testutils.MiscAsserts.assertFieldCountEquals; import static com.android.testutils.MiscAsserts.assertNotEqualEitherWay; import static com.android.testutils.ParcelUtils.assertParcelingIsLossless; @@ -45,7 +44,6 @@ import androidx.test.filters.SmallTest; import androidx.test.runner.AndroidJUnit4; import com.android.testutils.DevSdkIgnoreRule; -import com.android.testutils.DevSdkIgnoreRule.IgnoreAfter; import com.android.testutils.DevSdkIgnoreRule.IgnoreUpTo; import org.junit.Rule; @@ -352,17 +350,6 @@ public class LinkAddressTest { assertParcelingIsLossless(l); } - @Test @IgnoreAfter(Build.VERSION_CODES.Q) - public void testFieldCount_Q() { - assertFieldCountEquals(4, LinkAddress.class); - } - - @Test @IgnoreUpTo(Build.VERSION_CODES.Q) - public void testFieldCount() { - // Make sure any new field is covered by the above parceling tests when changing this number - assertFieldCountEquals(6, LinkAddress.class); - } - @Test @IgnoreUpTo(Build.VERSION_CODES.Q) public void testDeprecationTime() { try { diff --git a/tests/common/java/android/net/LinkPropertiesTest.java b/tests/common/java/android/net/LinkPropertiesTest.java index 550953d061..23c187e1ad 100644 --- a/tests/common/java/android/net/LinkPropertiesTest.java +++ b/tests/common/java/android/net/LinkPropertiesTest.java @@ -20,7 +20,6 @@ import static android.net.RouteInfo.RTN_THROW; import static android.net.RouteInfo.RTN_UNICAST; import static android.net.RouteInfo.RTN_UNREACHABLE; -import static com.android.testutils.ParcelUtils.assertParcelSane; import static com.android.testutils.ParcelUtils.assertParcelingIsLossless; import static com.android.testutils.ParcelUtils.parcelingRoundTrip; @@ -1006,7 +1005,7 @@ public class LinkPropertiesTest { @Test @IgnoreAfter(Build.VERSION_CODES.Q) public void testLinkPropertiesParcelable_Q() throws Exception { final LinkProperties source = makeLinkPropertiesForParceling(); - assertParcelSane(source, 14 /* fieldCount */); + assertParcelingIsLossless(source); } @Test @IgnoreUpTo(Build.VERSION_CODES.Q) @@ -1017,8 +1016,7 @@ public class LinkPropertiesTest { source.setCaptivePortalApiUrl(CAPPORT_API_URL); source.setCaptivePortalData((CaptivePortalData) getCaptivePortalData()); source.setDhcpServerAddress((Inet4Address) GATEWAY1); - assertParcelSane(new LinkProperties(source, true /* parcelSensitiveFields */), - 18 /* fieldCount */); + assertParcelingIsLossless(new LinkProperties(source, true /* parcelSensitiveFields */)); // Verify that without using a sensitiveFieldsParcelingCopy, sensitive fields are cleared. final LinkProperties sanitized = new LinkProperties(source); diff --git a/tests/common/java/android/net/MatchAllNetworkSpecifierTest.kt b/tests/common/java/android/net/MatchAllNetworkSpecifierTest.kt index a5e44d59fc..4a5eae4062 100644 --- a/tests/common/java/android/net/MatchAllNetworkSpecifierTest.kt +++ b/tests/common/java/android/net/MatchAllNetworkSpecifierTest.kt @@ -23,10 +23,10 @@ import android.os.Build import androidx.test.filters.SmallTest import androidx.test.runner.AndroidJUnit4 -import com.android.testutils.assertParcelSane import com.android.testutils.DevSdkIgnoreRule import com.android.testutils.DevSdkIgnoreRule.IgnoreAfter import com.android.testutils.DevSdkIgnoreRule.IgnoreUpTo +import com.android.testutils.assertParcelingIsLossless import java.lang.IllegalStateException @@ -50,7 +50,7 @@ class MatchAllNetworkSpecifierTest { @Test fun testParcel() { - assertParcelSane(MatchAllNetworkSpecifier(), 0) + assertParcelingIsLossless(MatchAllNetworkSpecifier()) } @Test diff --git a/tests/common/java/android/net/NattKeepalivePacketDataTest.kt b/tests/common/java/android/net/NattKeepalivePacketDataTest.kt index 46f39dd016..ad7a5264c3 100644 --- a/tests/common/java/android/net/NattKeepalivePacketDataTest.kt +++ b/tests/common/java/android/net/NattKeepalivePacketDataTest.kt @@ -23,10 +23,9 @@ import android.os.Build import androidx.test.filters.SmallTest import androidx.test.runner.AndroidJUnit4 import com.android.testutils.assertEqualBothWays -import com.android.testutils.assertFieldCountEquals -import com.android.testutils.assertParcelSane import com.android.testutils.DevSdkIgnoreRule import com.android.testutils.DevSdkIgnoreRule.IgnoreUpTo +import com.android.testutils.assertParcelingIsLossless import com.android.testutils.parcelingRoundTrip import java.net.InetAddress import org.junit.Assert.assertEquals @@ -93,7 +92,7 @@ class NattKeepalivePacketDataTest { @Test @IgnoreUpTo(Build.VERSION_CODES.Q) fun testParcel() { - assertParcelSane(nattKeepalivePacket(), 0) + assertParcelingIsLossless(nattKeepalivePacket()) } @Test @IgnoreUpTo(Build.VERSION_CODES.Q) @@ -103,8 +102,6 @@ class NattKeepalivePacketDataTest { assertNotEquals(nattKeepalivePacket(srcAddress = TEST_DST_ADDRV4), nattKeepalivePacket()) // Test src port only because dst port have to be NATT_PORT assertNotEquals(nattKeepalivePacket(srcPort = TEST_PORT2), nattKeepalivePacket()) - // Make sure the parceling test is updated if fields are added in the base class. - assertFieldCountEquals(5, KeepalivePacketData::class.java) } @Test @IgnoreUpTo(Build.VERSION_CODES.Q) diff --git a/tests/common/java/android/net/NetworkAgentConfigTest.kt b/tests/common/java/android/net/NetworkAgentConfigTest.kt index afaae1cf85..63c0a09521 100644 --- a/tests/common/java/android/net/NetworkAgentConfigTest.kt +++ b/tests/common/java/android/net/NetworkAgentConfigTest.kt @@ -22,7 +22,7 @@ import androidx.test.runner.AndroidJUnit4 import com.android.modules.utils.build.SdkLevel.isAtLeastS import com.android.testutils.DevSdkIgnoreRule import com.android.testutils.DevSdkIgnoreRule.IgnoreUpTo -import com.android.testutils.assertParcelSane +import com.android.testutils.assertParcelingIsLossless import org.junit.Assert.assertEquals import org.junit.Assert.assertFalse import org.junit.Assert.assertTrue @@ -48,13 +48,7 @@ class NetworkAgentConfigTest { setBypassableVpn(true) } }.build() - if (isAtLeastS()) { - // From S, the config will have 12 items - assertParcelSane(config, 12) - } else { - // For R or below, the config will have 10 items - assertParcelSane(config, 10) - } + assertParcelingIsLossless(config) } @Test @IgnoreUpTo(Build.VERSION_CODES.Q) diff --git a/tests/common/java/android/net/NetworkCapabilitiesTest.java b/tests/common/java/android/net/NetworkCapabilitiesTest.java index 9537786055..39a3941379 100644 --- a/tests/common/java/android/net/NetworkCapabilitiesTest.java +++ b/tests/common/java/android/net/NetworkCapabilitiesTest.java @@ -52,7 +52,6 @@ import static com.android.modules.utils.build.SdkLevel.isAtLeastS; import static com.android.net.module.util.NetworkCapabilitiesUtils.TRANSPORT_USB; import static com.android.testutils.MiscAsserts.assertEmpty; import static com.android.testutils.MiscAsserts.assertThrows; -import static com.android.testutils.ParcelUtils.assertParcelSane; import static com.android.testutils.ParcelUtils.assertParcelingIsLossless; import static org.junit.Assert.assertArrayEquals; @@ -341,13 +340,7 @@ public class NetworkCapabilitiesTest { } private void testParcelSane(NetworkCapabilities cap) { - if (isAtLeastS()) { - assertParcelSane(cap, 16); - } else if (isAtLeastR()) { - assertParcelSane(cap, 15); - } else { - assertParcelSane(cap, 11); - } + assertParcelingIsLossless(cap); } private static NetworkCapabilities createNetworkCapabilitiesWithTransportInfo() { diff --git a/tests/common/java/android/net/NetworkStateSnapshotTest.kt b/tests/common/java/android/net/NetworkStateSnapshotTest.kt index 0ca4d9551f..99f99c9c78 100644 --- a/tests/common/java/android/net/NetworkStateSnapshotTest.kt +++ b/tests/common/java/android/net/NetworkStateSnapshotTest.kt @@ -24,7 +24,7 @@ import android.os.Build import androidx.test.filters.SmallTest import com.android.testutils.DevSdkIgnoreRule import com.android.testutils.DevSdkIgnoreRunner -import com.android.testutils.assertParcelSane +import com.android.testutils.assertParcelingIsLossless import org.junit.Test import org.junit.runner.RunWith import java.net.Inet4Address @@ -67,7 +67,7 @@ class NetworkStateSnapshotTest { LinkProperties(), null, TYPE_NONE) val snapshot = NetworkStateSnapshot( Network(TEST_NETID), TEST_CAPABILITIES, TEST_LINK_PROPERTIES, TEST_IMSI, TYPE_WIFI) - assertParcelSane(emptySnapshot, 5) - assertParcelSane(snapshot, 5) + assertParcelingIsLossless(emptySnapshot) + assertParcelingIsLossless(snapshot) } } diff --git a/tests/common/java/android/net/OemNetworkPreferencesTest.java b/tests/common/java/android/net/OemNetworkPreferencesTest.java index fd29a9539d..9ecb2edf5e 100644 --- a/tests/common/java/android/net/OemNetworkPreferencesTest.java +++ b/tests/common/java/android/net/OemNetworkPreferencesTest.java @@ -17,7 +17,7 @@ package android.net; import static com.android.testutils.MiscAsserts.assertThrows; -import static com.android.testutils.ParcelUtils.assertParcelSane; +import static com.android.testutils.ParcelUtils.assertParcelingIsLossless; import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertFalse; @@ -101,7 +101,7 @@ public class OemNetworkPreferencesTest { final OemNetworkPreferences prefs = mBuilder.build(); - assertParcelSane(prefs, 1 /* fieldCount */); + assertParcelingIsLossless(prefs); } @Test diff --git a/tests/common/java/android/net/RouteInfoTest.java b/tests/common/java/android/net/RouteInfoTest.java index 71689f9197..15127fd8aa 100644 --- a/tests/common/java/android/net/RouteInfoTest.java +++ b/tests/common/java/android/net/RouteInfoTest.java @@ -19,7 +19,6 @@ package android.net; import static android.net.RouteInfo.RTN_UNREACHABLE; import static com.android.testutils.MiscAsserts.assertEqualBothWays; -import static com.android.testutils.MiscAsserts.assertFieldCountEquals; import static com.android.testutils.MiscAsserts.assertNotEqualEitherWay; import static com.android.testutils.ParcelUtils.assertParcelingIsLossless; @@ -37,7 +36,6 @@ import androidx.test.filters.SmallTest; import androidx.test.runner.AndroidJUnit4; import com.android.testutils.DevSdkIgnoreRule; -import com.android.testutils.DevSdkIgnoreRule.IgnoreAfter; import com.android.testutils.DevSdkIgnoreRule.IgnoreUpTo; import org.junit.Rule; @@ -371,17 +369,6 @@ public class RouteInfoTest { assertParcelingIsLossless(r); } - @Test @IgnoreAfter(Build.VERSION_CODES.Q) - public void testFieldCount_Q() { - assertFieldCountEquals(6, RouteInfo.class); - } - - @Test @IgnoreUpTo(Build.VERSION_CODES.Q) - public void testFieldCount() { - // Make sure any new field is covered by the above parceling tests when changing this number - assertFieldCountEquals(7, RouteInfo.class); - } - @Test @IgnoreUpTo(Build.VERSION_CODES.Q) public void testMtu() { RouteInfo r; diff --git a/tests/common/java/android/net/TcpKeepalivePacketDataTest.kt b/tests/common/java/android/net/TcpKeepalivePacketDataTest.kt index 7a18bb08fa..063ea23df5 100644 --- a/tests/common/java/android/net/TcpKeepalivePacketDataTest.kt +++ b/tests/common/java/android/net/TcpKeepalivePacketDataTest.kt @@ -20,8 +20,7 @@ import android.net.InetAddresses.parseNumericAddress import android.os.Build import com.android.testutils.DevSdkIgnoreRule import com.android.testutils.DevSdkIgnoreRunner -import com.android.testutils.assertFieldCountEquals -import com.android.testutils.assertParcelSane +import com.android.testutils.assertParcelingIsLossless import org.junit.Test import org.junit.runner.RunWith import java.net.InetAddress @@ -68,15 +67,11 @@ class TcpKeepalivePacketDataTest { assertNotEquals(makeData(tcpWndScale = 3), makeData()) assertNotEquals(makeData(ipTos = 0x14), makeData()) assertNotEquals(makeData(ipTtl = 11), makeData()) - - // Update above assertions if field is added - assertFieldCountEquals(5, KeepalivePacketData::class.java) - assertFieldCountEquals(6, TcpKeepalivePacketData::class.java) } @Test fun testParcelUnparcel() { - assertParcelSane(makeData(), fieldCount = 6) { a, b -> + assertParcelingIsLossless(makeData()) { a, b -> // .equals() does not verify .packet a == b && a.packet contentEquals b.packet } @@ -98,9 +93,5 @@ class TcpKeepalivePacketDataTest { assertTrue(str.contains(data.getTcpWindowScale().toString())) assertTrue(str.contains(data.getIpTos().toString())) assertTrue(str.contains(data.getIpTtl().toString())) - - // Update above assertions if field is added - assertFieldCountEquals(5, KeepalivePacketData::class.java) - assertFieldCountEquals(6, TcpKeepalivePacketData::class.java) } }
\ No newline at end of file diff --git a/tests/common/java/android/net/UnderlyingNetworkInfoTest.kt b/tests/common/java/android/net/UnderlyingNetworkInfoTest.kt index f23ba26d00..c405d8ed4a 100644 --- a/tests/common/java/android/net/UnderlyingNetworkInfoTest.kt +++ b/tests/common/java/android/net/UnderlyingNetworkInfoTest.kt @@ -20,7 +20,7 @@ import android.os.Build import androidx.test.filters.SmallTest import com.android.testutils.DevSdkIgnoreRule import com.android.testutils.DevSdkIgnoreRunner -import com.android.testutils.assertParcelSane +import com.android.testutils.assertParcelingIsLossless import org.junit.Test import org.junit.runner.RunWith import kotlin.test.assertEquals @@ -39,12 +39,12 @@ class UnderlyingNetworkInfoTest { assertEquals(TEST_OWNER_UID, testInfo.getOwnerUid()) assertEquals(TEST_IFACE, testInfo.getInterface()) assertEquals(TEST_IFACE_LIST, testInfo.getUnderlyingInterfaces()) - assertParcelSane(testInfo, 3) + assertParcelingIsLossless(testInfo) val emptyInfo = UnderlyingNetworkInfo(0, String(), listOf()) assertEquals(0, emptyInfo.getOwnerUid()) assertEquals(String(), emptyInfo.getInterface()) assertEquals(listOf(), emptyInfo.getUnderlyingInterfaces()) - assertParcelSane(emptyInfo, 3) + assertParcelingIsLossless(emptyInfo) } }
\ No newline at end of file diff --git a/tests/common/java/android/net/apf/ApfCapabilitiesTest.java b/tests/common/java/android/net/apf/ApfCapabilitiesTest.java index 88996d9252..fa4adcbe6e 100644 --- a/tests/common/java/android/net/apf/ApfCapabilitiesTest.java +++ b/tests/common/java/android/net/apf/ApfCapabilitiesTest.java @@ -16,7 +16,7 @@ package android.net.apf; -import static com.android.testutils.ParcelUtils.assertParcelSane; +import static com.android.testutils.ParcelUtils.assertParcelingIsLossless; import static org.junit.Assert.assertArrayEquals; import static org.junit.Assert.assertEquals; @@ -62,7 +62,7 @@ public class ApfCapabilitiesTest { assertEquals(456, caps.maximumApfProgramSize); assertEquals(789, caps.apfPacketFormat); - assertParcelSane(caps, 3); + assertParcelingIsLossless(caps); } @Test diff --git a/tests/common/java/android/net/metrics/ApfProgramEventTest.kt b/tests/common/java/android/net/metrics/ApfProgramEventTest.kt index 0b7b74097c..1c175dab79 100644 --- a/tests/common/java/android/net/metrics/ApfProgramEventTest.kt +++ b/tests/common/java/android/net/metrics/ApfProgramEventTest.kt @@ -18,7 +18,7 @@ package android.net.metrics; import androidx.test.filters.SmallTest import androidx.test.runner.AndroidJUnit4 -import com.android.testutils.assertParcelSane +import com.android.testutils.assertParcelingIsLossless import org.junit.Assert.assertEquals import org.junit.Assert.assertFalse import org.junit.Assert.assertTrue @@ -48,7 +48,7 @@ class ApfProgramEventTest { assertEquals(5, apfProgramEvent.programLength) assertEquals(ApfProgramEvent.flagsFor(true, true), apfProgramEvent.flags) - assertParcelSane(apfProgramEvent, 6) + assertParcelingIsLossless(apfProgramEvent) } @Test diff --git a/tests/common/java/android/net/metrics/ApfStatsTest.kt b/tests/common/java/android/net/metrics/ApfStatsTest.kt index 46a8c8e5b5..610e674a12 100644 --- a/tests/common/java/android/net/metrics/ApfStatsTest.kt +++ b/tests/common/java/android/net/metrics/ApfStatsTest.kt @@ -18,7 +18,7 @@ package android.net.metrics import androidx.test.filters.SmallTest import androidx.test.runner.AndroidJUnit4 -import com.android.testutils.assertParcelSane +import com.android.testutils.assertParcelingIsLossless import org.junit.Assert.assertEquals import org.junit.Test import org.junit.runner.RunWith @@ -52,6 +52,6 @@ class ApfStatsTest { assertEquals(8, apfStats.programUpdatesAllowingMulticast) assertEquals(9, apfStats.maxProgramSize) - assertParcelSane(apfStats, 10) + assertParcelingIsLossless(apfStats) } } diff --git a/tests/common/java/android/net/metrics/DhcpClientEventTest.kt b/tests/common/java/android/net/metrics/DhcpClientEventTest.kt index 8d7a9c4050..4c70e118ad 100644 --- a/tests/common/java/android/net/metrics/DhcpClientEventTest.kt +++ b/tests/common/java/android/net/metrics/DhcpClientEventTest.kt @@ -18,7 +18,7 @@ package android.net.metrics import androidx.test.filters.SmallTest import androidx.test.runner.AndroidJUnit4 -import com.android.testutils.assertParcelSane +import com.android.testutils.assertParcelingIsLossless import org.junit.Assert.assertEquals import org.junit.Test import org.junit.runner.RunWith @@ -38,6 +38,6 @@ class DhcpClientEventTest { assertEquals(FAKE_MESSAGE, dhcpClientEvent.msg) assertEquals(Integer.MAX_VALUE, dhcpClientEvent.durationMs) - assertParcelSane(dhcpClientEvent, 2) + assertParcelingIsLossless(dhcpClientEvent) } } diff --git a/tests/common/java/android/net/metrics/IpManagerEventTest.kt b/tests/common/java/android/net/metrics/IpManagerEventTest.kt index 64be50837f..bb21dca7a1 100644 --- a/tests/common/java/android/net/metrics/IpManagerEventTest.kt +++ b/tests/common/java/android/net/metrics/IpManagerEventTest.kt @@ -18,7 +18,7 @@ package android.net.metrics import androidx.test.filters.SmallTest import androidx.test.runner.AndroidJUnit4 -import com.android.testutils.assertParcelSane +import com.android.testutils.assertParcelingIsLossless import org.junit.Assert.assertEquals import org.junit.Test import org.junit.runner.RunWith @@ -33,7 +33,7 @@ class IpManagerEventTest { assertEquals(it, ipManagerEvent.eventType) assertEquals(Long.MAX_VALUE, ipManagerEvent.durationMs) - assertParcelSane(ipManagerEvent, 2) + assertParcelingIsLossless(ipManagerEvent) } } } diff --git a/tests/common/java/android/net/metrics/IpReachabilityEventTest.kt b/tests/common/java/android/net/metrics/IpReachabilityEventTest.kt index 55b5e492dd..3d21b81f0c 100644 --- a/tests/common/java/android/net/metrics/IpReachabilityEventTest.kt +++ b/tests/common/java/android/net/metrics/IpReachabilityEventTest.kt @@ -18,7 +18,7 @@ package android.net.metrics import androidx.test.filters.SmallTest import androidx.test.runner.AndroidJUnit4 -import com.android.testutils.assertParcelSane +import com.android.testutils.assertParcelingIsLossless import org.junit.Assert.assertEquals import org.junit.Test import org.junit.runner.RunWith @@ -32,7 +32,7 @@ class IpReachabilityEventTest { val ipReachabilityEvent = IpReachabilityEvent(it) assertEquals(it, ipReachabilityEvent.eventType) - assertParcelSane(ipReachabilityEvent, 1) + assertParcelingIsLossless(ipReachabilityEvent) } } } diff --git a/tests/common/java/android/net/metrics/NetworkEventTest.kt b/tests/common/java/android/net/metrics/NetworkEventTest.kt index 41430b03a1..17b5e2d2dc 100644 --- a/tests/common/java/android/net/metrics/NetworkEventTest.kt +++ b/tests/common/java/android/net/metrics/NetworkEventTest.kt @@ -18,7 +18,7 @@ package android.net.metrics import androidx.test.filters.SmallTest import androidx.test.runner.AndroidJUnit4 -import com.android.testutils.assertParcelSane +import com.android.testutils.assertParcelingIsLossless import org.junit.Assert.assertEquals import org.junit.Test import org.junit.runner.RunWith @@ -37,7 +37,7 @@ class NetworkEventTest { assertEquals(it, networkEvent.eventType) assertEquals(Long.MAX_VALUE, networkEvent.durationMs) - assertParcelSane(networkEvent, 2) + assertParcelingIsLossless(networkEvent) } } } diff --git a/tests/common/java/android/net/metrics/RaEventTest.kt b/tests/common/java/android/net/metrics/RaEventTest.kt index d9b720332f..e9daa0f670 100644 --- a/tests/common/java/android/net/metrics/RaEventTest.kt +++ b/tests/common/java/android/net/metrics/RaEventTest.kt @@ -18,7 +18,7 @@ package android.net.metrics import androidx.test.filters.SmallTest import androidx.test.runner.AndroidJUnit4 -import com.android.testutils.assertParcelSane +import com.android.testutils.assertParcelingIsLossless import org.junit.Assert.assertEquals import org.junit.Test import org.junit.runner.RunWith @@ -67,6 +67,6 @@ class RaEventTest { assertEquals(5, raEvent.rdnssLifetime) assertEquals(6, raEvent.dnsslLifetime) - assertParcelSane(raEvent, 6) + assertParcelingIsLossless(raEvent) } } diff --git a/tests/common/java/android/net/metrics/ValidationProbeEventTest.kt b/tests/common/java/android/net/metrics/ValidationProbeEventTest.kt index 51c0d41bf4..7dfa7e1f50 100644 --- a/tests/common/java/android/net/metrics/ValidationProbeEventTest.kt +++ b/tests/common/java/android/net/metrics/ValidationProbeEventTest.kt @@ -18,7 +18,7 @@ package android.net.metrics import androidx.test.filters.SmallTest import androidx.test.runner.AndroidJUnit4 -import com.android.testutils.assertParcelSane +import com.android.testutils.assertParcelingIsLossless import java.lang.reflect.Modifier import org.junit.Assert.assertEquals import org.junit.Assert.assertTrue @@ -51,7 +51,7 @@ class ValidationProbeEventTest { assertTrue(validationProbeEvent.probeType hasType FIRST_VALIDATION) assertEquals(ValidationProbeEvent.DNS_SUCCESS, validationProbeEvent.returnCode) - assertParcelSane(validationProbeEvent, 3) + assertParcelingIsLossless(validationProbeEvent) } @Test diff --git a/tests/common/java/android/net/netstats/NetworkStatsApiTest.kt b/tests/common/java/android/net/netstats/NetworkStatsApiTest.kt index 7b22e45db9..c90b1aa411 100644 --- a/tests/common/java/android/net/netstats/NetworkStatsApiTest.kt +++ b/tests/common/java/android/net/netstats/NetworkStatsApiTest.kt @@ -31,7 +31,6 @@ import android.net.NetworkStats.TAG_NONE import android.os.Build import androidx.test.filters.SmallTest import com.android.testutils.DevSdkIgnoreRule -import com.android.testutils.assertFieldCountEquals import com.android.testutils.assertNetworkStatsEquals import com.android.testutils.assertParcelingIsLossless import org.junit.Before @@ -176,7 +175,6 @@ class NetworkStatsApiTest { assertParcelingIsLossless(testStatsEmpty) assertParcelingIsLossless(testStats1) assertParcelingIsLossless(testStats2) - assertFieldCountEquals(15, NetworkStats::class.java) } @Test diff --git a/tests/cts/net/src/android/net/cts/IpConfigurationTest.java b/tests/cts/net/src/android/net/cts/IpConfigurationTest.java index 56ab2a7531..385bf9e27f 100644 --- a/tests/cts/net/src/android/net/cts/IpConfigurationTest.java +++ b/tests/cts/net/src/android/net/cts/IpConfigurationTest.java @@ -16,7 +16,7 @@ package android.net.cts; -import static com.android.testutils.ParcelUtils.assertParcelSane; +import static com.android.testutils.ParcelUtils.assertParcelingIsLossless; import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertNull; @@ -118,6 +118,6 @@ public final class IpConfigurationTest { @Test public void testParcel() { final IpConfiguration config = new IpConfiguration(); - assertParcelSane(config, 4); + assertParcelingIsLossless(config); } } diff --git a/tests/cts/net/src/android/net/cts/MacAddressTest.java b/tests/cts/net/src/android/net/cts/MacAddressTest.java index 3fd3bbac8c..e47155b213 100644 --- a/tests/cts/net/src/android/net/cts/MacAddressTest.java +++ b/tests/cts/net/src/android/net/cts/MacAddressTest.java @@ -20,7 +20,7 @@ import static android.net.MacAddress.TYPE_BROADCAST; import static android.net.MacAddress.TYPE_MULTICAST; import static android.net.MacAddress.TYPE_UNICAST; -import static com.android.testutils.ParcelUtils.assertParcelSane; +import static com.android.testutils.ParcelUtils.assertParcelingIsLossless; import static org.junit.Assert.assertArrayEquals; import static org.junit.Assert.assertFalse; @@ -218,6 +218,6 @@ public class MacAddressTest { public void testParcelMacAddress() { final MacAddress mac = MacAddress.fromString("52:74:f2:b1:a8:7f"); - assertParcelSane(mac, 1); + assertParcelingIsLossless(mac); } } |