diff options
| author | Elliot Sisteron <elliotsisteron@google.com> | 2023-07-27 17:00:23 +0000 |
|---|---|---|
| committer | Elliot Sisteron <elliotsisteron@google.com> | 2023-07-28 11:17:03 +0000 |
| commit | 634854be9b320c589a35b1d517227cd39cccc29e (patch) | |
| tree | edde37457c18a010daeb442aa8d473a2376c6c60 /SafetyCenter | |
| parent | 75aed2a34e77a1e3db24a93e14ee4ffe325ee94c (diff) | |
| download | Permission-634854be9b320c589a35b1d517227cd39cccc29e.tar.gz | |
Cleanup safety_center_show_error_entries_on_timeout flag.
This one is a bit trickier because tests rely on this in multiple ways:
- UI tests want to ensure that the data on the screen doesn't change,
however a refresh is triggered on page open and most tests set the data
manually rather than using the receiver to do so. The timeout could set
error on UI entries in the middle of the test, which isn't ideal. Worked
around this by setting the refresh timeout to the test timeout.
- Some existing tests were actively checking the behavior of that flag
and using the error listener as an easy way to check for timeouts.
I think it's a good thing to cleanup this flag regardless, as we ideally
want to have tests matching the production behavior, which wasn't the case
here (the flag was set to false in tests, but true in production code).
Bug: 289788052
Test: SafetyCenter tests
Relnote: N/A
Change-Id: I1f9dc8749d46f437c8dfbb98228ed1f042ee5821
Diffstat (limited to 'SafetyCenter')
| -rw-r--r-- | SafetyCenter/Resources/shared_res/values/strings.xml | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/SafetyCenter/Resources/shared_res/values/strings.xml b/SafetyCenter/Resources/shared_res/values/strings.xml index f4f1b0201..2b231b55f 100644 --- a/SafetyCenter/Resources/shared_res/values/strings.xml +++ b/SafetyCenter/Resources/shared_res/values/strings.xml @@ -94,9 +94,6 @@ <!-- An error shown to the user when we failed to resolve an alert that they attempted to resolve directly from the Safety Center screen [CHAR LIMIT=50] --> <string name="resolving_action_error">Couldn\’t resolve alert</string> - <!-- An error shown to the user when we failed to refresh the overall Safety Center status. This happens when at least one safety signal did not get back to Safety Center within an arbitrary timeout [CHAR LIMIT=50] --> - <string name="refresh_timeout">Couldn\’t refresh settings</string> - <!-- An error shown to the user when we failed to refresh the status of one or more Safety Center entries. The number of entries is used as a parameter to format the error [CHAR LIMIT=60] --> <string name="refresh_error">{count, plural, =1 {Couldn\’t check setting} |