diff options
author | Chih-Hung Hsieh <chh@google.com> | 2016-08-17 12:45:53 -0700 |
---|---|---|
committer | Chih-Hung Hsieh <chh@google.com> | 2016-08-17 12:45:53 -0700 |
commit | dba181546ef0e64624f8a917d5b723200906c1fb (patch) | |
tree | c5b3222e495f11ddab2f809f040e28092cbc81e5 | |
parent | 5fde07bc503c9441330e68451940aa4b1afdfa51 (diff) | |
download | shill-dba181546ef0e64624f8a917d5b723200906c1fb.tar.gz |
Suppress clang-tidy performance warnings in shill.
Add NOLINT to suppress warnings on non-const-reference parameters.
These functions need to have type RpcServerMethodHandler.
Bug: 30407689
Change-Id: I2ce3698b9b7f94c5158d6bdc46d37090d5b3ff93
Test: build with WITH_TIDY=1
-rw-r--r-- | test-rpc-proxy/proxy_rpc_server.cc | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/test-rpc-proxy/proxy_rpc_server.cc b/test-rpc-proxy/proxy_rpc_server.cc index 4ddaaa6b..dc98b4e8 100644 --- a/test-rpc-proxy/proxy_rpc_server.cc +++ b/test-rpc-proxy/proxy_rpc_server.cc @@ -79,7 +79,7 @@ XmlRpc::XmlRpcValue PopProfile( } XmlRpc::XmlRpcValue CleanProfiles( - XmlRpc::XmlRpcValue params_in, + XmlRpc::XmlRpcValue params_in, // NOLINT(pass-by-value) ProxyShillWifiClient* shill_wifi_client) { if (!ValidateNumOfElements(params_in, 0)) { return false; @@ -186,7 +186,7 @@ XmlRpc::XmlRpcValue DeleteEntriesForSsid( } XmlRpc::XmlRpcValue InitTestNetworkState( - XmlRpc::XmlRpcValue params_in, + XmlRpc::XmlRpcValue params_in, // NOLINT(pass-by-value) ProxyShillWifiClient* shill_wifi_client) { if (!ValidateNumOfElements(params_in, 0)) { return false; @@ -203,7 +203,7 @@ XmlRpc::XmlRpcValue InitTestNetworkState( } XmlRpc::XmlRpcValue ListControlledWifiInterfaces( - XmlRpc::XmlRpcValue params_in, + XmlRpc::XmlRpcValue params_in, // NOLINT(pass-by-value) ProxyShillWifiClient* shill_wifi_client) { if (!ValidateNumOfElements(params_in, 0)) { return false; @@ -257,7 +257,7 @@ XmlRpc::XmlRpcValue WaitForServiceStates( } XmlRpc::XmlRpcValue GetServiceOrder( - XmlRpc::XmlRpcValue params_in, + XmlRpc::XmlRpcValue params_in, // NOLINT(pass-by-value) ProxyShillWifiClient* shill_wifi_client) { if (!ValidateNumOfElements(params_in, 0)) { return false; @@ -296,7 +296,7 @@ XmlRpc::XmlRpcValue GetServiceProperties( } XmlRpc::XmlRpcValue GetActiveWifiSsids( - XmlRpc::XmlRpcValue params_in, + XmlRpc::XmlRpcValue params_in, // NOLINT(pass-by-value) ProxyShillWifiClient* shill_wifi_client) { if (!ValidateNumOfElements(params_in, 0)) { return false; @@ -467,7 +467,7 @@ XmlRpc::XmlRpcValue SyncTimeTo( // Dummy method to be used for rpc methods not implemented yet. XmlRpc::XmlRpcValue NotImplementedRpcMethod( - XmlRpc::XmlRpcValue params_in, + XmlRpc::XmlRpcValue params_in, // NOLINT(pass-by-value) ProxyShillWifiClient* shill_wifi_client) { LOG(ERROR) << "RPC Method not implemented."; return true; |