diff options
| author | Chih-Hung Hsieh <chh@google.com> | 2016-06-24 15:35:12 -0700 |
|---|---|---|
| committer | Chih-hung Hsieh <chh@google.com> | 2016-06-27 22:19:22 +0000 |
| commit | e7126b88fd9683faa7d3827a244cf03865605ba6 (patch) | |
| tree | 4049f067c08c5f45d43dc4af8b42165a7f6a84b8 | |
| parent | e04b064a46c958fc5d82dfbce82706ffaeeb023d (diff) | |
| download | shill-e7126b88fd9683faa7d3827a244cf03865605ba6.tar.gz | |
Fix misc-macro-parentheses warnings in shill
Add parentheses around macro arguments used beside operators.
Bug: 28705665
Test: build with clang-tidy
Change-Id: Ibdd93e93785a56c70151c5ccc358c0c1797d2857
| -rw-r--r-- | logging.h | 8 |
1 files changed, 4 insertions, 4 deletions
@@ -46,19 +46,19 @@ ::shill::ScopeLogger::k##scope, verbose_level) #define SLOG_STREAM(verbose_level) \ - ::logging::LogMessage(__FILE__, __LINE__, -verbose_level).stream() + ::logging::LogMessage(__FILE__, __LINE__, -(verbose_level)).stream() #define SLOG_2ARG(object, verbose_level) \ LAZY_STREAM(SLOG_STREAM(verbose_level), \ ::shill::ScopeLogger::GetInstance()->IsLogEnabled( \ Logging::kModuleLogScope, verbose_level)) \ - << (object ? Logging::ObjectID(object) : "(anon)") << " " + << ((object) ? Logging::ObjectID(object) : "(anon)") << " " #define SLOG_3ARG(scope, object, verbose_level) \ LAZY_STREAM(SLOG_STREAM(verbose_level), \ ::shill::ScopeLogger::GetInstance()->IsLogEnabled( \ ::shill::ScopeLogger::k##scope, verbose_level)) \ - << (object ? Logging::ObjectID(object) : "(anon)") << " " + << ((object) ? Logging::ObjectID(object) : "(anon)") << " " #define SLOG(...) \ GET_MACRO_OVERLOAD2(__VA_ARGS__, SLOG_3ARG, SLOG_2ARG)(__VA_ARGS__) @@ -68,7 +68,7 @@ SLOG_IS_ON(scope, verbose_level) && (condition)) #define SPLOG_STREAM(verbose_level) \ - ::logging::ErrnoLogMessage(__FILE__, __LINE__, -verbose_level, \ + ::logging::ErrnoLogMessage(__FILE__, __LINE__, -(verbose_level), \ ::logging::GetLastSystemErrorCode()).stream() #define SPLOG(scope, verbose_level) \ |