diff options
| author | Samuel Tan <samueltan@google.com> | 2016-02-12 16:49:27 -0800 |
|---|---|---|
| committer | Samuel Tan <samueltan@google.com> | 2016-02-16 12:50:09 -0800 |
| commit | b4e6c34f30693179c743b81f490344088173eb9d (patch) | |
| tree | e79b9b46e8f3c6915a18b4dcabb800298d2a2273 /key_value_store_unittest.cc | |
| parent | 3289d7c7f72b5a370d22c0b285ba06c0b23248f0 (diff) | |
| download | shill-b4e6c34f30693179c743b81f490344088173eb9d.tar.gz | |
shill: fix bugs in KeyValueStoreTest
Fix the following bugs/typos in KeyValueStoreTest:
- Fix a test case that is supposed to test for the
non-equality of two KeyValueStores that have the
same key but different values.
- Use of "ContainsInt" instead of "ContainsKeyValueStore".
- Use of "SetInt" instead of "SetInt16".
BUG: None
Change-Id: I40df8c33b025c3f21d94c4356fcb04eb421f74cf
TEST: shill compiles and unit tests pass.
Diffstat (limited to 'key_value_store_unittest.cc')
| -rw-r--r-- | key_value_store_unittest.cc | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/key_value_store_unittest.cc b/key_value_store_unittest.cc index 5e56bdb1..5a27bb85 100644 --- a/key_value_store_unittest.cc +++ b/key_value_store_unittest.cc @@ -293,7 +293,7 @@ TEST_F(KeyValueStoreTest, Clear) { EXPECT_FALSE(store_.ContainsByteArrays(kByteArraysKey)); EXPECT_FALSE(store_.ContainsInt(kIntKey)); EXPECT_FALSE(store_.ContainsInt16(kInt16Key)); - EXPECT_FALSE(store_.ContainsInt(kKeyValueStoreKey)); + EXPECT_FALSE(store_.ContainsKeyValueStore(kKeyValueStoreKey)); EXPECT_FALSE(store_.ContainsRpcIdentifier(kRpcIdentifierKey)); EXPECT_FALSE(store_.ContainsString(kStringKey)); EXPECT_FALSE(store_.ContainsStringmap(kStringmapKey)); @@ -339,7 +339,7 @@ TEST_F(KeyValueStoreTest, Equals) { first.Clear(); second.Clear(); first.SetByteArrays("byteArraysKey", kByteArrays1); - second.SetByteArrays("byteArraysOtherKey", kByteArrays2); + second.SetByteArrays("byteArraysKey", kByteArrays2); EXPECT_NE(first, second); first.Clear(); @@ -504,7 +504,7 @@ TEST_F(KeyValueStoreTest, Equals) { first.SetBool("boolKey", true); first.SetByteArrays("byteArraysKey", kByteArrays1); first.SetInt("intKey", 123); - first.SetInt("int16Key", 123); + first.SetInt16("int16Key", 123); first.SetRpcIdentifier("rpcIdentifierKey", "rpcid"); first.SetString("stringKey", "value"); first.SetStringmap("stringmapKey", kStringmap1); @@ -516,7 +516,7 @@ TEST_F(KeyValueStoreTest, Equals) { second.SetBool("boolKey", true); second.SetByteArrays("byteArraysKey", kByteArrays1); second.SetInt("intKey", 123); - second.SetInt("int16Key", 123); + second.SetInt16("int16Key", 123); second.SetRpcIdentifier("rpcIdentifierKey", "rpcid"); second.SetString("stringKey", "value"); second.SetStringmap("stringmapKey", kStringmap1); |