diff options
| author | Chih-Hung Hsieh <chh@google.com> | 2016-07-28 12:23:20 -0700 |
|---|---|---|
| committer | Chih-Hung Hsieh <chh@google.com> | 2016-07-28 13:38:06 -0700 |
| commit | ec5aa476af8904680a7ffc461d4019d9c669bc04 (patch) | |
| tree | c7fb963c8b3d3474d04db9983d408c81665bad3c /vpn/vpn_provider.cc | |
| parent | 530fe47029e0128f3d4d1ee26a8ac8dfaf21aa90 (diff) | |
| download | shill-ec5aa476af8904680a7ffc461d4019d9c669bc04.tar.gz | |
Fix clang-tidy performance warnings in shill.
* Use const reference type for parameters, local variables,
and for-loop index variables to avoid unnecessary copy.
Bug: 30407689
Bug: 30413223
Bug: 30413862
Change-Id: Ib6b5f11086d07f39b924f748ea44c15b82d83d23
Diffstat (limited to 'vpn/vpn_provider.cc')
| -rw-r--r-- | vpn/vpn_provider.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/vpn/vpn_provider.cc b/vpn/vpn_provider.cc index b9965b61..163037c8 100644 --- a/vpn/vpn_provider.cc +++ b/vpn/vpn_provider.cc @@ -181,7 +181,7 @@ bool VPNProvider::OnDeviceInfoAvailable(const string& link_name, return false; } -void VPNProvider::RemoveService(VPNServiceRefPtr service) { +void VPNProvider::RemoveService(const VPNServiceRefPtr& service) { const auto it = std::find(services_.begin(), services_.end(), service); if (it != services_.end()) { services_.erase(it); |