diff options
| author | Treehugger Robot <treehugger-gerrit@google.com> | 2018-01-15 23:23:32 +0000 |
|---|---|---|
| committer | Gerrit Code Review <noreply-gerritcodereview@google.com> | 2018-01-15 23:23:32 +0000 |
| commit | 3e4cd931cc5976280f8e68d5ec377de0deb04480 (patch) | |
| tree | c495878833982f1a123e751d6019fbbf6fcac538 | |
| parent | 61fb5fe766150b2a2cc25e266371525b2ff8266a (diff) | |
| parent | ecc7faf601455e6485b31412126edc3acac4a6b7 (diff) | |
| download | extras-3e4cd931cc5976280f8e68d5ec377de0deb04480.tar.gz | |
Merge "Perfprofd: Enable some more warnings"
| -rw-r--r-- | perfprofd/Android.bp | 14 | ||||
| -rw-r--r-- | perfprofd/perfprofdcore.cc | 8 | ||||
| -rw-r--r-- | perfprofd/quipper/perf_reader.cc | 1 |
3 files changed, 18 insertions, 5 deletions
diff --git a/perfprofd/Android.bp b/perfprofd/Android.bp index 09709061..4a7f2f66 100644 --- a/perfprofd/Android.bp +++ b/perfprofd/Android.bp @@ -19,7 +19,21 @@ cc_defaults { cflags: [ "-Wall", + "-Wextra", "-Werror", + + // Try some more extreme warnings. + "-Wpedantic", + "-Wunreachable-code-aggressive", + // And disable some dumb things. + "-Wno-zero-length-array", + "-Wno-c99-extensions", + "-Wno-language-extension-token", + "-Wno-gnu-zero-variadic-macro-arguments", + "-Wno-nested-anon-types", + "-Wno-gnu-statement-expression", + "-Wno-vla-extension", + "-Wno-extended-offsetof", ], cppflags: [ "-Wno-sign-compare", diff --git a/perfprofd/perfprofdcore.cc b/perfprofd/perfprofdcore.cc index 7a7ef339..69a8a75f 100644 --- a/perfprofd/perfprofdcore.cc +++ b/perfprofd/perfprofdcore.cc @@ -171,9 +171,9 @@ const char *ckprofile_result_to_string(CKPROFILE_RESULT result) return "missing 'perf' executable"; case DONT_PROFILE_RUNNING_IN_EMULATOR: return "running in emulator"; - default: return "unknown"; + default: + return "unknown"; } - return "notreached"; } // @@ -194,9 +194,9 @@ const char *profile_result_to_string(PROFILE_RESULT result) return "failed to open encoded perf file"; case ERR_WRITE_ENCODED_FILE_FAILED: return "write to encoded perf file failed"; - default: return "unknown"; + default: + return "unknown"; } - return "notreached"; } // diff --git a/perfprofd/quipper/perf_reader.cc b/perfprofd/quipper/perf_reader.cc index 48497d07..d0cc9b60 100644 --- a/perfprofd/quipper/perf_reader.cc +++ b/perfprofd/quipper/perf_reader.cc @@ -1168,7 +1168,6 @@ bool PerfReader::ReadMetadata(const ConstBufferWithSize& data) { case HEADER_PMU_MAPPINGS: // ignore for now continue; - break; case HEADER_BRANCH_STACK: continue; default: LOG(INFO) << "Unsupported metadata type: " << type; |