summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndroid Build Coastguard Worker <android-build-coastguard-worker@google.com>2023-01-10 00:27:45 +0000
committerAndroid Build Coastguard Worker <android-build-coastguard-worker@google.com>2023-01-10 00:27:45 +0000
commit46dfa258278471adef6ac422a05c0914ff871ea1 (patch)
tree26407752cac0d85f13f5b12e738e4e77c975b52e
parentff0fd902a0f652bf95491264e39d764180ea967e (diff)
parentc82569e37a745665549df5a77159a0584b45e7d5 (diff)
downloadincremental_delivery-android13-qpr3-s7-release.tar.gz
Change-Id: I9a3e9c07fa96cbf53ae2acae705a1249b9c0d2ee
-rw-r--r--incfs/MountRegistry.cpp3
-rw-r--r--incfs/include/incfs_inline.h2
-rw-r--r--incfs/tests/util/map_ptr_test.cpp2
3 files changed, 4 insertions, 3 deletions
diff --git a/incfs/MountRegistry.cpp b/incfs/MountRegistry.cpp
index 4f16f73..376eaf2 100644
--- a/incfs/MountRegistry.cpp
+++ b/incfs/MountRegistry.cpp
@@ -355,7 +355,8 @@ bool MountRegistry::Mounts::loadFrom(base::borrowed_fd fd, std::string_view file
if (mount.backing.empty()) {
mount.backing = std::move(backingDir);
} else if (mount.backing != backingDir) {
- LOG(WARNING) << "[incfs] root '" << *mount.roots.begin()
+ LOG(WARNING) << "[incfs] root '"
+ << (!mount.roots.empty() ? *mount.roots.begin() : "<unknown>")
<< "' mounted in multiple places with different backing dirs, '"
<< mount.backing << "' vs new '" << backingDir
<< "'; updating to the new one";
diff --git a/incfs/include/incfs_inline.h b/incfs/include/incfs_inline.h
index f3d1e89..545a735 100644
--- a/incfs/include/incfs_inline.h
+++ b/incfs/include/incfs_inline.h
@@ -306,9 +306,9 @@ inline std::pair<ErrorCode, FilledRanges> getFilledRanges(int fd,
}
inline std::pair<ErrorCode, FilledRanges> getFilledRanges(int fd, FilledRanges&& resumeFrom) {
+ auto totalRanges = resumeFrom.dataRanges().size() + resumeFrom.hashRanges().size();
auto rawRanges = resumeFrom.internalRawRanges();
auto buffer = resumeFrom.extractInternalBufferAndClear();
- auto totalRanges = resumeFrom.dataRanges().size() + resumeFrom.hashRanges().size();
auto remainingSpace = buffer.size() - totalRanges;
const bool loadAll = remainingSpace == 0;
int res;
diff --git a/incfs/tests/util/map_ptr_test.cpp b/incfs/tests/util/map_ptr_test.cpp
index c78d91d..f9c96aa 100644
--- a/incfs/tests/util/map_ptr_test.cpp
+++ b/incfs/tests/util/map_ptr_test.cpp
@@ -325,4 +325,4 @@ TEST_F(MapPtrTest, GetDataAfterClose) {
auto p1 = map->data().offset(missing_page_start).convert<uint32_t>();
ASSERT_FALSE(p1);
ASSERT_SIGBUS(p1.value());
-} \ No newline at end of file
+}