diff options
author | Steven Moreland <smoreland@google.com> | 2019-05-20 14:56:05 -0700 |
---|---|---|
committer | Nikoli Cartagena <dargeren@google.com> | 2019-06-10 15:55:18 -0700 |
commit | 3dcf3029b11fea0815a654b598228bc350d65bec (patch) | |
tree | 34861bb5cf088b6d13e6a74aa02198cdf7554408 | |
parent | 6fe2c6925a0a3765044e49f70fd6f70c3cc8d433 (diff) | |
download | libhidl-android-8.0.0_r37.tar.gz |
Delete vestigial Status parcel read.android-security-8.0.0_r54android-security-8.0.0_r53android-security-8.0.0_r52android-8.0.0_r51android-8.0.0_r50android-8.0.0_r49android-8.0.0_r48android-8.0.0_r47android-8.0.0_r46android-8.0.0_r45android-8.0.0_r44android-8.0.0_r43android-8.0.0_r42android-8.0.0_r41android-8.0.0_r40android-8.0.0_r39android-8.0.0_r38android-8.0.0_r37security-oc-releaseoreo-security-release
libbinder Status has the exception type EX_HAS_REPLY_HEADER for fat
Java-specific errors. This code jumps Parcel position to an arbitrary
position in memory based on a value it reads from this parcel. Since
this is unused in HIDL, removing entirely.
Bug: 132650049
Test: HIDL's run_all_device_tests.sh
Change-Id: Iac815f92c5da4ead283d3566892b5d4d209dab3b
(cherry picked from commit 7fd5fbec0c4118203d37cfcc13d9451d3638c53d)
-rw-r--r-- | transport/HidlBinderSupport.cpp | 16 |
1 files changed, 0 insertions, 16 deletions
diff --git a/transport/HidlBinderSupport.cpp b/transport/HidlBinderSupport.cpp index 142720a..3fb5a0f 100644 --- a/transport/HidlBinderSupport.cpp +++ b/transport/HidlBinderSupport.cpp @@ -139,22 +139,6 @@ status_t readFromParcel(Status *s, const Parcel& parcel) { return status; } - // Skip over fat response headers. Not used (or propagated) in native code. - if (exception == Status::EX_HAS_REPLY_HEADER) { - // Note that the header size includes the 4 byte size field. - const int32_t header_start = parcel.dataPosition(); - int32_t header_size; - status = parcel.readInt32(&header_size); - if (status != OK) { - s->setFromStatusT(status); - return status; - } - parcel.setDataPosition(header_start + header_size); - // And fat response headers are currently only used when there are no - // exceptions, so act like there was no error. - exception = Status::EX_NONE; - } - if (exception == Status::EX_NONE) { *s = Status::ok(); return status; |