diff options
author | Steven Moreland <smoreland@google.com> | 2019-05-20 14:56:05 -0700 |
---|---|---|
committer | Nikoli Cartagena <dargeren@google.com> | 2019-06-10 15:55:06 -0700 |
commit | b302e914164a2b3c729fe6e8bd8eb565789524e3 (patch) | |
tree | 6526099afa03b35199efc91008352159e94021ed | |
parent | ba20bcf9bfee19c3bbbbeaa306f63c3ea8f54f92 (diff) | |
download | libhidl-android-security-8.1.0_r87.tar.gz |
Delete vestigial Status parcel read.android-security-8.1.0_r93android-security-8.1.0_r92android-security-8.1.0_r91android-security-8.1.0_r90android-security-8.1.0_r89android-security-8.1.0_r88android-security-8.1.0_r87android-security-8.1.0_r86android-security-8.1.0_r85android-security-8.1.0_r84android-security-8.1.0_r83android-security-8.1.0_r82android-8.1.0_r81android-8.1.0_r80android-8.1.0_r79android-8.1.0_r78android-8.1.0_r77android-8.1.0_r76android-8.1.0_r75android-8.1.0_r74android-8.1.0_r73android-8.1.0_r72android-8.1.0_r71android-8.1.0_r70android-8.1.0_r69android-8.1.0_r68android-8.1.0_r66security-oc-mr1-releaseoreo-mr1-security-release
libbinder Status has the exception type EX_HAS_REPLY_HEADER for fat
Java-specific errors. This code jumps Parcel position to an arbitrary
position in memory based on a value it reads from this parcel. Since
this is unused in HIDL, removing entirely.
Bug: 132650049
Test: HIDL's run_all_device_tests.sh
Change-Id: Iac815f92c5da4ead283d3566892b5d4d209dab3b
(cherry picked from commit 7fd5fbec0c4118203d37cfcc13d9451d3638c53d)
-rw-r--r-- | transport/HidlBinderSupport.cpp | 16 |
1 files changed, 0 insertions, 16 deletions
diff --git a/transport/HidlBinderSupport.cpp b/transport/HidlBinderSupport.cpp index 31e3be8..1217de1 100644 --- a/transport/HidlBinderSupport.cpp +++ b/transport/HidlBinderSupport.cpp @@ -155,22 +155,6 @@ status_t readFromParcel(Status *s, const Parcel& parcel) { return status; } - // Skip over fat response headers. Not used (or propagated) in native code. - if (exception == Status::EX_HAS_REPLY_HEADER) { - // Note that the header size includes the 4 byte size field. - const int32_t header_start = parcel.dataPosition(); - int32_t header_size; - status = parcel.readInt32(&header_size); - if (status != OK) { - s->setFromStatusT(status); - return status; - } - parcel.setDataPosition(header_start + header_size); - // And fat response headers are currently only used when there are no - // exceptions, so act like there was no error. - exception = Status::EX_NONE; - } - if (exception == Status::EX_NONE) { *s = Status::ok(); return status; |