summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSteven Moreland <smoreland@google.com>2018-10-24 16:28:35 -0700
committerSteven Moreland <smoreland@google.com>2018-10-24 16:30:12 -0700
commit37814cb28eced38a02610ea2931d4e7e818f731b (patch)
treef04b81cf24fcc81de2eba9aba05b0adcd77c704a
parentce34eb5d957de03fe43cca634e9acbdfe3af1b49 (diff)
downloadlibhidl-37814cb28eced38a02610ea2931d4e7e818f731b.tar.gz
update with -Wdocumentation.
Some clients use this, and it was breaking them if they tried to use some of our headers (specifically 1.0 service manager). Putting this up to unblock those changes. Bug: N/A Test: mma (-Wdocumentation checked at build time) Change-Id: I4453848bf91f1d20d0c5c1a28dd9f9e6f5de99fc
-rw-r--r--Android.bp1
-rw-r--r--transport/current.txt1
-rw-r--r--transport/manager/1.0/IServiceManager.hal2
3 files changed, 3 insertions, 1 deletions
diff --git a/Android.bp b/Android.bp
index 0f91348..fd750fa 100644
--- a/Android.bp
+++ b/Android.bp
@@ -16,6 +16,7 @@ cc_defaults {
name: "libhidl-defaults",
cflags: [
"-Wall",
+ "-Wdocumentation", // since some users use this
"-Werror",
"-Wextra-semi",
],
diff --git a/transport/current.txt b/transport/current.txt
index 3794dfe..322857a 100644
--- a/transport/current.txt
+++ b/transport/current.txt
@@ -21,6 +21,7 @@ bddab6184d7a346da6a07dc0828cf19a696f4caa3611c51f2e14565a14b40fd9 android.hidl.ba
2e19301ceb87fb0696cd8268fab9c41f95d23c7392d35bc575daaa6eb32807eb android.hidl.memory.token@1.0::IMemoryToken
# ABI preserving changes to HALs during Android Q
+85394f8a0d15e7fb2ee45c52d1fb8b8fd3c13c333e63c78c4aa1ff86840cf6dc android.hidl.manager@1.0::IServiceManager
fcde1d0788066a62d5766f4dc19d4c1ec76967d5ddb636f59ccc66603460bcf8 android.hidl.manager@1.0::IServiceNotification
# Clarification for b/67503915
diff --git a/transport/manager/1.0/IServiceManager.hal b/transport/manager/1.0/IServiceManager.hal
index 2b59a56..6eddefb 100644
--- a/transport/manager/1.0/IServiceManager.hal
+++ b/transport/manager/1.0/IServiceManager.hal
@@ -43,7 +43,7 @@ interface IServiceManager {
* WARNING: This function is for libhidl/HwBinder use only. You are likely
* looking for 'IMyInterface::getService("name")' instead.
*
- * @param iface Fully-qualified interface name.
+ * @param fqName Fully-qualified interface name.
* @param name Instance name. Same as in IServiceManager::add.
*
* @return service Handle to requested service, same as provided in