diff options
author | Yi Kong <yikong@google.com> | 2018-07-24 01:20:52 -0700 |
---|---|---|
committer | android-build-merger <android-build-merger@google.com> | 2018-07-24 01:20:52 -0700 |
commit | bf1e65cf98a15ceff99ca56d5a9af1fa90673471 (patch) | |
tree | e4aafe580c2fadc935c28baf1b48f332e85c25c8 | |
parent | 96c42d70dc37c84c6640dc69564975feb02a4e39 (diff) | |
parent | 55d4107c06fb0dc4051a3039174fbba36968f108 (diff) | |
download | libhwbinder-bf1e65cf98a15ceff99ca56d5a9af1fa90673471.tar.gz |
Modernize codebase by replacing NULL with nullptrtemp_p_merge
am: 55d4107c06
Change-Id: I77cb3c205454b5500508c48c0768c5611cfc13b4
-rw-r--r-- | Binder.cpp | 12 | ||||
-rw-r--r-- | BpHwBinder.cpp | 28 | ||||
-rw-r--r-- | BufferedTextOutput.cpp | 8 | ||||
-rw-r--r-- | Debug.cpp | 6 | ||||
-rw-r--r-- | IInterface.cpp | 4 | ||||
-rw-r--r-- | IPCThreadState.cpp | 26 | ||||
-rw-r--r-- | Parcel.cpp | 66 | ||||
-rw-r--r-- | ProcessState.cpp | 40 | ||||
-rw-r--r-- | include/hwbinder/Binder.h | 6 | ||||
-rw-r--r-- | include/hwbinder/BpHwBinder.h | 6 | ||||
-rw-r--r-- | include/hwbinder/Debug.h | 4 | ||||
-rw-r--r-- | include/hwbinder/IBinder.h | 6 | ||||
-rw-r--r-- | include/hwbinder/IPCThreadState.h | 2 |
13 files changed, 107 insertions, 107 deletions
@@ -43,12 +43,12 @@ IBinder::~IBinder() BHwBinder* IBinder::localBinder() { - return NULL; + return nullptr; } BpHwBinder* IBinder::remoteBinder() { - return NULL; + return nullptr; } bool IBinder::checkSubclass(const void* /*subclassID*/) const @@ -90,7 +90,7 @@ status_t BHwBinder::transact( err = onTransact(code, data, reply, flags, [&](auto &replyParcel) { replyParcel.setDataPosition(0); - if (callback != NULL) { + if (callback != nullptr) { callback(replyParcel); } }); @@ -129,7 +129,7 @@ void BHwBinder::attachObject( delete e; e = expected; // Filled in by CAS } - if (e == 0) return; // out of memory + if (e == nullptr) return; // out of memory } AutoMutex _l(e->mLock); @@ -139,7 +139,7 @@ void BHwBinder::attachObject( void* BHwBinder::findObject(const void* objectID) const { Extras* e = mExtras.load(std::memory_order_acquire); - if (!e) return NULL; + if (!e) return nullptr; AutoMutex _l(e->mLock); return e->mObjects.find(objectID); @@ -183,7 +183,7 @@ enum { }; BpHwRefBase::BpHwRefBase(const sp<IBinder>& o) - : mRemote(o.get()), mRefs(NULL), mState(0) + : mRemote(o.get()), mRefs(nullptr), mState(0) { if (mRemote) { mRemote->incStrong(this); // Removed on first IncStrong(). diff --git a/BpHwBinder.cpp b/BpHwBinder.cpp index 90b3c6f..223f854 100644 --- a/BpHwBinder.cpp +++ b/BpHwBinder.cpp @@ -62,7 +62,7 @@ void BpHwBinder::ObjectManager::attach( void* BpHwBinder::ObjectManager::find(const void* objectID) const { const ssize_t i = mObjects.indexOfKey(objectID); - if (i < 0) return NULL; + if (i < 0) return nullptr; return mObjects.valueAt(i).object; } @@ -77,7 +77,7 @@ void BpHwBinder::ObjectManager::kill() ALOGV("Killing %zu objects in manager %p", N, this); for (size_t i=0; i<N; i++) { const entry_t& e = mObjects.valueAt(i); - if (e.func != NULL) { + if (e.func != nullptr) { e.func(mObjects.keyAt(i), e.object, e.cleanupCookie); } } @@ -91,7 +91,7 @@ BpHwBinder::BpHwBinder(int32_t handle) : mHandle(handle) , mAlive(1) , mObitsSent(0) - , mObituaries(NULL) + , mObituaries(nullptr) { ALOGV("Creating BpHwBinder %p handle %d\n", this, mHandle); @@ -121,7 +121,7 @@ status_t BpHwBinder::linkToDeath( ob.cookie = cookie; ob.flags = flags; - LOG_ALWAYS_FATAL_IF(recipient == NULL, + LOG_ALWAYS_FATAL_IF(recipient == nullptr, "linkToDeath(): recipient must be non-NULL"); { @@ -161,9 +161,9 @@ status_t BpHwBinder::unlinkToDeath( for (size_t i=0; i<N; i++) { const Obituary& obit = mObituaries->itemAt(i); if ((obit.recipient == recipient - || (recipient == NULL && obit.cookie == cookie)) + || (recipient == nullptr && obit.cookie == cookie)) && obit.flags == flags) { - if (outRecipient != NULL) { + if (outRecipient != nullptr) { *outRecipient = mObituaries->itemAt(i).recipient; } mObituaries->removeAt(i); @@ -173,7 +173,7 @@ status_t BpHwBinder::unlinkToDeath( self->clearDeathNotification(mHandle, this); self->flushCommands(); delete mObituaries; - mObituaries = NULL; + mObituaries = nullptr; } return NO_ERROR; } @@ -192,12 +192,12 @@ void BpHwBinder::sendObituary() mLock.lock(); Vector<Obituary>* obits = mObituaries; - if(obits != NULL) { + if(obits != nullptr) { ALOGV("Clearing sent death notification: %p handle %d\n", this, mHandle); IPCThreadState* self = IPCThreadState::self(); self->clearDeathNotification(mHandle, this); self->flushCommands(); - mObituaries = NULL; + mObituaries = nullptr; } mObitsSent = 1; mLock.unlock(); @@ -205,7 +205,7 @@ void BpHwBinder::sendObituary() ALOGV("Reporting death of proxy %p for %zu recipients\n", this, obits ? obits->size() : 0U); - if (obits != NULL) { + if (obits != nullptr) { const size_t N = obits->size(); for (size_t i=0; i<N; i++) { reportOneDeath(obits->itemAt(i)); @@ -219,7 +219,7 @@ void BpHwBinder::reportOneDeath(const Obituary& obit) { sp<DeathRecipient> recipient = obit.recipient.promote(); ALOGV("Reporting death to recipient: %p\n", recipient.get()); - if (recipient == NULL) return; + if (recipient == nullptr) return; recipient->binderDied(this); } @@ -259,13 +259,13 @@ BpHwBinder::~BpHwBinder() mLock.lock(); Vector<Obituary>* obits = mObituaries; - if(obits != NULL) { + if(obits != nullptr) { if (ipc) ipc->clearDeathNotification(mHandle, this); - mObituaries = NULL; + mObituaries = nullptr; } mLock.unlock(); - if (obits != NULL) { + if (obits != nullptr) { // XXX Should we tell any remaining DeathRecipient // objects that the last strong ref has gone away, so they // are no longer linked? diff --git a/BufferedTextOutput.cpp b/BufferedTextOutput.cpp index bee6f1d..3c7db8b 100644 --- a/BufferedTextOutput.cpp +++ b/BufferedTextOutput.cpp @@ -40,7 +40,7 @@ struct BufferedTextOutput::BufferState : public RefBase { explicit BufferState(int32_t _seq) : seq(_seq) - , buffer(NULL) + , buffer(nullptr) , bufferPos(0) , bufferSize(0) , atFront(true) @@ -266,13 +266,13 @@ BufferedTextOutput::BufferState* BufferedTextOutput::getBuffer() const if ((mFlags&MULTITHREADED) != 0) { ThreadState* ts = getThreadState(); if (ts) { - while (ts->states.size() <= (size_t)mIndex) ts->states.add(NULL); + while (ts->states.size() <= (size_t)mIndex) ts->states.add(nullptr); BufferState* bs = ts->states[mIndex].get(); - if (bs != NULL && bs->seq == mSeq) return bs; + if (bs != nullptr && bs->seq == mSeq) return bs; ts->states.editItemAt(mIndex) = new BufferState(mIndex); bs = ts->states[mIndex].get(); - if (bs != NULL) return bs; + if (bs != nullptr) return bs; } } @@ -166,13 +166,13 @@ void printHexData(int32_t indent, const void *buf, size_t length, else if (bytesPerLine >= 8) alignment = 2; else alignment = 1; } - if (func == NULL) func = defaultPrintFunc; + if (func == nullptr) func = defaultPrintFunc; size_t offset; unsigned char *pos = (unsigned char *)buf; - if (pos == NULL) { + if (pos == nullptr) { if (singleLineBytesCutoff < 0) func(cookie, "\n"); func(cookie, "(NULL)"); return; @@ -302,7 +302,7 @@ void printHexData(int32_t indent, const void *buf, size_t length, ssize_t getHWBinderKernelReferences(size_t count, uintptr_t* buf) { sp<ProcessState> proc = ProcessState::selfOrNull(); - if (proc.get() == NULL) { + if (proc.get() == nullptr) { return 0; } diff --git a/IInterface.cpp b/IInterface.cpp index 01866e6..3545325 100644 --- a/IInterface.cpp +++ b/IInterface.cpp @@ -33,14 +33,14 @@ IInterface::~IInterface() { // static sp<IBinder> IInterface::asBinder(const IInterface* iface) { - if (iface == NULL) return NULL; + if (iface == nullptr) return nullptr; return const_cast<IInterface*>(iface)->onAsBinder(); } // static sp<IBinder> IInterface::asBinder(const sp<IInterface>& iface) { - if (iface == NULL) return NULL; + if (iface == nullptr) return nullptr; return iface->onAsBinder(); } diff --git a/IPCThreadState.cpp b/IPCThreadState.cpp index 550dd4f..b275a7e 100644 --- a/IPCThreadState.cpp +++ b/IPCThreadState.cpp @@ -288,7 +288,7 @@ restart: if (gShutdown) { ALOGW("Calling IPCThreadState::self() during shutdown is dangerous, expect a crash.\n"); - return NULL; + return nullptr; } pthread_mutex_lock(&gTLSMutex); @@ -298,7 +298,7 @@ restart: pthread_mutex_unlock(&gTLSMutex); ALOGW("IPCThreadState::self() unable to create TLS key, expect a crash: %s\n", strerror(key_create_value)); - return NULL; + return nullptr; } gHaveTLS = true; } @@ -313,7 +313,7 @@ IPCThreadState* IPCThreadState::selfOrNull() IPCThreadState* st = (IPCThreadState*)pthread_getspecific(k); return st; } - return NULL; + return nullptr; } void IPCThreadState::shutdown() @@ -325,7 +325,7 @@ void IPCThreadState::shutdown() IPCThreadState* st = (IPCThreadState*)pthread_getspecific(gTLS); if (st) { delete st; - pthread_setspecific(gTLS, NULL); + pthread_setspecific(gTLS, nullptr); } pthread_key_delete(gTLS); gHaveTLS = false; @@ -626,7 +626,7 @@ status_t IPCThreadState::transact(int32_t handle, LOG_ONEWAY(">>>> SEND from pid %d uid %d %s", getpid(), getuid(), (flags & TF_ONE_WAY) == 0 ? "READ REPLY" : "ONE WAY"); - err = writeTransactionData(BC_TRANSACTION_SG, flags, handle, code, data, NULL); + err = writeTransactionData(BC_TRANSACTION_SG, flags, handle, code, data, nullptr); if (err != NO_ERROR) { if (reply) reply->setError(err); @@ -662,7 +662,7 @@ status_t IPCThreadState::transact(int32_t handle, else alog << "(none requested)" << endl; } } else { - err = waitForResponse(NULL, NULL); + err = waitForResponse(nullptr, nullptr); } return err; @@ -711,7 +711,7 @@ status_t IPCThreadState::attemptIncStrongHandle(int32_t handle) mOut.writeInt32(handle); status_t result = UNKNOWN_ERROR; - waitForResponse(NULL, &result); + waitForResponse(nullptr, &result); #if LOG_REFCOUNTS printf("IPCThreadState::attemptIncStrongHandle(%ld) = %s\n", @@ -777,7 +777,7 @@ status_t IPCThreadState::sendReply(const Parcel& reply, uint32_t flags) err = writeTransactionData(BC_REPLY_SG, flags, -1, 0, reply, &statusBuffer); if (err < NO_ERROR) return err; - return waitForResponse(NULL, NULL); + return waitForResponse(nullptr, nullptr); } status_t IPCThreadState::waitForResponse(Parcel *reply, status_t *acquireResult) @@ -813,7 +813,7 @@ status_t IPCThreadState::waitForResponse(Parcel *reply, status_t *acquireResult) case BR_ACQUIRE_RESULT: { - ALOG_ASSERT(acquireResult != NULL, "Unexpected brACQUIRE_RESULT"); + ALOG_ASSERT(acquireResult != nullptr, "Unexpected brACQUIRE_RESULT"); const int32_t result = mIn.readInt32(); if (!acquireResult) continue; *acquireResult = result ? NO_ERROR : INVALID_OPERATION; @@ -837,14 +837,14 @@ status_t IPCThreadState::waitForResponse(Parcel *reply, status_t *acquireResult) freeBuffer, this); } else { err = *reinterpret_cast<const status_t*>(tr.data.ptr.buffer); - freeBuffer(NULL, + freeBuffer(nullptr, reinterpret_cast<const uint8_t*>(tr.data.ptr.buffer), tr.data_size, reinterpret_cast<const binder_size_t*>(tr.data.ptr.offsets), tr.offsets_size/sizeof(binder_size_t), this); } } else { - freeBuffer(NULL, + freeBuffer(nullptr, reinterpret_cast<const uint8_t*>(tr.data.ptr.buffer), tr.data_size, reinterpret_cast<const binder_size_t*>(tr.data.ptr.offsets), @@ -1273,8 +1273,8 @@ void IPCThreadState::freeBuffer(Parcel* parcel, const uint8_t* data, IF_LOG_COMMANDS() { alog << "Writing BC_FREE_BUFFER for " << data << endl; } - ALOG_ASSERT(data != NULL, "Called with NULL data"); - if (parcel != NULL) parcel->closeFileDescriptors(); + ALOG_ASSERT(data != nullptr, "Called with NULL data"); + if (parcel != nullptr) parcel->closeFileDescriptors(); IPCThreadState* state = self(); state->mOut.writeInt32(BC_FREE_BUFFER); state->mOut.writePointer((uintptr_t)data); @@ -111,7 +111,7 @@ void acquire_binder_object(const sp<ProcessState>& proc, return; case BINDER_TYPE_HANDLE: { const sp<IBinder> b = proc->getStrongProxyForHandle(obj.handle); - if (b != NULL) { + if (b != nullptr) { LOG_REFS("Parcel %p acquiring reference on remote %p", who, b.get()); b->incStrong(who); } @@ -119,7 +119,7 @@ void acquire_binder_object(const sp<ProcessState>& proc, } case BINDER_TYPE_WEAK_HANDLE: { const wp<IBinder> b = proc->getWeakProxyForHandle(obj.handle); - if (b != NULL) b.get_refs()->incWeak(who); + if (b != nullptr) b.get_refs()->incWeak(who); return; } } @@ -157,7 +157,7 @@ void release_object(const sp<ProcessState>& proc, return; case BINDER_TYPE_HANDLE: { const sp<IBinder> b = proc->getStrongProxyForHandle(obj.handle); - if (b != NULL) { + if (b != nullptr) { LOG_REFS("Parcel %p releasing reference on remote %p", who, b.get()); b->decStrong(who); } @@ -165,7 +165,7 @@ void release_object(const sp<ProcessState>& proc, } case BINDER_TYPE_WEAK_HANDLE: { const wp<IBinder> b = proc->getWeakProxyForHandle(obj.handle); - if (b != NULL) b.get_refs()->decWeak(who); + if (b != nullptr) b.get_refs()->decWeak(who); return; } case BINDER_TYPE_FD: { @@ -198,11 +198,11 @@ status_t flatten_binder(const sp<ProcessState>& /*proc*/, { flat_binder_object obj; - if (binder != NULL) { + if (binder != nullptr) { BHwBinder *local = binder->localBinder(); if (!local) { BpHwBinder *proxy = binder->remoteBinder(); - if (proxy == NULL) { + if (proxy == nullptr) { ALOGE("null proxy"); } const int32_t handle = proxy ? proxy->handle() : 0; @@ -238,13 +238,13 @@ status_t flatten_binder(const sp<ProcessState>& /*proc*/, flat_binder_object obj; obj.flags = 0x7f | FLAT_BINDER_FLAG_ACCEPTS_FDS; - if (binder != NULL) { + if (binder != nullptr) { sp<IBinder> real = binder.promote(); - if (real != NULL) { + if (real != nullptr) { IBinder *local = real->localBinder(); if (!local) { BpHwBinder *proxy = real->remoteBinder(); - if (proxy == NULL) { + if (proxy == nullptr) { ALOGE("null proxy"); } const int32_t handle = proxy ? proxy->handle() : 0; @@ -271,13 +271,13 @@ status_t flatten_binder(const sp<ProcessState>& /*proc*/, obj.hdr.type = BINDER_TYPE_BINDER; obj.binder = 0; obj.cookie = 0; - return finish_flatten_binder(NULL, obj, out); + return finish_flatten_binder(nullptr, obj, out); } else { obj.hdr.type = BINDER_TYPE_BINDER; obj.binder = 0; obj.cookie = 0; - return finish_flatten_binder(NULL, obj, out); + return finish_flatten_binder(nullptr, obj, out); } } @@ -297,7 +297,7 @@ status_t unflatten_binder(const sp<ProcessState>& proc, switch (flat->hdr.type) { case BINDER_TYPE_BINDER: *out = reinterpret_cast<IBinder*>(flat->cookie); - return finish_unflatten_binder(NULL, *flat, in); + return finish_unflatten_binder(nullptr, *flat, in); case BINDER_TYPE_HANDLE: *out = proc->getStrongProxyForHandle(flat->handle); return finish_unflatten_binder( @@ -316,16 +316,16 @@ status_t unflatten_binder(const sp<ProcessState>& proc, switch (flat->hdr.type) { case BINDER_TYPE_BINDER: *out = reinterpret_cast<IBinder*>(flat->cookie); - return finish_unflatten_binder(NULL, *flat, in); + return finish_unflatten_binder(nullptr, *flat, in); case BINDER_TYPE_WEAK_BINDER: if (flat->binder != 0) { out->set_object_and_refs( reinterpret_cast<IBinder*>(flat->cookie), reinterpret_cast<RefBase::weakref_type*>(flat->binder)); } else { - *out = NULL; + *out = nullptr; } - return finish_unflatten_binder(NULL, *flat, in); + return finish_unflatten_binder(nullptr, *flat, in); case BINDER_TYPE_HANDLE: case BINDER_TYPE_WEAK_HANDLE: *out = proc->getWeakProxyForHandle(flat->handle); @@ -566,14 +566,14 @@ void* Parcel::writeInplace(size_t len) if (len > INT32_MAX) { // don't accept size_t values which may have come from an // inadvertent conversion from a negative int. - return NULL; + return nullptr; } const size_t padded = pad_size(len); // sanity check for integer overflow if (mDataPos+padded < mDataPos) { - return NULL; + return nullptr; } if ((mDataPos+padded) <= mDataCapacity) { @@ -604,7 +604,7 @@ restart_write: status_t err = growData(padded); if (err == NO_ERROR) goto restart_write; - return NULL; + return nullptr; } status_t Parcel::writeInt8(int8_t val) @@ -702,7 +702,7 @@ status_t Parcel::writeString16(const String16& str) status_t Parcel::writeString16(const char16_t* str, size_t len) { - if (str == NULL) return writeInt32(-1); + if (str == nullptr) return writeInt32(-1); status_t err = writeInt32(len); if (err == NO_ERROR) { @@ -786,7 +786,7 @@ restart_write: size_t newSize = ((mObjectsSize+2)*3)/2; if (newSize * sizeof(binder_size_t) < mObjectsSize) return NO_MEMORY; // overflow binder_size_t* objects = (binder_size_t*)realloc(mObjects, newSize*sizeof(binder_size_t)); - if (objects == NULL) return NO_MEMORY; + if (objects == nullptr) return NO_MEMORY; mObjects = objects; mObjectsCapacity = newSize; } @@ -1121,7 +1121,7 @@ const void* Parcel::readInplace(size_t len) const if (len > INT32_MAX) { // don't accept size_t values which may have come from an // inadvertent conversion from a negative int. - return NULL; + return nullptr; } if ((mDataPos+pad_size(len)) >= mDataPos && (mDataPos+pad_size(len)) <= mDataSize @@ -1131,7 +1131,7 @@ const void* Parcel::readInplace(size_t len) const ALOGV("readInplace Setting data pos of %p to %zu", this, mDataPos); return data; } - return NULL; + return nullptr; } template<class T> @@ -1333,7 +1333,7 @@ const char* Parcel::readCString() const return str; } } - return NULL; + return nullptr; } String16 Parcel::readString16() const { @@ -1387,12 +1387,12 @@ const char16_t* Parcel::readString16Inplace(size_t* outLen) const if (size >= 0 && size < INT32_MAX) { *outLen = size; const char16_t* str = (const char16_t*)readInplace((size+1)*sizeof(char16_t)); - if (str != NULL) { + if (str != nullptr) { return str; } } *outLen = 0; - return NULL; + return nullptr; } status_t Parcel::readStrongBinder(sp<IBinder>* val) const { @@ -1517,7 +1517,7 @@ const T* Parcel::readObject(size_t *objects_offset) const ALOGW("Attempt to read object from Parcel %p at offset %zu that is not in the object list", this, DPOS); } - return NULL; + return nullptr; } template const flat_binder_object* Parcel::readObject<flat_binder_object>(size_t *objects_offset) const; @@ -2001,7 +2001,7 @@ status_t Parcel::restartWrite(size_t desired) ALOGV("restartWrite Setting data pos of %p to %zu", this, mDataPos); free(mObjects); - mObjects = NULL; + mObjects = nullptr; mObjectsSize = mObjectsCapacity = 0; mNextObjectHint = 0; mHasFds = false; @@ -2050,7 +2050,7 @@ status_t Parcel::continueWrite(size_t desired) mError = NO_MEMORY; return NO_MEMORY; } - binder_size_t* objects = NULL; + binder_size_t* objects = nullptr; if (objectsSize) { objects = (binder_size_t*)calloc(objectsSize, sizeof(binder_size_t)); @@ -2077,7 +2077,7 @@ status_t Parcel::continueWrite(size_t desired) } //ALOGI("Freeing data ref of %p (pid=%d)", this, getpid()); mOwner(this, mData, mDataSize, mObjects, mObjectsSize, mOwnerCookie); - mOwner = NULL; + mOwner = nullptr; LOG_ALLOC("Parcel %p: taking ownership of %zu capacity", this, desired); pthread_mutex_lock(&gParcelGlobalAllocSizeLock); @@ -2153,7 +2153,7 @@ status_t Parcel::continueWrite(size_t desired) return NO_MEMORY; } - if(!(mDataCapacity == 0 && mObjects == NULL + if(!(mDataCapacity == 0 && mObjects == nullptr && mObjectsCapacity == 0)) { ALOGE("continueWrite: %zu/%p/%zu/%zu", mDataCapacity, mObjects, mObjectsCapacity, desired); } @@ -2178,20 +2178,20 @@ void Parcel::initState() { LOG_ALLOC("Parcel %p: initState", this); mError = NO_ERROR; - mData = 0; + mData = nullptr; mDataSize = 0; mDataCapacity = 0; mDataPos = 0; ALOGV("initState Setting data size of %p to %zu", this, mDataSize); ALOGV("initState Setting data pos of %p to %zu", this, mDataPos); - mObjects = NULL; + mObjects = nullptr; mObjectsSize = 0; mObjectsCapacity = 0; mNextObjectHint = 0; mHasFds = false; mFdsKnown = true; mAllowFds = true; - mOwner = NULL; + mOwner = nullptr; clearCache(); mNumRef = 0; diff --git a/ProcessState.cpp b/ProcessState.cpp index 0b32adf..d8fe12c 100644 --- a/ProcessState.cpp +++ b/ProcessState.cpp @@ -68,7 +68,7 @@ protected: sp<ProcessState> ProcessState::self() { Mutex::Autolock _l(gProcessMutex); - if (gProcess != NULL) { + if (gProcess != nullptr) { return gProcess; } gProcess = new ProcessState(DEFAULT_BINDER_VM_SIZE); @@ -82,7 +82,7 @@ sp<ProcessState> ProcessState::selfOrNull() { sp<ProcessState> ProcessState::initWithMmapSize(size_t mmap_size) { Mutex::Autolock _l(gProcessMutex); - if (gProcess != NULL) { + if (gProcess != nullptr) { LOG_ALWAYS_FATAL_IF(mmap_size != gProcess->getMmapSize(), "ProcessState already initialized with a different mmap size."); return gProcess; @@ -112,18 +112,18 @@ sp<IBinder> ProcessState::getContextObject(const String16& name, const sp<IBinde { mLock.lock(); sp<IBinder> object( - mContexts.indexOfKey(name) >= 0 ? mContexts.valueFor(name) : NULL); + mContexts.indexOfKey(name) >= 0 ? mContexts.valueFor(name) : nullptr); mLock.unlock(); //printf("Getting context object %s for %p\n", String8(name).string(), caller.get()); - if (object != NULL) return object; + if (object != nullptr) return object; // Don't attempt to retrieve contexts if we manage them if (mManagesContexts) { ALOGE("getContextObject(%s) failed, but we manage the contexts!\n", String8(name).string()); - return NULL; + return nullptr; } IPCThreadState* ipc = IPCThreadState::self(); @@ -140,7 +140,7 @@ sp<IBinder> ProcessState::getContextObject(const String16& name, const sp<IBinde ipc->flushCommands(); - if (object != NULL) setContextObject(object, name); + if (object != nullptr) setContextObject(object, name); return object; } @@ -172,8 +172,8 @@ bool ProcessState::becomeContextManager(context_check_func checkFunc, void* user if (result == 0) { mManagesContexts = true; } else if (result == -1) { - mBinderContextCheckFunc = NULL; - mBinderContextUserData = NULL; + mBinderContextCheckFunc = nullptr; + mBinderContextUserData = nullptr; ALOGE("Binder ioctl to become context manager failed: %s\n", strerror(errno)); } } @@ -189,7 +189,7 @@ bool ProcessState::becomeContextManager(context_check_func checkFunc, void* user ssize_t ProcessState::getKernelReferences(size_t buf_count, uintptr_t* buf) { binder_node_debug_info info = {}; - uintptr_t* end = buf ? buf + buf_count : NULL; + uintptr_t* end = buf ? buf + buf_count : nullptr; size_t count = 0; do { @@ -217,10 +217,10 @@ ProcessState::handle_entry* ProcessState::lookupHandleLocked(int32_t handle) const size_t N=mHandleToObject.size(); if (N <= (size_t)handle) { handle_entry e; - e.binder = NULL; - e.refs = NULL; + e.binder = nullptr; + e.refs = nullptr; status_t err = mHandleToObject.insertAt(e, N, handle+1-N); - if (err < NO_ERROR) return NULL; + if (err < NO_ERROR) return nullptr; } return &mHandleToObject.editItemAt(handle); } @@ -233,12 +233,12 @@ sp<IBinder> ProcessState::getStrongProxyForHandle(int32_t handle) handle_entry* e = lookupHandleLocked(handle); - if (e != NULL) { + if (e != nullptr) { // We need to create a new BpHwBinder if there isn't currently one, OR we // are unable to acquire a weak reference on this current one. See comment // in getWeakProxyForHandle() for more info about this. IBinder* b = e->binder; - if (b == NULL || !e->refs->attemptIncWeak(this)) { + if (b == nullptr || !e->refs->attemptIncWeak(this)) { b = new BpHwBinder(handle); e->binder = b; if (b) e->refs = b->getWeakRefs(); @@ -263,7 +263,7 @@ wp<IBinder> ProcessState::getWeakProxyForHandle(int32_t handle) handle_entry* e = lookupHandleLocked(handle); - if (e != NULL) { + if (e != nullptr) { // We need to create a new BpHwBinder if there isn't currently one, OR we // are unable to acquire a weak reference on this current one. The // attemptIncWeak() is safe because we know the BpHwBinder destructor will always @@ -272,7 +272,7 @@ wp<IBinder> ProcessState::getWeakProxyForHandle(int32_t handle) // releasing a reference on this BpHwBinder, and a new reference on its handle // arriving from the driver. IBinder* b = e->binder; - if (b == NULL || !e->refs->attemptIncWeak(this)) { + if (b == nullptr || !e->refs->attemptIncWeak(this)) { b = new BpHwBinder(handle); result = b; e->binder = b; @@ -295,7 +295,7 @@ void ProcessState::expungeHandle(int32_t handle, IBinder* binder) // This handle may have already been replaced with a new BpHwBinder // (if someone failed the AttemptIncWeak() above); we don't want // to overwrite it. - if (e && e->binder == binder) e->binder = NULL; + if (e && e->binder == binder) e->binder = nullptr; } String8 ProcessState::makeBinderThreadName() { @@ -381,8 +381,8 @@ ProcessState::ProcessState(size_t mmap_size) , mMaxThreads(DEFAULT_MAX_BINDER_THREADS) , mStarvationStartTimeMs(0) , mManagesContexts(false) - , mBinderContextCheckFunc(NULL) - , mBinderContextUserData(NULL) + , mBinderContextCheckFunc(nullptr) + , mBinderContextUserData(nullptr) , mThreadPoolStarted(false) , mSpawnThreadOnStart(true) , mThreadPoolSeq(1) @@ -390,7 +390,7 @@ ProcessState::ProcessState(size_t mmap_size) { if (mDriverFD >= 0) { // mmap the binder, providing a chunk of virtual address space to receive transactions. - mVMStart = mmap(0, mMmapSize, PROT_READ, MAP_PRIVATE | MAP_NORESERVE, mDriverFD, 0); + mVMStart = mmap(nullptr, mMmapSize, PROT_READ, MAP_PRIVATE | MAP_NORESERVE, mDriverFD, 0); if (mVMStart == MAP_FAILED) { // *sigh* ALOGE("Using /dev/hwbinder failed: unable to mmap transaction memory.\n"); diff --git a/include/hwbinder/Binder.h b/include/hwbinder/Binder.h index 95c909c..02e947f 100644 --- a/include/hwbinder/Binder.h +++ b/include/hwbinder/Binder.h @@ -37,13 +37,13 @@ public: TransactCallback callback = nullptr); virtual status_t linkToDeath(const sp<DeathRecipient>& recipient, - void* cookie = NULL, + void* cookie = nullptr, uint32_t flags = 0); virtual status_t unlinkToDeath( const wp<DeathRecipient>& recipient, - void* cookie = NULL, + void* cookie = nullptr, uint32_t flags = 0, - wp<DeathRecipient>* outRecipient = NULL); + wp<DeathRecipient>* outRecipient = nullptr); virtual void attachObject( const void* objectID, void* object, diff --git a/include/hwbinder/BpHwBinder.h b/include/hwbinder/BpHwBinder.h index dc3073a..59adeb7 100644 --- a/include/hwbinder/BpHwBinder.h +++ b/include/hwbinder/BpHwBinder.h @@ -39,12 +39,12 @@ public: TransactCallback callback = nullptr); virtual status_t linkToDeath(const sp<DeathRecipient>& recipient, - void* cookie = NULL, + void* cookie = nullptr, uint32_t flags = 0); virtual status_t unlinkToDeath( const wp<DeathRecipient>& recipient, - void* cookie = NULL, + void* cookie = nullptr, uint32_t flags = 0, - wp<DeathRecipient>* outRecipient = NULL); + wp<DeathRecipient>* outRecipient = nullptr); virtual void attachObject( const void* objectID, void* object, diff --git a/include/hwbinder/Debug.h b/include/hwbinder/Debug.h index 03127cb..0c173a4 100644 --- a/include/hwbinder/Debug.h +++ b/include/hwbinder/Debug.h @@ -32,12 +32,12 @@ const char* stringForIndent(int32_t indentLevel); typedef void (*debugPrintFunc)(void* cookie, const char* txt); void printTypeCode(uint32_t typeCode, - debugPrintFunc func = 0, void* cookie = 0); + debugPrintFunc func = nullptr, void* cookie = nullptr); void printHexData(int32_t indent, const void *buf, size_t length, size_t bytesPerLine=16, int32_t singleLineBytesCutoff=16, size_t alignment=0, bool cArrayStyle=false, - debugPrintFunc func = 0, void* cookie = 0); + debugPrintFunc func = nullptr, void* cookie = nullptr); ssize_t getHWBinderKernelReferences(size_t count, uintptr_t* buf); diff --git a/include/hwbinder/IBinder.h b/include/hwbinder/IBinder.h index 5648101..5c111c7 100644 --- a/include/hwbinder/IBinder.h +++ b/include/hwbinder/IBinder.h @@ -86,7 +86,7 @@ public: * directly do with it now that it has passed on.) */ virtual status_t linkToDeath(const sp<DeathRecipient>& recipient, - void* cookie = NULL, + void* cookie = nullptr, uint32_t flags = 0) = 0; /** @@ -97,9 +97,9 @@ public: * added with that cookie will be unlinked. */ virtual status_t unlinkToDeath( const wp<DeathRecipient>& recipient, - void* cookie = NULL, + void* cookie = nullptr, uint32_t flags = 0, - wp<DeathRecipient>* outRecipient = NULL) = 0; + wp<DeathRecipient>* outRecipient = nullptr) = 0; virtual bool checkSubclass(const void* subclassID) const; diff --git a/include/hwbinder/IPCThreadState.h b/include/hwbinder/IPCThreadState.h index 2bac1ca..28ae470 100644 --- a/include/hwbinder/IPCThreadState.h +++ b/include/hwbinder/IPCThreadState.h @@ -105,7 +105,7 @@ public: status_t sendReply(const Parcel& reply, uint32_t flags); status_t waitForResponse(Parcel *reply, - status_t *acquireResult=NULL); + status_t *acquireResult=nullptr); status_t talkWithDriver(bool doReceive=true); status_t writeTransactionData(int32_t cmd, uint32_t binderFlags, |