diff options
| author | Chih-Hung Hsieh <chh@google.com> | 2017-08-01 15:35:06 -0700 |
|---|---|---|
| committer | Chih-Hung Hsieh <chh@google.com> | 2017-08-01 15:35:06 -0700 |
| commit | 218b61705049a8e0f901a19725c57bd308ae17b5 (patch) | |
| tree | 075527d285fb15092d42822c4bd91d709e2ec45b | |
| parent | ea5d3f72aa01de436f8e1e5bcdd7748d255285ad (diff) | |
| download | libufdt-o-iot-preview-5.tar.gz | |
Fix misc-macro-parentheses warnings in system/libufdt.android-o-iot-preview-5o-iot-preview-5
Bug: 28705665
Test: make with WITH_TIDY=1 WITH_TIDY_CHECKS=-*,misc-macro-* \
WITH_TIDY_FLAGS=-header-filter=system/libufdt/.*
Change-Id: Idbc766c3fe84f26509ec60b5ca7577ed05739258
| -rw-r--r-- | include/ufdt_types.h | 22 |
1 files changed, 11 insertions, 11 deletions
diff --git a/include/ufdt_types.h b/include/ufdt_types.h index 867e2c7..a019547 100644 --- a/include/ufdt_types.h +++ b/include/ufdt_types.h @@ -20,21 +20,21 @@ #include <libfdt.h> /* it has type : struct ufdt_node** */ -#define for_each(it, node) \ - if ((node) != NULL) \ - for (it = (node)->nodes; it != (node)->nodes + (node)->mem_size; ++it) \ - if (*it) +#define for_each(it, node) \ + if ((node) != NULL) \ + for ((it) = (node)->nodes; (it) != (node)->nodes + (node)->mem_size; ++(it)) \ + if (*(it)) -#define for_each_child(it, node) \ - if (ufdt_node_tag(node) == FDT_BEGIN_NODE) \ - for ((it) = &(((struct ufdt_node_fdt_node *)node)->child); *it; \ - it = &((*it)->sibling)) +#define for_each_child(it, node) \ + if (ufdt_node_tag(node) == FDT_BEGIN_NODE) \ + for ((it) = &(((struct ufdt_node_fdt_node *)(node))->child); *(it); \ + (it) = &((*(it))->sibling)) #define for_each_prop(it, node) \ - for_each_child(it, node) if (ufdt_node_tag(*it) == FDT_PROP) + for_each_child(it, node) if (ufdt_node_tag(*(it)) == FDT_PROP) #define for_each_node(it, node) \ - for_each_child(it, node) if (ufdt_node_tag(*it) == FDT_BEGIN_NODE) + for_each_child(it, node) if (ufdt_node_tag(*(it)) == FDT_BEGIN_NODE) /* * Gets prop name from FDT requires complicated manipulation. @@ -45,7 +45,7 @@ #define ufdt_node_name(node) \ ((ufdt_node_tag(node) == FDT_BEGIN_NODE) \ ? (((const struct fdt_node_header *)((node)->fdt_tag_ptr))->name) \ - : (((const struct ufdt_node_fdt_prop *)node)->name)) + : (((const struct ufdt_node_fdt_prop *)(node))->name)) #define ufdt_node_tag(node) \ ((node) ? fdt32_to_cpu(*(node)->fdt_tag_ptr) : FDT_END) |