aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlex Vakulenko <avakulenko@google.com>2016-01-20 07:53:57 -0800
committerAlex Vakulenko <avakulenko@google.com>2016-01-20 13:43:30 -0800
commitf6a40dfc799c8c896495837689bbe2310b5c422e (patch)
tree8ccc89b2d3ebd1313ed21abba254af7fa35c5d16
parent976e7f6286b3b72e5142586ee01739050715ccb6 (diff)
downloadmetricsd-f6a40dfc799c8c896495837689bbe2310b5c422e.tar.gz
crash_reporter/metricsd: Update libchrome APIs to r369476
The new libchrome has been ported from Chromium and some APIs have changed. Make necessary changes at call sites. Change-Id: I9e45975cdef43913270b82e3fca2c027e614a464
-rw-r--r--collectors/cpu_usage_collector.cc9
-rw-r--r--metrics_collector.cc16
-rw-r--r--metrics_collector_main.cc3
-rw-r--r--uploader/metricsd_service_runner.cc2
4 files changed, 17 insertions, 13 deletions
diff --git a/collectors/cpu_usage_collector.cc b/collectors/cpu_usage_collector.cc
index 05934b4..9b0bb34 100644
--- a/collectors/cpu_usage_collector.cc
+++ b/collectors/cpu_usage_collector.cc
@@ -104,14 +104,15 @@ bool CpuUsageCollector::ParseProcStat(const std::string& stat_content,
uint64_t *user_ticks,
uint64_t *user_nice_ticks,
uint64_t *system_ticks) {
- std::vector<std::string> proc_stat_lines;
- base::SplitString(stat_content, '\n', &proc_stat_lines);
+ std::vector<std::string> proc_stat_lines = base::SplitString(
+ stat_content, "\n", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
if (proc_stat_lines.empty()) {
LOG(WARNING) << "No lines found in " << kMetricsProcStatFileName;
return false;
}
- std::vector<std::string> proc_stat_totals;
- base::SplitStringAlongWhitespace(proc_stat_lines[0], &proc_stat_totals);
+ std::vector<std::string> proc_stat_totals =
+ base::SplitString(proc_stat_lines[0], base::kWhitespaceASCII,
+ base::KEEP_WHITESPACE, base::SPLIT_WANT_NONEMPTY);
if (proc_stat_totals.size() != kMetricsProcStatFirstLineItemsCount ||
proc_stat_totals[0] != "cpu" ||
diff --git a/metrics_collector.cc b/metrics_collector.cc
index 2cf2338..ec7e040 100644
--- a/metrics_collector.cc
+++ b/metrics_collector.cc
@@ -534,18 +534,20 @@ bool MetricsCollector::ProcessMeminfo(const string& meminfo_raw) {
bool MetricsCollector::FillMeminfo(const string& meminfo_raw,
vector<MeminfoRecord>* fields) {
- vector<string> lines;
- unsigned int nlines = Tokenize(meminfo_raw, "\n", &lines);
+ vector<std::string> lines =
+ base::SplitString(meminfo_raw, "\n", base::KEEP_WHITESPACE,
+ base::SPLIT_WANT_NONEMPTY);
// Scan meminfo output and collect field values. Each field name has to
// match a meminfo entry (case insensitive) after removing non-alpha
// characters from the entry.
- unsigned int ifield = 0;
- for (unsigned int iline = 0;
- iline < nlines && ifield < fields->size();
+ size_t ifield = 0;
+ for (size_t iline = 0;
+ iline < lines.size() && ifield < fields->size();
iline++) {
- vector<string> tokens;
- Tokenize(lines[iline], ": ", &tokens);
+ vector<string> tokens =
+ base::SplitString(lines[iline], ": ", base::KEEP_WHITESPACE,
+ base::SPLIT_WANT_NONEMPTY);
if (strcmp((*fields)[ifield].match, tokens[0].c_str()) == 0) {
// Name matches. Parse value and save.
if (!base::StringToInt(tokens[1], &(*fields)[ifield].value)) {
diff --git a/metrics_collector_main.cc b/metrics_collector_main.cc
index d7aaaf5..14bb935 100644
--- a/metrics_collector_main.cc
+++ b/metrics_collector_main.cc
@@ -41,7 +41,8 @@ const std::string MetricsMainDiskStatsPath() {
}
dev_path = dev_path_cstr;
// Check that rootdev begins with "/dev/block/".
- if (!base::StartsWithASCII(dev_path, dev_prefix, false)) {
+ if (!base::StartsWith(dev_path, dev_prefix,
+ base::CompareCase::INSENSITIVE_ASCII)) {
LOG(WARNING) << "unexpected root device " << dev_path;
return "";
}
diff --git a/uploader/metricsd_service_runner.cc b/uploader/metricsd_service_runner.cc
index 2834977..5a759d3 100644
--- a/uploader/metricsd_service_runner.cc
+++ b/uploader/metricsd_service_runner.cc
@@ -54,7 +54,7 @@ void MetricsdServiceRunner::Run() {
void MetricsdServiceRunner::Stop() {
message_loop_for_io_->PostTask(FROM_HERE,
- message_loop_for_io_->QuitClosure());
+ message_loop_for_io_->QuitWhenIdleClosure());
thread_->join();
}