summaryrefslogtreecommitdiff
path: root/Android.bp
AgeCommit message (Collapse)Author
2022-06-15move XtBpfProgLocations.h into a new header libraryMaciej Żenczykowski
Bug: 235778483 Test: TreeHugger Signed-off-by: Maciej Żenczykowski <maze@google.com> Change-Id: I6ad0a12ff14331809cbca97043bc5d5c9f8742b8
2022-06-14move definition of xt_bpf program pin locations to system/netdMaciej Żenczykowski
As this ends up built in to the netd binary, and should thus not be pulling in mainline (and thus mutable) header files. We could technically export the path out of the netd_updatable.so, but there is no benefit to doing so. This is because the pin directory is determined by selinux access having to make these available to netd & iptables (netdutils_wrappers), and the entire structure of the iptables setup (ie. chains, etc) is already entirely left up to netd. Thus the only meaningful thing mainline could do here is rename the programs (while maintaining their behaviour) but that provides absolutely no value. (If the programs are missing, then bandwidth accounting fails, and there is no way to add additional programs) Bug: 235778483 Test: TreeHugger Signed-off-by: Maciej Żenczykowski <maze@google.com> Change-Id: I3c235d63b3695deb04564bb929913a9050b9fc10
2022-04-27Use tidy_checks_as_errors not -warnings-as-errorsChih-Hung Hsieh
The flag -warnings-as-errors embedded in tidy_flags is difficult to process and error-prone. They should be replaced with the new tidy_checks_as_errors list. Bug: 229801437 Test: make tidy-system-netd Change-Id: I37cace79dbbfddc8156dd7140f71a02e4ed5fb5e
2022-04-06Delete unnecessary apex_available for com.android.tetheringKen Chen
Files in netd that are directly referenced by tethering module have been moved into the module. Test: m; flash Change-Id: I22fbc735c5272f3d34d1c629e1e5ddf48f04d1a5
2021-06-23Revert "[clang-tidy] Disable performance-no-int-to-ptr"Bernie Innocenti
This reverts commit 6f528dd01fc5e80a6590ef729ed9302b11fa7fb6. Reason for revert: errors fixed in DnsResolver commit bc7d6c0 Change-Id: Ieb2b4d6f4fc1e9967b4d37c0b0afc4ae43780006
2021-03-17[clang-tidy] Disable performance-no-int-to-ptrPirama Arumuga Nainar
Bug: http://b/182416023 This warning is added by new clang update (clang-r416183). packages/modules/DnsResolver/gethnamaddr.cpp:367:10: error: integer to pointer cast pessimizes optimization opportunities [performance-no-int-to-ptr,-warnings-as-errors] bp = (char*) ALIGN(bp); packages/modules/DnsResolver/sethostent.cpp:124:19: error: integer to pointer cast pessimizes optimization opportunities [performance-no-int-to-ptr,-warnings-as-errors] ptr = (char*) ALIGN(ptr); Test: Build with clang-r416183 and verify build. Change-Id: I6de904acabee1ddd8a9741f793458433a1bc0041
2021-02-17Merge "Ignore a few tidy checks which cause warnings"android-s-preview-1Chih-hung Hsieh
2021-02-16Ignore a few tidy checks which cause warningsChih-Hung Hsieh
* A bug in tidy check header filter was fixed and revealed many tidy check warnings in .h files. Allow these warnings until they are all fixed in .h files. Test: mm with new header filter bug fixes Change-Id: I003ead59ad204c5b8d6979de34747c610bb28198
2021-02-12[LSC] Add LOCAL_LICENSE_KINDS to system/netdBob Badour
Added SPDX-license-identifier-Apache-2.0 to: Android.bp bpf_progs/Android.bp client/Android.bp libnetdbpf/Android.bp libnetdutils/Android.bp netutils_wrappers/Android.bp server/Android.bp tests/Android.bp tests/benchmarks/Android.bp Bug: 68860345 Bug: 151177513 Bug: 151953481 Test: m all Exempt-From-Owner-Approval: janitorial work Change-Id: Ie250cbab6e287585b945160cba4c2a764778ebc4
2020-11-27Add apex_available to libnetd_clientRemi NGUYEN VAN
Add apex_available to libnetd_client, so it can be used by framework JNI code that is in the process of moving to the connectivity (tethering) APEX. Bug: 171540887 Test: m (APEX builds with additional dependencies added) Change-Id: Iebfa4f741e81357e2d6e4ec197294575999f9a6c
2020-05-30Seperate header target for DnsResolver from libnetd_client_headerLuke Huang
0. Move NETID_USE_LOCAL_NAMESERVERS definition to DnsResolver 1. Create libnetdbinder_utils shared to DnsResolver 2. Use dnsproxyd_protocol_headers for NETID_USE_LOCAL_NAMESERVERS Bug: 151895202 Test: build Change-Id: I5315f5214bc7cd399e878b96a06f486dc8e4b874 Merged-In: I5315f5214bc7cd399e878b96a06f486dc8e4b874
2020-05-02Set min_sdk_version to be part of mainline modulesJooyung Han
Modules contributing mainline modules (APK/APEX) should set min_sdk_version as well as apex_available. For now setting min_sdk_version doesn't change build outputs. But build-time checks will be added soon. Bug: 152655956 Test: m Change-Id: I92c78b0930a14f2f5830d6f0873996c17d4ee44b
2020-04-30enable warnings as errors more selectivelyMaciej Żenczykowski
-warnings-as-errors=* causes problems on rvc-release special targets: {cf_x86_phone,taimen}_analyzer-userdebug Turns off: /buildbot/src/googleplex-android/rvc-release/system/netd/server/BandwidthController.cpp:817:13: error: use !absl::StartsWith instead of find() != 0 [abseil-string-find-startswith,-warnings-as-errors] if (rule.find(NEW_CHAIN_COMMAND) != 0) continue; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ !absl::StartsWith(rule, NEW_CHAIN_COMMAND) /buildbot/src/googleplex-android/rvc-release/system/netd/server/BandwidthController.cpp:821:13: error: use !absl::StartsWith instead of find() != 0 [abseil-string-find-startswith,-warnings-as-errors] if (chainName.find("bw_costly_") != 0 || chainName == std::string("bw_costly_shared")) { ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ !absl::StartsWith(chainName, "bw_costly_") Test: builds Bug: 153035880 Signed-off-by: Maciej Żenczykowski <maze@google.com> Change-Id: Iede66c4016b450100abb82590fba6f1dfcd3bb2f
2020-04-28enable warnings as errors - for realMaciej Żenczykowski
experimentation shows that '*' does not match bugprone-narrowing-conversions while * does. This is proof the single quotes were all erroneous. Test: builds Bug: 153035880 Signed-off-by: Maciej Żenczykowski <maze@google.com> Change-Id: I51727deef594760cf6aeb404d54bb02a3d7c77cf
2020-04-24enable bugprone warnings as errorsMaciej Żenczykowski
Test: builds Bug: 153035880 Signed-off-by: Maciej Żenczykowski <maze@google.com> Change-Id: Iaf41109cd1a0cc4a6b4f09d77579c568627e8c6e
2020-04-08Set apex_available propertyJiyong Park
The marked library(ies) were available to the APEXes via the hand-written whitelist in build/soong/apex/apex.go. Trying to remove the whitelist by adding apex_available property to the Android.bp of the libraries. Bug: 150999716 Test: m Change-Id: I274feb4542624b348999e7c5f189f8606c6cd63d
2019-11-07Enable C++20 for netdBernie Innocenti
This is mainly so we can use safer buffer management constructs built around std::span and std::ranges, along with other goodies such as std::expected. C++20 is not yet finalized, but we're not planning to use any advanced features at this stage. Change-Id: I8e880a010422ac705824fb8b7e519b8a76802a5d
2019-10-30Enable pedantic checks for uninitialized variablesBernie Innocenti
The -Wsometimes-uninitialized and -Wconditional-uninitialized flags are not enabled with -Wall because they lead to some false positives. However, these have become exceedingly rare. I found only two such cases in the netd codebase and a single one in DnsResolver. Access to uninitialzied memory is one of the nastiest forms of undefined behavior in C, it's time to eradicate it. Change-Id: Iea5cf450e0e3c1f2443c06b1fac670290abe2e64
2019-02-22make libjsoncpp be imported by only netdJeongik Cha
netd_benchmark doesn't use log feature of aidl. but because it statically imports aidl_interface(that turns on genlog), it should import libjsoncpp. when the patch in aidl is applied, it doesn't need to import libjsoncpp in the case that module statically imports it. so remove libjson import in netd_default, and add it into only netd https://android-review.googlesource.com/c/platform/system/tools/aidl/+/909474 https://android-review.googlesource.com/c/platform/system/netd/+/853730/11/Android.bp#35 Bug: 124871490 Test: system/netd/tests/runtests.sh Change-Id: Ibdc14fcc339134c9e22d074fa676f00729257f04
2019-02-16Apply the automatic logging feature to Netd native service.Xiao Ma
- register the log callback generated from AIDL - remove previous gLog methods The log sample captured from "adb shell dumpsys netd" shown as below: ''' 02-11 20:00:24.516 isAlive() -> (true) <0ms> 02-11 20:00:24.527 firewallReplaceUidChain(fw_standby, false) -> (true) <0ms> 02-11 20:00:40.256 setResolverConfiguration(100, 64, 2001:4860:4860::8888, null) <0ms> 02-11 20:00:40.285 networkAddRoute(2401:fa00:4:fd00::/64, wlan0, 100, null) <0ms> ''' Test: system/netd/tests/runtests.sh Change-Id: Ic10f8cfd8b15b739a4af4eb9f5b6ed9c5e3a201e
2019-02-01Enable more clang-tidy checks and treat them as errorsBernie Innocenti
Test: tests/runtests.sh Change-Id: If59480cee6460847f5c1cef17e3ef036b8e75651
2019-01-15Remove sscanf() in TetherController.waynema
Test: netd_unit_test, netd_integration_test, libnetd_resolv_test Change-Id: Ibff2d6cc5dbf4fb09fcd1862be1b71be3b1d9f8e
2019-01-08Enable -Wsign-compare for netd and fix warningsBernie Innocenti
Test: atest netd_unit_test netd_integration_test resolv_integration_test Change-Id: I84347de8f3a3ec0dcc8979037b9c265d145a35f7
2018-12-06Add type cast to fix build error with "-Wsign-compare" cflag.Sehee Park
There is build error if "-Wsign-compare" is defined in cflags. Also add "-Wsign-compare" to Android.bp Test: Build Change-Id: If41da96ec521a0d2dcddf660e7effa218c99810d Signed-off-by: Sehee Park <sehee32.park@samsung.com>
2018-12-03C++17 is the default now.Elliott Hughes
Test: builds Change-Id: I7386923e0a6c8307b3605a485b27c567c24e9e19
2018-10-18Disable some noisy clang_tidy warningsBernie Innocenti
Only disabling warning categories that are unlikely to be acted upon soon and hide other relevant warnings. Test: m netd Change-Id: I2b159bb44fe75644202a9ba8c2c47ec062112931
2018-10-12Turn implicit fallthrow warnings into errorsBernie Innocenti
Test: m netd ndc bpfloader libnetd_client netd_integration_test netd_unit_test netd_benchmark Change-Id: Ie607ab784fd6470d7dc7654b07f33f7f5b943118
2018-09-07Build netd with a built-in resolver libraryBernie Innocenti
Test: atest netd_unit_test netd_integration_test Change-Id: Ied9f5b1328918793521a8d6f82afdfc6481fd545
2018-07-06netd: complete the conversion to Soong \o/Bernie Innocenti
Test: m netd ndc netd_unit_test netd_integration_test Test: system/netd/tests/runtests.sh (no increase in failures) Change-Id: Ic86f0bd03fcbf8c501923b9309a0376185633a91
2018-07-04Switch netd_defaults to C++17Erik Kline
Additionally: - use netd_defaults everywhere (except libbpf) - a few clang-format and clang-tidy inspired fixes - runtests.sh now tries to run "adb root" - runtests.sh now can be used to run the benchmarks Test: as follows - built, flashed, booted - system/netd/tests/runtests.sh passes Change-Id: Ifbfada63cf4e541c55f51396f618fff389d664a5
2018-06-11netutils_wrappers: Convert build to Android.bpBernie Innocenti
Test: m showcommands netutils_wrapper_test Change-Id: I2ab241da14ddd5966e796d3382ab3f6791186644
2017-03-14Convert NetdClient to use SoongRobin Lee
Android.mk => Android.bp This makes loading netd_client into other Soong modules easier. Bug: 33159037 Test: make clean && make full -j30 Change-Id: I86f18c51faeacf43f6e8ba965a8b1f76e4594ebc
generated by cgit v1.2.3 (git 2.25.1) at 2024-05-22 06:49:45 +0000