aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDevin Moore <devinmoore@google.com>2023-02-03 02:16:18 +0000
committerDevin Moore <devinmoore@google.com>2023-02-06 16:17:06 +0000
commit5f77e3f767624ba8c2090af8e12331adf6619132 (patch)
treeb9fe8ac1481b34e2b3980fb01452608dd1bb2455
parent434cb410c4243a8fc18d0ba0b41276794bb53967 (diff)
downloadaidl-5f77e3f767624ba8c2090af8e12331adf6619132.tar.gz
Add comment about @SensitiveData and backwards compatibility
Test: m Bug: none Change-Id: I867cafd9738715e2be6c08b7859aa36797aee7de
-rw-r--r--aidl_checkapi.cpp6
1 files changed, 6 insertions, 0 deletions
diff --git a/aidl_checkapi.cpp b/aidl_checkapi.cpp
index 584e5a66..039c01b3 100644
--- a/aidl_checkapi.cpp
+++ b/aidl_checkapi.cpp
@@ -74,6 +74,12 @@ static vector<string> get_strict_annotations(const AidlAnnotatable& node) {
// - a new implementation might change so that it no longer returns null
// values (remove @nullable)
// - a new implementation might start accepting null values (add @nullable)
+ //
+ // AidlAnnotation::Type::SENSITIVE_DATA could be ignored for backwards
+ // compatibility, but is not. It should retroactively be applied to the
+ // older versions of the interface. When doing that, we need
+ // to add the new hash to the older versions after the change using
+ // tools/aidl/build/hash_gen.sh.
static const set<AidlAnnotation::Type> kIgnoreAnnotations{
AidlAnnotation::Type::NULLABLE,
// @JavaDerive doesn't affect read/write