aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThiƩbaud Weksteen <tweek@google.com>2022-05-25 14:39:04 +1000
committerThiƩbaud Weksteen <tweek@google.com>2022-05-25 14:39:04 +1000
commita9f7f2a72553d1f3f465262daf1154a93bd174ce (patch)
tree07f218e39bd865ec2b0f06f61568ea8a9811d426
parent97c7069b4f15bbb43d85b687e0d1893f743c99e8 (diff)
downloadaidl-a9f7f2a72553d1f3f465262daf1154a93bd174ce.tar.gz
Use IsPermissionAnnotated in diagnostics
Test: atest --host aidl_unittests Change-Id: I994edfcb05bbc501f76936dd8cd26809e6b2a7dd
-rw-r--r--diagnostics.cpp5
1 files changed, 2 insertions, 3 deletions
diff --git a/diagnostics.cpp b/diagnostics.cpp
index 0eca8ae1..d3f04b5b 100644
--- a/diagnostics.cpp
+++ b/diagnostics.cpp
@@ -307,7 +307,7 @@ struct DiagnosePermissionAnnotations : DiagnosticsVisitor {
"required using @EnforcePermission. If permissions are manually "
"verified within the implementation, use @PermissionManuallyEnforced. "
"If no permissions are required, use @RequiresNoPermission.";
- if (intf.EnforceExpression() || intf.IsPermissionManual() || intf.IsPermissionNone()) {
+ if (intf.IsPermissionAnnotated()) {
return;
}
const auto& methods = intf.GetMethods();
@@ -317,8 +317,7 @@ struct DiagnosePermissionAnnotations : DiagnosticsVisitor {
auto& m = methods[i];
if (!m->IsUserDefined()) continue;
num_user_defined_methods++;
- if (m->GetType().EnforceExpression() || m->GetType().IsPermissionManual() ||
- m->GetType().IsPermissionNone()) {
+ if (m->GetType().IsPermissionAnnotated()) {
continue;
}
methods_without_annotations.push_back(i);