aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
10 daysAdd tests for FixedSize parcelable and union layoutsHEADmastermainAyrton Munoz
This commit adds new tests for empty parcelables, parcelables containing arrays of parcelables/unions and unions with varying amounts of padding for the tags. Follow-up CLs will add static assertions to ensure that the memory layout in the NDK and rust backends match what we expect. Bug: 294698705 Test: m aidl_integration_test Change-Id: If4c26cbdc822ea2bf2b8d09384ea00cf312d7505
11 daysAdd arrays to FixedSize parcelable and union testsAyrton Munoz
Change-Id: I4eb6760d8aaec9d5b0a784d230ef90d32957c3bd Test: m aidl_integration_tests
2024-04-02Update needed for Rust v1.77.1Charisee
error: useless use of `vec!` --> system/tools/aidl/tests/rust/test_client.rs:420:17 | 420 | let input = vec![ | _________________^ 421 | | binder::ParcelFileDescriptor::new(read_fd), 422 | | binder::ParcelFileDescriptor::new(write_fd), 423 | | ]; | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec = note: `-D clippy::useless-vec` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::useless_vec)]` help: you can use an array directly | 420 ~ let input = [binder::ParcelFileDescriptor::new(read_fd), 421 ~ binder::ParcelFileDescriptor::new(write_fd)]; | error: aborting due to 1 previous error Bug: 330185853 ./test_compiler.py --prebuilt-path dist/rust-dev.tar.xz --target aosp_cf_x86_64_phone --image Test: m rust Change-Id: I4f18e6741370a054cf928cf1dfdefe5d1773c2e1
2024-02-21Drop platform_apis from the internal java_library of aidl_interface am: ↵Spandan Das
4cb72e21e9 Original change: https://android-review.googlesource.com/c/platform/system/tools/aidl/+/2969115 Change-Id: Iad77e70bee3563b687170f21689dbb9f8146adb3 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-02-21Drop platform_apis from the internal java_library of aidl_interfaceSpandan Das
platform_apis is a no-op for java_library module type. Drop this property from the java_library dynamically created by aidl_interface Test: m nothing Bug: 215379393 Change-Id: Ia6b5defe78d475eb5f48825a3b26465afc64fe69
2024-02-17Fix implicit narrowing conversion in generated C++ code am: d737c3ed06Cody Heiner
Original change: https://android-review.googlesource.com/c/platform/system/tools/aidl/+/2964190 Change-Id: I2aed0c1931abbd5cbc3606f26fcab01cb3a73c32 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-02-15Fix implicit narrowing conversion in generated C++ codeCody Heiner
Also updates `auto` types to explicit types in order to improve readability and make it clear how and why different integral types are being used. Note: the only manual change here is the change to `generate_cpp.cpp`. The rest of the changes were produced by running: `system/tools/aidl/tests/golden_test.sh update` Test: build succeeds when generating code within a library that uses -Wall -Werror flags (where it failed before this change). Test: device runs normally. Change-Id: I704e3322318d2fe327320b50519de1acbefc33f9
2024-02-12Add a missing include am: 03d191d6c9Yurii Zubrytskyi
Original change: https://android-review.googlesource.com/c/platform/system/tools/aidl/+/2957315 Change-Id: Ib205b5f5e4a3b9da54084f8d6b17aafe2d23a4d7 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-02-10Add a missing includeYurii Zubrytskyi
Change-Id: Ic74b23340c7650aa7addf6e634f661a1104fe659
2024-02-09Reland "AIDL: Rust by default." am: 3da33aa4ccSteven Moreland
Original change: https://android-review.googlesource.com/c/platform/system/tools/aidl/+/2955257 Change-Id: Iebec5ff3b3bc70dea7ea90b7a9d77bd6b2a443b0 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-02-09Reland "AIDL: Rust by default."Steven Moreland
This reverts commit c3a78bb439e78a62f313774f4662e52535dc91ec. Reason for revert: b/321267339 Change-Id: I5072c9beedb7f9063601162caf823d3da3c93a0e
2024-02-09Add --all to record_binder am: 2eed130607Pawan Wagh
Original change: https://android-review.googlesource.com/c/platform/system/tools/aidl/+/2955617 Change-Id: I0b59bb6d3218082bd5c68b40060d68ea74d98652 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-02-09Add --all to record_binderPawan Wagh
Adding --all argument to start and stop commands. This will start recording all the binders which are listed with defaultServiceManager Test: record_binder start --all Test: record_binder stop --all Bug: 295220956 Change-Id: I5b0e754fa26bf2a89693f599eef121b8929b3755
2024-02-08Revert "AIDL: Rust by default." am: c3a78bb439Yunyun Lin
Original change: https://android-review.googlesource.com/c/platform/system/tools/aidl/+/2956572 Change-Id: I8304c4be6eff5fecd2448751baaf75fa61f8b5af Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-02-08Revert "AIDL: Rust by default."Yunyun Lin
This reverts commit a146ff104d780ece54394e786e871d71c0c6eda7. Reason for revert: Broken build 11426446 on aosp-main on aosp_arm64-trunk_food-userdebug b/324465367 Change-Id: I13d39471229e3ed176114248444031aaf449815d
2024-02-08AIDL: Rust by default. am: a146ff104dSteven Moreland
Original change: https://android-review.googlesource.com/c/platform/system/tools/aidl/+/2933188 Change-Id: I2f6797602122978b532e1f1f49f54030e11b9ee4 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-02-08AIDL: Rust by default.Steven Moreland
Catch interface compatibility risks earlier. Bug: 321267339 Test: m $(allmod | grep "rust" | grep -vP "vendor|_32|Vanilla|silver") Change-Id: I99a8bfcdc0089912039b7b37815b0cf2df70f5c6
2024-02-01Allow for unsigned int and unsigned long constants (u32, u64) am: f6fb8419b1Elie Kheirallah
Original change: https://android-review.googlesource.com/c/platform/system/tools/aidl/+/2929038 Change-Id: Ibfbaa6dee064db20ec157ad7ee044b1d52af3a8e Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-02-01Allow for unsigned int and unsigned long constants (u32, u64)Elie Kheirallah
Add support for u32/u64 const expressions. Bug: 225239875 Test: aidl_unittests Change-Id: I39b426ec927b5dc7a41112d3583d35d72f43f994
2024-01-25Revert "Use Option for unstructured parcelables." am: a748faddd9Andrew Walbran
Original change: https://android-review.googlesource.com/c/platform/system/tools/aidl/+/2827693 Change-Id: Ie5e76033a656ad69af4c4e0a567c6d0674e5fdf0 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-01-23Revert "Use Option for unstructured parcelables."Andrew Walbran
This reverts commit d99990df7e44f3bb96d286f32457476697b0b02e. Test: atest aidl_integration_test Change-Id: I5d9b88ae39d534857e18db58ebf4399c1f58a028
2024-01-22Don't use lazy_static to create Mutex am: 7a24b135c2Luca Stefani
Original change: https://android-review.googlesource.com/c/platform/system/tools/aidl/+/2911604 Change-Id: I0a9fa28e4eb62f266e3657e7b78fe583a216228c Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-01-22Don't use lazy_static to create MutexLuca Stefani
Since rust 1.63 Mutex::new is const. The underlying data type is wrapped with Option so we can drop the need to lazy static init the mutex. Test: aidl_unittests Change-Id: Iae0c4f71e1a1d1e75cffef5f075bac78c9bd3e49
2024-01-17Implement UnstructuredParcelable and use macros. am: a0aec5d84bAndrew Walbran
Original change: https://android-review.googlesource.com/c/platform/system/tools/aidl/+/2906777 Change-Id: Iad1d981895d689033c4c290d851676a3b590f286 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-01-17Implement UnstructuredParcelable and use macros.Andrew Walbran
This saves a bunch of code duplication. Bug: 303064346 Test: atest aidl_integration_test Change-Id: Iedf51331a7b3887481fdcdaf7cdd926ee7b130ef
2024-01-16Fix cert-dcl50-cpp tidy warnings am: 65634abf08 am: ccc36aa01e am: 56364b5986JaeMan Park
Original change: https://android-review.googlesource.com/c/platform/system/tools/aidl/+/2897507 Change-Id: Iae2e3ba04d35093a3b88dd992c4fe3b733861617 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-01-16Fix cert-dcl50-cpp tidy warnings am: 65634abf08 am: ccc36aa01eJaeMan Park
Original change: https://android-review.googlesource.com/c/platform/system/tools/aidl/+/2897507 Change-Id: I6a0dbaaeab124b397c3353092387eac91bb52422 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-01-16Fix cert-dcl50-cpp tidy warnings am: 65634abf08JaeMan Park
Original change: https://android-review.googlesource.com/c/platform/system/tools/aidl/+/2897507 Change-Id: I29c0b70bb94b6bd904f77f11e67e181d976801d9 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-01-16Fix cert-dcl50-cpp tidy warningsJaeMan Park
cert-dcl50-cpp warns for c-style variadic function usage. Bug: 162909698 Test: `ALLOW_LOCAL_TIDY_TRUE=1 m aidl` does not shows tidy warnings Change-Id: I21e8a2525c73e38a70baf24cd8cdfaaef5b49547
2024-01-10Don't print char16_t to a stream am: 644fa15e7b am: a133e8135c am: 73bd9b1f6fTomasz Wasilczyk
Original change: https://android-review.googlesource.com/c/platform/system/tools/aidl/+/2903109 Change-Id: Ie3fe8f51fb239660b81163f0cca70731871e7fa9 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-01-10Don't print char16_t to a stream am: 644fa15e7b am: a133e8135cTomasz Wasilczyk
Original change: https://android-review.googlesource.com/c/platform/system/tools/aidl/+/2903109 Change-Id: I8c95285d99cb3a0e3501ed3a1a7b94d830f45950 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-01-10Don't print char16_t to a stream am: 644fa15e7bTomasz Wasilczyk
Original change: https://android-review.googlesource.com/c/platform/system/tools/aidl/+/2903109 Change-Id: I9380f39b982c908b0a6c70650988399605451b7a Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-01-09Don't print char16_t to a streamTomasz Wasilczyk
It's removed from recent libc++ Bug: 175635923 Test: m MODULES-IN-system-tools-aidl Change-Id: I9fa6c24873a81e0670f922be4494bc81c8071c1a
2024-01-05Remove TestVndkRequiresFrozen test am: c17fcbd388 am: f3e2013210 am: 0b80feec5aKiyoung Kim
Original change: https://android-review.googlesource.com/c/platform/system/tools/aidl/+/2896800 Change-Id: I4d2a64532d4501ab05e400676f9284d5574bdafd Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-01-05Remove TestVndkRequiresFrozen test am: c17fcbd388 am: f3e2013210Kiyoung Kim
Original change: https://android-review.googlesource.com/c/platform/system/tools/aidl/+/2896800 Change-Id: I80632c3dac8d280a361ca0c0ace508496c8f2530 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-01-05Remove TestVndkRequiresFrozen test am: c17fcbd388Kiyoung Kim
Original change: https://android-review.googlesource.com/c/platform/system/tools/aidl/+/2896800 Change-Id: Ieb1c120285b0f8a75e7b659b6da326ed145f50ca Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-01-05Remove TestVndkRequiresFrozen testKiyoung Kim
TestVndkRequiresFrozen test was introduced to test frozen flag within VNDK enabled aidl_interface, but this test was running on unexpected environment, because device vndk version and platform vndk version was not set. This makes test fail when build system is updated with VNDK deprecation. As this test is no longer required with VNDK deprecation, it would be better to remove test rather than fix the problem. This change removes TestVndkRequiresFrozen from AIDL tests. Bug: 316829758 Test: m nothing --no-skip-soong-tests passed Change-Id: I79ab29949cdc6e4df4ac3c20e4749f74ea6ce95e
2024-01-04always_allow_unfrozen am: 5c3d46d304 am: aa38b59585 am: a321d69f90Steven Moreland
Original change: https://android-review.googlesource.com/c/platform/system/tools/aidl/+/2889272 Change-Id: I0d5206cad65709eeb118eb936b4506564f94a6ec Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-01-04always_allow_unfrozen am: 5c3d46d304 am: aa38b59585Steven Moreland
Original change: https://android-review.googlesource.com/c/platform/system/tools/aidl/+/2889272 Change-Id: Icedc939daf008dd9129fccce2fdc8b7226479b5f Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-01-04always_allow_unfrozen am: 5c3d46d304Steven Moreland
Original change: https://android-review.googlesource.com/c/platform/system/tools/aidl/+/2889272 Change-Id: I1dc960b958ccd3452dd5ca41e9d0e44ad5d41811 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-01-04always_allow_unfrozenSteven Moreland
Add a way to allow unfrozen interfaces, even when RELEASE_AIDL_USE_UNFROZEN is set. This will avoid the build check and behavior changes, but there would still be an associated failure in vts_treble_vintf_vendor_test. Still, this is requested by some partners and teams to ease the development process. Bug: 317387425 Test: added in CL (as soong build test) Test: libaidlmetadata_test Change-Id: I85532c719972cc971e7a595f118ba4acc9b24ba9
2024-01-03AIDL: allow '_' in int/hex const exprs am: 26b26f481c am: 226a0666a5 am: ↵Steven Moreland
ca31ec642b Original change: https://android-review.googlesource.com/c/platform/system/tools/aidl/+/2891692 Change-Id: I981f9f51d5306ae01163f07a9d4b17818e0f3313 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-01-03AIDL: allow '_' in int/hex const exprs am: 26b26f481c am: 226a0666a5Steven Moreland
Original change: https://android-review.googlesource.com/c/platform/system/tools/aidl/+/2891692 Change-Id: Icd0832d38ec7c0cca4db1a61c6f5dd7dc8c34ecf Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-01-03AIDL: allow '_' in int/hex const exprs am: 26b26f481cSteven Moreland
Original change: https://android-review.googlesource.com/c/platform/system/tools/aidl/+/2891692 Change-Id: I016a8f034b08f00995de5dd41009ad78a536580c Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-01-03AIDL: allow '_' in int/hex const exprsSteven Moreland
const int foo = 9_001; stay readable out there! Fixes: 262690732 Test: aidl_unittests + aidl_integration_test (added) Change-Id: I631e4f4c99937ce2e5d7976474d26268524e03a7
2024-01-03aidl: retain comments after annotations am: 2d32abc343 am: adbdd46a81 am: ↵Steven Moreland
f7c4d2afa8 Original change: https://android-review.googlesource.com/c/platform/system/tools/aidl/+/2889794 Change-Id: Ibaa5469f577b9a505ae889780c086a0034c52701 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-01-03aidl: retain comments after annotations am: 2d32abc343 am: adbdd46a81Steven Moreland
Original change: https://android-review.googlesource.com/c/platform/system/tools/aidl/+/2889794 Change-Id: I1f10508300d4a50ed6f0e07dcde825eda9d69eca Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-01-03aidl: retain comments after annotations am: 2d32abc343Steven Moreland
Original change: https://android-review.googlesource.com/c/platform/system/tools/aidl/+/2889794 Change-Id: Id992d35210eabdd3e3111d9ab29af5fa470f08a0 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-01-03aidl: retain comments after annotationsSteven Moreland
AIDL was dropping comments between annotations and type definitions. I've also left a few notes in the code about related issues for consideration for future work when people touch the code here. Fixes: 316956996 Test: aidl_unittests Change-Id: I1715fb8d9a48929fc9086db4a26a0d559698c379
2023-12-21suppress JDK 21 'this-escape' warning am: 100544f1dc am: 90ddc5733c am: ↵Steven Moreland
2b6f80612a Original change: https://android-review.googlesource.com/c/platform/system/tools/aidl/+/2886453 Change-Id: I1744c04083b87bc771785773cd0f6b76de4179f9 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-05-06 18:36:56 +0000