diff options
author | Jean-Baptiste Queru <jbq@google.com> | 2013-07-02 12:34:35 -0700 |
---|---|---|
committer | Android Git Automerger <android-git-automerger@android.com> | 2013-07-02 12:34:35 -0700 |
commit | 5d09126ad1cd10c74e676fb158f1d057a37180b2 (patch) | |
tree | 3c69249c4a7bea5def8b0c9b24576b3dbf72cca2 | |
parent | 0002a85f8b94d96b9b86819bd33fdfd7cfe74080 (diff) | |
parent | f99dfdb5044ed6b120a8f2a86ddf2dd92a5bb9a2 (diff) | |
download | vold-tools_r22.2.tar.gz |
am f99dfdb5: Merge "vold: fix potential socket leak"tools_r22.2
* commit 'f99dfdb5044ed6b120a8f2a86ddf2dd92a5bb9a2':
vold: fix potential socket leak
-rw-r--r-- | NetlinkManager.cpp | 19 |
1 files changed, 13 insertions, 6 deletions
diff --git a/NetlinkManager.cpp b/NetlinkManager.cpp index 2e15d7fa..dbba303a 100644 --- a/NetlinkManager.cpp +++ b/NetlinkManager.cpp @@ -65,31 +65,38 @@ int NetlinkManager::start() { if (setsockopt(mSock, SOL_SOCKET, SO_RCVBUFFORCE, &sz, sizeof(sz)) < 0) { SLOGE("Unable to set uevent socket SO_RCVBUFFORCE option: %s", strerror(errno)); - return -1; + goto out; } if (setsockopt(mSock, SOL_SOCKET, SO_PASSCRED, &on, sizeof(on)) < 0) { SLOGE("Unable to set uevent socket SO_PASSCRED option: %s", strerror(errno)); - return -1; + goto out; } if (bind(mSock, (struct sockaddr *) &nladdr, sizeof(nladdr)) < 0) { SLOGE("Unable to bind uevent socket: %s", strerror(errno)); - return -1; + goto out; } mHandler = new NetlinkHandler(mSock); if (mHandler->start()) { SLOGE("Unable to start NetlinkHandler: %s", strerror(errno)); - return -1; + goto out; } + return 0; + +out: + close(mSock); + return -1; } int NetlinkManager::stop() { + int status = 0; + if (mHandler->stop()) { SLOGE("Unable to stop NetlinkHandler: %s", strerror(errno)); - return -1; + status = -1; } delete mHandler; mHandler = NULL; @@ -97,5 +104,5 @@ int NetlinkManager::stop() { close(mSock); mSock = -1; - return 0; + return status; } |