diff options
author | Robert Griesemer <gri@golang.org> | 2014-01-28 10:57:56 -0800 |
---|---|---|
committer | Robert Griesemer <gri@golang.org> | 2014-01-28 10:57:56 -0800 |
commit | ebfa4efbc4757eb4dca06f30f67e33c2f5bfa28d (patch) | |
tree | 4331e1070ed8fc9d53bdaea8eab390912331dc50 /oracle | |
parent | aea9f6881139192ada389c3c7b1c93b48a217bb1 (diff) | |
download | tools-ebfa4efbc4757eb4dca06f30f67e33c2f5bfa28d.tar.gz |
go.tools/go/types: cleanup: more consistent exported predicate names
Renamed predicates:
IsIdentical -> Identical
IsAssignableTo -> AssignableTo
Signature.IsVariadic -> Signature.Variadic
Object.IsExported -> Object.Exported
LGTM=adonovan
R=adonovan
CC=golang-codereviews
https://golang.org/cl/53370043
Diffstat (limited to 'oracle')
-rw-r--r-- | oracle/implements.go | 14 | ||||
-rw-r--r-- | oracle/peers.go | 2 |
2 files changed, 8 insertions, 8 deletions
diff --git a/oracle/implements.go b/oracle/implements.go index b5a577a..d914227 100644 --- a/oracle/implements.go +++ b/oracle/implements.go @@ -60,19 +60,19 @@ func implements(o *Oracle, qpos *QueryPos) (queryResult, error) { } // T interface, U interface - if !types.IsIdentical(T, U) { - if types.IsAssignableTo(U, T) { + if !types.Identical(T, U) { + if types.AssignableTo(U, T) { to = append(to, U) } - if types.IsAssignableTo(T, U) { + if types.AssignableTo(T, U) { from = append(from, U) } } } else { // T interface, U concrete - if types.IsAssignableTo(U, T) { + if types.AssignableTo(U, T) { to = append(to, U) - } else if pU := types.NewPointer(U); types.IsAssignableTo(pU, T) { + } else if pU := types.NewPointer(U); types.AssignableTo(pU, T) { to = append(to, pU) } } @@ -82,9 +82,9 @@ func implements(o *Oracle, qpos *QueryPos) (queryResult, error) { } // T concrete, U interface - if types.IsAssignableTo(T, U) { + if types.AssignableTo(T, U) { from = append(from, U) - } else if pT := types.NewPointer(T); types.IsAssignableTo(pT, U) { + } else if pT := types.NewPointer(T); types.AssignableTo(pT, U) { fromPtr = append(fromPtr, U) } } diff --git a/oracle/peers.go b/oracle/peers.go index fa34c9e..c7c24b9 100644 --- a/oracle/peers.go +++ b/oracle/peers.go @@ -63,7 +63,7 @@ func peers(o *Oracle, qpos *QueryPos) (queryResult, error) { o.ptaConfig.AddQuery(queryOp.ch) i := 0 for _, op := range ops { - if types.IsIdentical(op.ch.Type().Underlying().(*types.Chan).Elem(), queryElemType) { + if types.Identical(op.ch.Type().Underlying().(*types.Chan).Elem(), queryElemType) { o.ptaConfig.AddQuery(op.ch) ops[i] = op i++ |