diff options
Diffstat (limited to 'plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing')
16 files changed, 170 insertions, 2 deletions
diff --git a/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/ClashingTraitMethodsInspectionBase.java b/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/ClashingTraitMethodsInspectionBase.java new file mode 100644 index 000000000000..4195dd9a11ae --- /dev/null +++ b/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/ClashingTraitMethodsInspectionBase.java @@ -0,0 +1,153 @@ +/* + * Copyright 2000-2014 JetBrains s.r.o. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.jetbrains.plugins.groovy.codeInspection.confusing; + +import com.intellij.codeInspection.LocalQuickFix; +import com.intellij.codeInspection.ProblemHighlightType; +import com.intellij.openapi.diagnostic.Logger; +import com.intellij.openapi.util.Condition; +import com.intellij.openapi.util.text.StringUtil; +import com.intellij.psi.HierarchicalMethodSignature; +import com.intellij.psi.PsiClass; +import com.intellij.psi.PsiMethod; +import com.intellij.psi.PsiModifier; +import com.intellij.psi.util.PsiFormatUtil; +import com.intellij.psi.util.PsiFormatUtilBase; +import com.intellij.util.Function; +import com.intellij.util.containers.ContainerUtil; +import org.jetbrains.annotations.NotNull; +import org.jetbrains.plugins.groovy.codeInspection.BaseInspection; +import org.jetbrains.plugins.groovy.codeInspection.BaseInspectionVisitor; +import org.jetbrains.plugins.groovy.codeInspection.GroovyFix; +import org.jetbrains.plugins.groovy.lang.psi.api.statements.typedef.GrTypeDefinition; +import org.jetbrains.plugins.groovy.lang.psi.impl.synthetic.GrTraitMethod; +import org.jetbrains.plugins.groovy.lang.psi.util.GrTraitUtil; + +import java.util.Collection; +import java.util.List; + +public abstract class ClashingTraitMethodsInspectionBase extends BaseInspection { + protected static final Logger LOG = Logger.getInstance(ClashingTraitMethodsInspectionBase.class); + + @NotNull + protected static List<ClashingMethod> collectClassingMethods(@NotNull GrTypeDefinition typeDefinition) { + Collection<HierarchicalMethodSignature> visibleSignatures = typeDefinition.getVisibleSignatures(); + + List<ClashingMethod> clashingMethods = ContainerUtil.newArrayList(); + for (HierarchicalMethodSignature signature : visibleSignatures) { + PsiMethod method = signature.getMethod(); + if (method instanceof GrTraitMethod && method.getContainingClass() == typeDefinition) { + List<HierarchicalMethodSignature> superSignatures = signature.getSuperSignatures(); + if (superSignatures.size() > 1) { + List<GrTypeDefinition> traits = ContainerUtil.newArrayList(); + for (HierarchicalMethodSignature superSignature : superSignatures) { + PsiMethod superMethod = superSignature.getMethod(); + PsiClass superClass = superMethod.getContainingClass(); + if (GrTraitUtil.isTrait(superClass) && + !superMethod.getModifierList().hasExplicitModifier(PsiModifier.ABSTRACT)) { + traits.add((GrTypeDefinition)superClass); + } + } + + if (traits.size() > 1) { + clashingMethods.add(new ClashingMethod(signature, traits)); + } + } + } + } + + return clashingMethods; + } + + @NotNull + private static List<PsiClass> collectImplementedTraits(@NotNull GrTypeDefinition typeDefinition) { + return ContainerUtil.findAll(typeDefinition.getSupers(), new Condition<PsiClass>() { + @Override + public boolean value(PsiClass aClass) { + return GrTraitUtil.isTrait(aClass); + } + }); + } + + @NotNull + @Override + protected BaseInspectionVisitor buildVisitor() { + return new BaseInspectionVisitor() { + @Override + public void visitTypeDefinition(GrTypeDefinition typeDefinition) { + super.visitTypeDefinition(typeDefinition); + + List<PsiClass> superTraits = collectImplementedTraits(typeDefinition); + + if (superTraits.size() < 2) return; + + List<ClashingMethod> clashingMethods = collectClassingMethods(typeDefinition); + + for (ClashingMethod clashing : clashingMethods) { + registerError(typeDefinition.getNameIdentifierGroovy(), buildWarning(clashing), new LocalQuickFix[]{getFix()}, ProblemHighlightType.GENERIC_ERROR_OR_WARNING); + } + } + + @NotNull + private String buildWarning(@NotNull ClashingMethod entry) { + return "Traits " + buildTraitString(entry) + " contain clashing methods with signature " + buildSignatureString(entry); + } + + @NotNull + private String buildSignatureString(@NotNull ClashingMethod entry) { + HierarchicalMethodSignature signature = entry.getSignature(); + return PsiFormatUtil.formatMethod(signature.getMethod(), signature.getSubstitutor(), + PsiFormatUtilBase.SHOW_NAME | PsiFormatUtilBase.SHOW_PARAMETERS, + PsiFormatUtilBase.SHOW_TYPE); + } + + @NotNull + private String buildTraitString(@NotNull ClashingMethod entry) { + return StringUtil.join(entry.getSuperTraits(), new Function<GrTypeDefinition, String>() { + @Override + public String fun(GrTypeDefinition tr) { + return tr.getName(); + } + }, ", "); + } + }; + } + + @NotNull + protected LocalQuickFix getFix(){ + return GroovyFix.EMPTY_FIX; + } + + protected static class ClashingMethod { + private final HierarchicalMethodSignature mySignature; + private final List<GrTypeDefinition> mySuperTraits; + + public ClashingMethod(@NotNull HierarchicalMethodSignature signature, @NotNull List<GrTypeDefinition> superTraits) { + mySignature = signature; + mySuperTraits = superTraits; + } + + @NotNull + public HierarchicalMethodSignature getSignature() { + return mySignature; + } + + @NotNull + public List<GrTypeDefinition> getSuperTraits() { + return mySuperTraits; + } + } +} diff --git a/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GrDeprecatedAPIUsageInspection.java b/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GrDeprecatedAPIUsageInspection.java index 916ec5408d90..b8aa7570e08b 100644 --- a/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GrDeprecatedAPIUsageInspection.java +++ b/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GrDeprecatedAPIUsageInspection.java @@ -62,6 +62,7 @@ public class GrDeprecatedAPIUsageInspection extends BaseInspection { return "GrDeprecatedAPIUsage"; } + @NotNull @Override protected BaseInspectionVisitor buildVisitor() { return new BaseInspectionVisitor() { diff --git a/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GrPackageInspection.java b/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GrPackageInspection.java index 2b561b239112..8a1a6007f314 100644 --- a/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GrPackageInspection.java +++ b/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GrPackageInspection.java @@ -79,6 +79,7 @@ public class GrPackageInspection extends BaseInspection { } + @NotNull @Override protected BaseInspectionVisitor buildVisitor() { return new BaseInspectionVisitor() { diff --git a/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GrUnusedIncDecInspection.java b/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GrUnusedIncDecInspection.java index b5dc34e2318a..60ad30f642d5 100644 --- a/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GrUnusedIncDecInspection.java +++ b/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GrUnusedIncDecInspection.java @@ -51,6 +51,7 @@ import java.util.List; */ public class GrUnusedIncDecInspection extends BaseInspection { private static final Logger LOG = Logger.getInstance(GrUnusedIncDecInspection.class); + @NotNull @Override protected BaseInspectionVisitor buildVisitor() { return new GrUnusedIncDecInspectionVisitor(); diff --git a/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GroovyConditionalInspection.java b/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GroovyConditionalInspection.java index 6b532066f1f5..55b314ef6b81 100644 --- a/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GroovyConditionalInspection.java +++ b/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GroovyConditionalInspection.java @@ -45,6 +45,7 @@ public class GroovyConditionalInspection extends BaseInspection { } + @NotNull @Override public BaseInspectionVisitor buildVisitor() { return new Visitor(); diff --git a/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GroovyDoubleNegationInspection.java b/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GroovyDoubleNegationInspection.java index 7b22f17b289c..b293326196df 100644 --- a/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GroovyDoubleNegationInspection.java +++ b/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GroovyDoubleNegationInspection.java @@ -56,7 +56,7 @@ public class GroovyDoubleNegationInspection extends BaseInspection { @Override @Nullable - protected GroovyFix buildFix(PsiElement location) { + protected GroovyFix buildFix(@NotNull PsiElement location) { return new DoubleNegationFix(); } @@ -105,6 +105,7 @@ public class GroovyDoubleNegationInspection extends BaseInspection { } } + @NotNull @Override public BaseInspectionVisitor buildVisitor() { return new DoubleNegationVisitor(); diff --git a/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GroovyEmptyStatementBodyInspection.java b/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GroovyEmptyStatementBodyInspection.java index 4dd95e9e3b61..af8f89ad4aed 100644 --- a/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GroovyEmptyStatementBodyInspection.java +++ b/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GroovyEmptyStatementBodyInspection.java @@ -53,6 +53,7 @@ public class GroovyEmptyStatementBodyInspection extends BaseInspection { } } + @NotNull @Override public BaseInspectionVisitor buildVisitor() { return new Visitor(); diff --git a/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GroovyNegatedConditionalInspection.java b/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GroovyNegatedConditionalInspection.java index e28e499cfb28..e6611c083e8b 100644 --- a/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GroovyNegatedConditionalInspection.java +++ b/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GroovyNegatedConditionalInspection.java @@ -47,6 +47,7 @@ public class GroovyNegatedConditionalInspection extends BaseInspection { } + @NotNull @Override public BaseInspectionVisitor buildVisitor() { return new Visitor(); diff --git a/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GroovyNegatedIfInspection.java b/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GroovyNegatedIfInspection.java index 471428f83a13..611c292ae6d1 100644 --- a/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GroovyNegatedIfInspection.java +++ b/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GroovyNegatedIfInspection.java @@ -47,6 +47,7 @@ public class GroovyNegatedIfInspection extends BaseInspection { } + @NotNull @Override public BaseInspectionVisitor buildVisitor() { return new Visitor(); diff --git a/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GroovyNestedConditionalInspection.java b/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GroovyNestedConditionalInspection.java index 621247d6563c..108c0ebd897b 100644 --- a/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GroovyNestedConditionalInspection.java +++ b/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GroovyNestedConditionalInspection.java @@ -46,6 +46,7 @@ public class GroovyNestedConditionalInspection extends BaseInspection { } + @NotNull @Override public BaseInspectionVisitor buildVisitor() { return new Visitor(); diff --git a/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GroovyNestedSwitchInspection.java b/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GroovyNestedSwitchInspection.java index 72a16dda7ed6..ad289110f4f2 100644 --- a/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GroovyNestedSwitchInspection.java +++ b/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GroovyNestedSwitchInspection.java @@ -46,6 +46,7 @@ public class GroovyNestedSwitchInspection extends BaseInspection { } + @NotNull @Override public BaseInspectionVisitor buildVisitor() { return new Visitor(); diff --git a/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GroovyOctalIntegerInspection.java b/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GroovyOctalIntegerInspection.java index e3bb3025508b..c9e587135a17 100644 --- a/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GroovyOctalIntegerInspection.java +++ b/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GroovyOctalIntegerInspection.java @@ -45,6 +45,7 @@ public class GroovyOctalIntegerInspection extends BaseInspection { return "Octal integer #ref #loc"; } + @NotNull @Override public BaseInspectionVisitor buildVisitor() { return new BaseInspectionVisitor() { diff --git a/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GroovyOverlyComplexArithmeticExpressionInspectionBase.java b/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GroovyOverlyComplexArithmeticExpressionInspectionBase.java index 3d09c275ee3f..24b4d0ebb853 100644 --- a/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GroovyOverlyComplexArithmeticExpressionInspectionBase.java +++ b/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GroovyOverlyComplexArithmeticExpressionInspectionBase.java @@ -60,6 +60,7 @@ public class GroovyOverlyComplexArithmeticExpressionInspectionBase extends BaseI return "Overly complex arithmetic expression #loc"; } + @NotNull @Override public BaseInspectionVisitor buildVisitor() { return new Visitor(); diff --git a/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GroovyOverlyComplexBooleanExpressionInspectionBase.java b/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GroovyOverlyComplexBooleanExpressionInspectionBase.java index 73c74fb52d1f..6a4d9c0d54da 100644 --- a/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GroovyOverlyComplexBooleanExpressionInspectionBase.java +++ b/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GroovyOverlyComplexBooleanExpressionInspectionBase.java @@ -54,6 +54,7 @@ public class GroovyOverlyComplexBooleanExpressionInspectionBase extends BaseInsp return "Overly complex boolean expression #loc"; } + @NotNull @Override public BaseInspectionVisitor buildVisitor() { return new Visitor(); diff --git a/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GroovyPointlessBooleanInspection.java b/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GroovyPointlessBooleanInspection.java index 8fe93903b567..7d1c46820771 100644 --- a/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GroovyPointlessBooleanInspection.java +++ b/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GroovyPointlessBooleanInspection.java @@ -59,6 +59,7 @@ public class GroovyPointlessBooleanInspection extends BaseInspection { return true; } + @NotNull @Override public BaseInspectionVisitor buildVisitor() { return new PointlessBooleanExpressionVisitor(); @@ -162,7 +163,7 @@ public class GroovyPointlessBooleanInspection extends BaseInspection { } @Override - public GroovyFix buildFix(PsiElement location) { + public GroovyFix buildFix(@NotNull PsiElement location) { return new BooleanLiteralComparisonFix(); } diff --git a/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GroovyResultOfIncrementOrDecrementUsedInspection.java b/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GroovyResultOfIncrementOrDecrementUsedInspection.java index a750d6cf8f60..92e86425b685 100644 --- a/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GroovyResultOfIncrementOrDecrementUsedInspection.java +++ b/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/codeInspection/confusing/GroovyResultOfIncrementOrDecrementUsedInspection.java @@ -47,6 +47,7 @@ public class GroovyResultOfIncrementOrDecrementUsedInspection extends BaseInspec return "Result of increment or decrement expression used #loc"; } + @NotNull @Override public BaseInspectionVisitor buildVisitor() { return new Visitor(); |