blob: f588b120b8d5df96ee3dd2279d3bb27ab0cb5bd4 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
|
/*
* Copyright 2003-2014 Dave Griffith, Bas Leijdekkers
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.siyeh.ig.memory;
import com.intellij.codeInsight.FileModificationService;
import com.intellij.codeInspection.ProblemDescriptor;
import com.intellij.openapi.project.Project;
import com.intellij.psi.*;
import com.intellij.psi.codeStyle.JavaCodeStyleManager;
import com.intellij.psi.search.SearchScope;
import com.intellij.psi.search.searches.ReferencesSearch;
import com.intellij.util.Query;
import com.siyeh.InspectionGadgetsBundle;
import com.siyeh.ig.BaseInspection;
import com.siyeh.ig.BaseInspectionVisitor;
import com.siyeh.ig.InspectionGadgetsFix;
import org.jetbrains.annotations.NotNull;
import java.util.ArrayList;
import java.util.Collection;
import java.util.List;
public class InnerClassMayBeStaticInspection extends BaseInspection {
@Override
@NotNull
public String getDisplayName() {
return InspectionGadgetsBundle.message("inner.class.may.be.static.display.name");
}
@Override
@NotNull
protected String buildErrorString(Object... infos) {
return InspectionGadgetsBundle.message("inner.class.may.be.static.problem.descriptor");
}
@Override
public boolean runForWholeFile() {
return true;
}
@Override
protected InspectionGadgetsFix buildFix(Object... infos) {
return new InnerClassMayBeStaticFix();
}
private static class InnerClassMayBeStaticFix extends InspectionGadgetsFix {
@Override
@NotNull
public String getFamilyName() {
return getName();
}
@Override
@NotNull
public String getName() {
return InspectionGadgetsBundle.message("make.static.quickfix");
}
@Override
protected boolean prepareForWriting() {
return false;
}
@Override
public void doFix(Project project, ProblemDescriptor descriptor) {
final PsiJavaToken classNameToken = (PsiJavaToken)descriptor.getPsiElement();
final PsiClass innerClass = (PsiClass)classNameToken.getParent();
if (innerClass == null) {
return;
}
final SearchScope useScope = innerClass.getUseScope();
final Query<PsiReference> query = ReferencesSearch.search(innerClass, useScope);
final Collection<PsiReference> references = query.findAll();
final List<PsiElement> elements = new ArrayList(references);
for (PsiReference reference : references) {
elements.add(reference.getElement());
}
elements.add(innerClass);
if (!FileModificationService.getInstance().preparePsiElementsForWrite(elements)) {
return;
}
final JavaCodeStyleManager codeStyleManager = JavaCodeStyleManager.getInstance(project);
final PsiElementFactory factory = JavaPsiFacade.getElementFactory(project);
for (final PsiReference reference : references) {
final PsiElement element = reference.getElement();
final PsiElement parent = element.getParent();
if (!(parent instanceof PsiNewExpression)) {
continue;
}
final PsiNewExpression newExpression = (PsiNewExpression)parent;
final PsiJavaCodeReferenceElement classReference = newExpression.getClassReference();
if (classReference == null) {
continue;
}
final PsiExpressionList argumentList = newExpression.getArgumentList();
if (argumentList == null) {
continue;
}
final PsiExpression expression =
factory.createExpressionFromText("new " + classReference.getQualifiedName() + argumentList.getText(), innerClass);
codeStyleManager.shortenClassReferences(newExpression.replace(expression));
}
final PsiModifierList modifiers = innerClass.getModifierList();
if (modifiers == null) {
return;
}
modifiers.setModifierProperty(PsiModifier.STATIC, true);
}
}
@Override
public BaseInspectionVisitor buildVisitor() {
return new InnerClassMayBeStaticVisitor();
}
private static class InnerClassMayBeStaticVisitor extends BaseInspectionVisitor {
@Override
public void visitClass(@NotNull PsiClass aClass) {
if (aClass.getContainingClass() != null && !aClass.hasModifierProperty(PsiModifier.STATIC)) {
return;
}
if (aClass instanceof PsiAnonymousClass) {
return;
}
final PsiClass[] innerClasses = aClass.getInnerClasses();
for (final PsiClass innerClass : innerClasses) {
if (innerClass.hasModifierProperty(PsiModifier.STATIC)) {
continue;
}
final InnerClassReferenceVisitor visitor = new InnerClassReferenceVisitor(innerClass);
innerClass.accept(visitor);
if (!visitor.canInnerClassBeStatic()) {
continue;
}
registerClassError(innerClass);
}
}
}
}
|
