1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
|
/*
* Copyright 2003-2012 Dave Griffith, Bas Leijdekkers
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.siyeh.ig.style;
import com.intellij.codeInspection.CleanupLocalInspectionTool;
import com.intellij.codeInspection.ProblemDescriptor;
import com.intellij.openapi.project.Project;
import com.intellij.psi.*;
import com.intellij.util.IncorrectOperationException;
import com.siyeh.InspectionGadgetsBundle;
import com.siyeh.ig.BaseInspection;
import com.siyeh.ig.BaseInspectionVisitor;
import com.siyeh.ig.InspectionGadgetsFix;
import com.siyeh.ig.psiutils.ClassUtils;
import org.jetbrains.annotations.NotNull;
public class UnnecessaryEnumModifierInspection extends BaseInspection implements CleanupLocalInspectionTool{
@Override
@NotNull
public String getDisplayName() {
return InspectionGadgetsBundle.message("unnecessary.enum.modifier.display.name");
}
@Override
@NotNull
public String buildErrorString(Object... infos) {
final PsiElement parent = (PsiElement)infos[1];
if (parent instanceof PsiMethod) {
return InspectionGadgetsBundle.message("unnecessary.enum.modifier.problem.descriptor");
}
else {
return InspectionGadgetsBundle.message("unnecessary.enum.modifier.problem.descriptor1");
}
}
@Override
public BaseInspectionVisitor buildVisitor() {
return new UnnecessaryEnumModifierVisitor();
}
@Override
public InspectionGadgetsFix buildFix(Object... infos) {
return new UnnecessaryEnumModifierFix((PsiElement)infos[0]);
}
private static class UnnecessaryEnumModifierFix extends InspectionGadgetsFix {
private final String m_name;
private UnnecessaryEnumModifierFix(PsiElement modifier) {
m_name = InspectionGadgetsBundle.message("smth.unnecessary.remove.quickfix", modifier.getText());
}
@Override
@NotNull
public String getName() {
return m_name;
}
@NotNull
@Override
public String getFamilyName() {
return "Remove unnecessary modifiers";
}
@Override
public void doFix(Project project, ProblemDescriptor descriptor) throws IncorrectOperationException {
final PsiElement element = descriptor.getPsiElement();
final PsiModifierList modifierList;
if (element instanceof PsiModifierList) {
modifierList = (PsiModifierList)element;
}
else {
modifierList = (PsiModifierList)element.getParent();
}
assert modifierList != null;
if (modifierList.getParent() instanceof PsiClass) {
modifierList.setModifierProperty(PsiModifier.STATIC, false);
}
else {
modifierList.setModifierProperty(PsiModifier.PRIVATE, false);
}
}
}
private static class UnnecessaryEnumModifierVisitor extends BaseInspectionVisitor {
@Override
public void visitClass(@NotNull PsiClass aClass) {
if (!aClass.isEnum() || !ClassUtils.isInnerClass(aClass) || !aClass.hasModifierProperty(PsiModifier.STATIC)) {
return;
}
final PsiModifierList modifiers = aClass.getModifierList();
if (modifiers == null) {
return;
}
final PsiElement[] children = modifiers.getChildren();
for (final PsiElement child : children) {
final String text = child.getText();
if (PsiModifier.STATIC.equals(text)) {
registerError(child, child, aClass);
}
}
}
@Override
public void visitMethod(@NotNull PsiMethod method) {
if (!method.isConstructor() || !method.hasModifierProperty(PsiModifier.PRIVATE)) {
return;
}
final PsiClass aClass = method.getContainingClass();
if (aClass == null || !aClass.isEnum()) {
return;
}
final PsiModifierList modifiers = method.getModifierList();
final PsiElement[] children = modifiers.getChildren();
for (final PsiElement child : children) {
final String text = child.getText();
if (PsiModifier.PRIVATE.equals(text)) {
registerError(child, child, method);
}
}
}
}
}
|
