summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSal Guarnieri <salguarnieri@google.com>2014-11-11 15:28:32 -0500
committerSal Guarnieri <salguarnieri@google.com>2014-11-11 16:38:03 -0500
commit953e8a92c92aa8dcb9604aaec3d10d130989029e (patch)
treee15435e6516306496440fe08e4aa40222b9daf6c
parentc2f99dc9e24c015f6d420e0b93fec1066e6f66cd (diff)
downloadlogin-953e8a92c92aa8dcb9604aaec3d10d130989029e.tar.gz
Currently, if a user cannot login, we present a fatal error to the user.
This is not a fatal error, the code correctly handles the situation when the user cannot be logged in. It is still good to log this situation though, in the event that it leads to other problems down the line. The fix is to lower the severity of the logging we are doing such that we no longer present the user with this information. This bug was discovered by: 1) logging in to Android Studio 2) closing Android Studio 3) disconnecting from the network 4) starting up Android Studio again Change-Id: I4d0c7ced86554ae0b58858809e6cf0b37c229424
-rw-r--r--src/com/google/gct/login/GoogleLoginUtils.java6
1 files changed, 5 insertions, 1 deletions
diff --git a/src/com/google/gct/login/GoogleLoginUtils.java b/src/com/google/gct/login/GoogleLoginUtils.java
index 27e1f5e..2373ae3 100644
--- a/src/com/google/gct/login/GoogleLoginUtils.java
+++ b/src/com/google/gct/login/GoogleLoginUtils.java
@@ -84,7 +84,11 @@ public class GoogleLoginUtils {
try {
userInfo = userInfoService.userinfo().get().execute();
} catch (IOException e) {
- LOG.error("Error retrieving user information.", e);
+ //The core IDE functionality still works, so this does
+ //not affect anything right now. The user will receive
+ //error messages when they attempt to do something that
+ //requires a logged in state.
+ LOG.warn("Error retrieving user information.", e);
}
if (userInfo != null && userInfo.getId() != null) {