diff options
| author | Tom Tan <Tom.Tan@microsoft.com> | 2019-02-11 20:04:02 +0000 |
|---|---|---|
| committer | Tom Tan <Tom.Tan@microsoft.com> | 2019-02-11 20:04:02 +0000 |
| commit | 47d8247c07da560e693976d3353d87b107bb39ee (patch) | |
| tree | fff9f274834888380fe6580463a95ce7b98f435b | |
| parent | f448354ba11338c01bc091690e6a64a8d4a4992a (diff) | |
| download | clang-47d8247c07da560e693976d3353d87b107bb39ee.tar.gz | |
[COFF, ARM64] Remove definitions for _byteswap library functions
_byteswap_* functions are are implemented in below file as normal function
from libucrt.lib and declared in stdlib.h. Define them in intrin.h triggers
lld error "conflicting comdat type" and "duplicate symbols" which was just
added to LLD (https://reviews.llvm.org/D57324).
C:\Program Files (x86)\Windows Kits\10\Source\10.0.17763.0\ucrt\stdlib\byteswap.cpp
Differential Revision: https://reviews.llvm.org/D57915
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@353740 91177308-0d34-0410-b5e6-96231b3b80d8
| -rw-r--r-- | lib/Headers/intrin.h | 12 | ||||
| -rw-r--r-- | test/Headers/ms-arm64-intrin.cpp | 6 |
2 files changed, 6 insertions, 12 deletions
diff --git a/lib/Headers/intrin.h b/lib/Headers/intrin.h index 6cc6155aa6..e7508a4c15 100644 --- a/lib/Headers/intrin.h +++ b/lib/Headers/intrin.h @@ -557,15 +557,9 @@ long _InterlockedAdd(long volatile *Addend, long Value); __int64 _ReadStatusReg(int); void _WriteStatusReg(int, __int64); -static inline unsigned short _byteswap_ushort (unsigned short val) { - return __builtin_bswap16(val); -} -static inline unsigned long _byteswap_ulong (unsigned long val) { - return __builtin_bswap32(val); -} -static inline unsigned __int64 _byteswap_uint64 (unsigned __int64 val) { - return __builtin_bswap64(val); -} +unsigned short __cdecl _byteswap_ushort(unsigned short val); +unsigned long __cdecl _byteswap_ulong (unsigned long val); +unsigned __int64 __cdecl _byteswap_uint64(unsigned __int64 val); #endif /*----------------------------------------------------------------------------*\ diff --git a/test/Headers/ms-arm64-intrin.cpp b/test/Headers/ms-arm64-intrin.cpp index 729ca5e7f2..2e052b33bf 100644 --- a/test/Headers/ms-arm64-intrin.cpp +++ b/test/Headers/ms-arm64-intrin.cpp @@ -14,16 +14,16 @@ void check_nop() { } unsigned short check_byteswap_ushort(unsigned short val) { -// CHECK: call i16 @llvm.bswap.i16(i16 %val) +// CHECK: call i16 @_byteswap_ushort(i16 %val) return _byteswap_ushort(val); } unsigned long check_byteswap_ulong(unsigned long val) { -// CHECK: call i32 @llvm.bswap.i32(i32 %val) +// CHECK: call i32 @_byteswap_ulong(i32 %val) return _byteswap_ulong(val); } unsigned __int64 check_byteswap_uint64(unsigned __int64 val) { -// CHECK: call i64 @llvm.bswap.i64(i64 %val) +// CHECK: call i64 @_byteswap_uint64(i64 %val) return _byteswap_uint64(val); } |