diff options
| author | Bryan C. Mills <bcmills@google.com> | 2023-08-15 18:01:16 -0400 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2023-08-16 19:05:12 +0000 |
| commit | 9f03e8367d85d75675b2f2e90873e3293799d8aa (patch) | |
| tree | 3f32a8ebe257c9c081b04af270e53ec54da2f83b /src | |
| parent | 5b8ceb38a17c60d1b396f21418674f7be9ab1ac0 (diff) | |
| download | go-9f03e8367d85d75675b2f2e90873e3293799d8aa.tar.gz | |
os: skip Chown tests for auxiliary groups that fail due to permission errors
This addresses the failure mode described in
https://git.alpinelinux.org/aports/commit/community/go/tests-filter-overflow-gid.patch?id=9851dde0f5d2a5a50f7f3b5323d1b2ff22e1d028,
but without special-casing an implementation-specific group ID.
For #62053.
Change-Id: I70b1046837b8146889fff7085497213349cd2bf0
Reviewed-on: https://go-review.googlesource.com/c/go/+/520055
Reviewed-by: Ian Lance Taylor <iant@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Bryan Mills <bcmills@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/os/os_unix_test.go | 22 |
1 files changed, 22 insertions, 0 deletions
diff --git a/src/os/os_unix_test.go b/src/os/os_unix_test.go index 9041b25471..e4271ff905 100644 --- a/src/os/os_unix_test.go +++ b/src/os/os_unix_test.go @@ -75,6 +75,12 @@ func TestChown(t *testing.T) { t.Log("groups: ", groups) for _, g := range groups { if err = Chown(f.Name(), -1, g); err != nil { + if testenv.SyscallIsNotSupported(err) { + t.Logf("chown %s -1 %d: %s (error ignored)", f.Name(), g, err) + // Since the Chown call failed, the file should be unmodified. + checkUidGid(t, f.Name(), int(sys.Uid), gid) + continue + } t.Fatalf("chown %s -1 %d: %s", f.Name(), g, err) } checkUidGid(t, f.Name(), int(sys.Uid), g) @@ -123,6 +129,12 @@ func TestFileChown(t *testing.T) { t.Log("groups: ", groups) for _, g := range groups { if err = f.Chown(-1, g); err != nil { + if testenv.SyscallIsNotSupported(err) { + t.Logf("chown %s -1 %d: %s (error ignored)", f.Name(), g, err) + // Since the Chown call failed, the file should be unmodified. + checkUidGid(t, f.Name(), int(sys.Uid), gid) + continue + } t.Fatalf("fchown %s -1 %d: %s", f.Name(), g, err) } checkUidGid(t, f.Name(), int(sys.Uid), g) @@ -181,12 +193,22 @@ func TestLchown(t *testing.T) { t.Log("groups: ", groups) for _, g := range groups { if err = Lchown(linkname, -1, g); err != nil { + if testenv.SyscallIsNotSupported(err) { + t.Logf("lchown %s -1 %d: %s (error ignored)", f.Name(), g, err) + // Since the Lchown call failed, the file should be unmodified. + checkUidGid(t, f.Name(), int(sys.Uid), gid) + continue + } t.Fatalf("lchown %s -1 %d: %s", linkname, g, err) } checkUidGid(t, linkname, int(sys.Uid), g) // Check that link target's gid is unchanged. checkUidGid(t, f.Name(), int(sys.Uid), int(sys.Gid)) + + if err = Lchown(linkname, -1, gid); err != nil { + t.Fatalf("lchown %s -1 %d: %s", f.Name(), gid, err) + } } } |